[bug#48729] [PATCH v5 24/25] gnu: Add bitmask.

[Maxime Devos <maximedevos@telenet.be>]

[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]

Raghav Gururajan via Guix-patches via schreef op vr 18-06-2021 om 02:54 [-0400]:
> +       (snippet
> +        `(begin
> +           ;; To remove bundled thirdparty sources.
> +           (delete-file-recursively "branding/thirdparty")
> +           ;; To generate version.go file.
> +           (call-with-output-file "pkg/config/version/version.go"
> +             (lambda (port)
> +               (format port "package version\n")
> +               (format port "\n")
> +               (format port (string-append "var VERSION = \"" ,version "\""))))
> +           #t))))

Snippets can be G-expressions. Personally, I'd go with a G-expression
instead of an S-expression, because

* that makes it more obvious it is staged code, and not, say, SXML
* G-exps are cool [citation needed]

> +    (build-system go-build-system)
> +    (arguments [...])

A bit large, but all the code there seems required
Seems ok, though not being able to build i18n files is a bit
unfortunate.

> +    (synopsis "White-label VPN client by LEAP")

About ‘White-label’: this seems an odd thing to say about software.
Here is a definition, in case we are talking about different things:

From Wikipedia (https://en.wikipedia.org/w/index.php?title=White-label_product&oldid=1028825641):

‘A white-label product is a product or service produced by one company (the producer)
that other companies (the marketers) rebrand to make it appear as if they had made
it.[1][2] The name derives from the image of a white label on the packaging that can
be filled in with the marketer's trade dress. White label products are sold by retailers
with their own trademark but the products themselves are manufactured by a third party.[3]’

bitmask isn't a product or a service, it's just software.
It is also not sold.  I don't see how ‘white-label’ can apply to bitmask.

Also, I don't see what value adding "White-label" to the synopsis
provides to users(*).

(*) Here, ‘users’ are all people using Guix. Including people hacking on Guix
    (‘developers’).

I'd drop "White-label" from the synopsis.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]