From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GLQ/IcX6RWF2qgAAgWs5BA (envelope-from ) for ; Sat, 18 Sep 2021 16:42:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eJfxHMX6RWEhfwAA1q6Kng (envelope-from ) for ; Sat, 18 Sep 2021 14:42:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8698987F9 for ; Sat, 18 Sep 2021 16:42:12 +0200 (CEST) Received: from localhost ([::1]:44414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRbXf-00065k-8A for larch@yhetil.org; Sat, 18 Sep 2021 10:42:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRbXW-00065N-2o for guix-patches@gnu.org; Sat, 18 Sep 2021 10:42:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRbXV-0001Iy-Rp for guix-patches@gnu.org; Sat, 18 Sep 2021 10:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRbXV-0008EU-PS for guix-patches@gnu.org; Sat, 18 Sep 2021 10:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50614] [PATCH] build: utils: Add =?UTF-8?Q?=E2=80=98list-when=E2=80=99?= macro. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Sep 2021 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50614 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Xinglu Chen , 50614@debbugs.gnu.org Cc: Sarah Morgensen Received: via spool by 50614-submit@debbugs.gnu.org id=B50614.163197611331631 (code B ref 50614); Sat, 18 Sep 2021 14:42:01 +0000 Received: (at 50614) by debbugs.gnu.org; 18 Sep 2021 14:41:53 +0000 Received: from localhost ([127.0.0.1]:36432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRbXN-0008E7-33 for submit@debbugs.gnu.org; Sat, 18 Sep 2021 10:41:53 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:47780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRbXL-0008Dy-91 for 50614@debbugs.gnu.org; Sat, 18 Sep 2021 10:41:52 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by baptiste.telenet-ops.be with bizsmtp id vSho2500J0mfAB401Sho9x; Sat, 18 Sep 2021 16:41:49 +0200 Message-ID: <9b662947afe2da5d5243bfa09fa85a1caf9ab2cc.camel@telenet.be> From: Maxime Devos Date: Sat, 18 Sep 2021 16:41:42 +0200 In-Reply-To: References: <08db559a4e24a409d332b3552d6a176de6353166.1631867018.git.public@yoctocell.xyz> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ftP8CVdGEmwI5TJw2k1s" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1631976109; bh=n/WxhpW4Drmd/1anVb+M0pZ/uXYctrd4z4Fa4R1c7Vo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=nUxC7nd8+dI+MouVJAv1/pLAZ3bxAqYL+9seqVPM8XD/lcHofLRM0lf5bWXaQEUZx i+hiL71X2FcXieBEJcwqYjhwz4wBflsFL9dUXBU6/rEtLqC8INybt9sdpQv/5yOZcp Rb8Vi+ZTDd47NPWN87dcmaR+0X5FTXyjRT2NJHL0aSx8hOtHmF2YPcFDHKrk0FnQJ9 jLnWz6SRRW0dhaG+5FFSUiscMUlXIfSU04FAkpFk45FiJppzUJhAakJYqteVXEY4nL 6qlKawL7dKD+9yWQyQ9glyosRqaYmdak2APM78YzP4305/2fpuggBcndQDdZ7+HlbS A2f7/l6egnyQw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631976133; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=n/WxhpW4Drmd/1anVb+M0pZ/uXYctrd4z4Fa4R1c7Vo=; b=hIWrBHwG+m/S7ZVwE/lLhRDqMpnB0AoVNjMwiUhZd1cIHWeLyGpOpKPSxN72yvCJSWS/uy P2pkZsezLOelAQkIVviAFYpAcGxgvLhj5xYac3ZtnMDH+EtaxyZNxxvMsGSha+KzE9NFQj Bl25XaPc1KekjfCqB0EUyUXgfts9owWS6aRaxQN5FLUs/JHgUCHwaRtWKkkz94eg9awK66 CFPHFGoXVOARCaSOp3qmVLOlBRbHJELAQoduXV//nWnPs3n3AheyJ65gm1UXH6Y6GACUk7 3HnI5YZ1kZjCu91oj3AmwibfTH6a4JxxCpUVfQCdJyfPaRJsd03XpnNHswD9Dg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631976133; a=rsa-sha256; cv=none; b=qprQTdyqPvR7Yh0WaIyBXcrAJjohbRhPKJ0tdHp5xkeHD3m2RXv2AXDPCK6ojn9NuMLeYf zWpTWaLHBnXGOoPPqRCL3GGsHaZQZ2WSuLH0OErhn1pFYZaZk5pYutq07MEOOKPUlMzLT7 nb93qpwPcNVf5q59sizLsdaaz0AVSvl0De5dLE40/i9NTztGspEiw76aUmnTLEuXYn3wi6 jQGKZOVdGK2EmO0tGf54S2zQLPnGP+1Z1vx913CbcP5XIyGfzEiQlhMcv6n3Y/l3NsMPej JJVBIfIujqKh9B+zd5q4jQve/cXFVjDpC0qTHaZwFvVaen9SX+n3rhfiSBlayg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=nUxC7nd8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=nUxC7nd8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8698987F9 X-Spam-Score: -0.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: AnPHnSUa6/Qg --=-ftP8CVdGEmwI5TJw2k1s Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler schreef op vr 17-09-2021 om 19:55 [+0200]: > Am Freitag, den 17.09.2021, 10:26 +0200 schrieb Xinglu Chen: > > * guix/build/utils.scm (list-when): New syntax > > * tests/build-utils.scm ("list-when: expr1 is non-#f", list-when: > > expr1 is #f"): > > Test it. > > * guix.texi (Build Utilities): Document it. > > --- > > Changes since v1: > >=20 > > * Rename =E2=80=98optional=E2=80=99 to =E2=80=98list-when=E2=80=99. > >=20 > > * Make > >=20 > > (list-when test consequent ...) > >=20 > > equivalent to > >=20 > > (if tests > > (list consequent ...) > > '()) > LGTM, but let's wait on more opinions. It looks nice to me, though you might want an opinion from someone who is new to Scheme. Greetings, Maxime. --=-ftP8CVdGEmwI5TJw2k1s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYUX6pxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hIUAPsGwfhTLPq6OgTLxssjGXoewgdE sqqNd2VLDvfmXypKDAD+LaBJies1pB2XMyqHxOR/kd4wrl2lwo9Xk/FNooMLTAg= =A59r -----END PGP SIGNATURE----- --=-ftP8CVdGEmwI5TJw2k1s--