From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eMfFImSxmGHZMgEAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 09:27:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eHNuHmSxmGGVYQAAB5/wlQ (envelope-from ) for ; Sat, 20 Nov 2021 08:27:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED63732CA7 for ; Sat, 20 Nov 2021 09:27:15 +0100 (CET) Received: from localhost ([::1]:36192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moLiM-00065n-AI for larch@yhetil.org; Sat, 20 Nov 2021 03:27:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLiB-00065U-42 for guix-patches@gnu.org; Sat, 20 Nov 2021 03:27:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moLiA-0004CJ-Rq for guix-patches@gnu.org; Sat, 20 Nov 2021 03:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moLiA-0006S1-PG for guix-patches@gnu.org; Sat, 20 Nov 2021 03:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51967] [PATCH] gnu: Add gsimplecal Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51967 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jaft , "51967@debbugs.gnu.org" <51967@debbugs.gnu.org> Received: via spool by 51967-submit@debbugs.gnu.org id=B51967.163739682024778 (code B ref 51967); Sat, 20 Nov 2021 08:27:02 +0000 Received: (at 51967) by debbugs.gnu.org; 20 Nov 2021 08:27:00 +0000 Received: from localhost ([127.0.0.1]:41588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLi7-0006RZ-Q4 for submit@debbugs.gnu.org; Sat, 20 Nov 2021 03:27:00 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLi4-0006RH-Ud for 51967@debbugs.gnu.org; Sat, 20 Nov 2021 03:26:58 -0500 Received: by mail-wr1-f67.google.com with SMTP id d5so22315755wrc.1 for <51967@debbugs.gnu.org>; Sat, 20 Nov 2021 00:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=gSL3kyoEi+tGJwR42U1kLZIIF+zlG0Cyvx9daknvIkM=; b=Be9f+g/RE4iimeyFCJB349GOvu05dMEVEhtCxz8Nh2WG41U/2TiqY1B3MsmxtgiCvJ /y8ivy/G1S+rNvXtaxKJEnwMSk0nJeb66vZv6WjRjkO2LorqQrGSioFowLaR/jEsQ+LK EZVSYt7dW8jNy16sScsK2LmMn4l1HGmYNa9EMOTz8zn1hIR75kBc9SzyQqi8WhHMi7MG 9MtKZ7VvWGee+wsJpYx7iTa/5UYTg4xMY7hNQ3TVGL1+CCTK2IkfQqDhhtwr5zsq4tIR oKCn2pnIuusZe/5F+20yPa/DWnxYHwtw19Dk3+i6VtzjpNnEOdXqBTABLIzBWEp1+q8v 5yxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gSL3kyoEi+tGJwR42U1kLZIIF+zlG0Cyvx9daknvIkM=; b=lJz42/MoQPP1wftdXU9d2soYcy+PSGDsWZrg1joRUZO2XgnglJuXw2d4lyWPu1crHG Pr8LAAq+Qk40l/bULlfRLhhBQmSm1Rp02NlXo+wqzOHnnDitPgjtrGwiTljZ+SaqgIAT v8COwOebci36itc/i1HxTNTrcTjyPVvjYPSTQ+AFw+hKjNU4MmKhNtvr9jNALL2WGY6i suc/wXUn10czXuubZ3bxkUPadeTTe/Cd9QMZxm/jlghsNXJFQ6mDyHmvPOb/SuCHAz3v X/8t6vLsdC9SachuoXLzaQUbf4L7UzTvbJFSsOdxrspeX3bFEjytchpSeb7r/tsBiFxw MEmQ== X-Gm-Message-State: AOAM53384y380jkE+xqG4gMpTsjRXoyymWfTkE5Zjx85o98ctOVdGk27 2tEsYQGOochnmv5isuNvp1w= X-Google-Smtp-Source: ABdhPJwau/pvpHpMapeZPrYTBMmv6mXhuDpKPbLx7zT9vIdIVdrGP/XLD51BxDmANBHFHGVeyJVFKQ== X-Received: by 2002:a5d:6a89:: with SMTP id s9mr15503028wru.123.1637396811043; Sat, 20 Nov 2021 00:26:51 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z6sm2007345wrm.93.2021.11.20.00.26.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Nov 2021 00:26:50 -0800 (PST) Message-ID: <9b5d6f2b91ee4f264ac2f85a8168b36164be3338.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 20 Nov 2021 09:26:48 +0100 In-Reply-To: References: <427074269.3711284.1637369191506.ref@mail.yahoo.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637396836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gSL3kyoEi+tGJwR42U1kLZIIF+zlG0Cyvx9daknvIkM=; b=UyKVb7s4+gYpLBxj/XGfXXQs7Sw7x0uOPttBu3YFjc9vWkEHFSnP/JNPJGz+ECAL2euk0r aYmOiIY3gG/5hITmrvM50PND3IuNVf/b7n/6vhtnNih/0H16exDnsDTglCGoRKqPH8H9E0 WlRj79cwqOlNtmGCASeJ3qQoiiOxm98zEGnbKMOI+ogtimsY2QSFTBfPxu0ikrhRTPs/gO v50k/gPSU0O9S9ikeoKZqxMJ2Y6V6I3yOrszrNUDdGxVzb8+94BbwJZ2dOM9xRW5eMQWcN fJW7lSPQs3B7YkC+wU5LSfy1bzyQZGF8HsBXG92K3mFTARScDt3yv/dCuJdz/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637396836; a=rsa-sha256; cv=none; b=IfNcdT6GMDlsVmSVBQSI22Pjp8L2rOYizurb1W0f42LX7pwTLGXA2Ugx8MACuW7aM+fcBb rqFGQa6cOwkcA71sLLJIA1R1uQqiGZECE8jBypV4Qi2oQH9Y3Uf+m1KJlkI/bCfpeajAqM K68hdZuphuR28w3gHG1nFe6WEnZOUD+cC75kabNXhcKNgCPxVrE4zgQIbmpEDAJiPhyi8J Qd5CZp75+hm9GrajaLXjGMrdS3HPBWc74AnrCPohXcekD9LxQ0dZaXc8BPi/mr2UchSXus JpPKu/XE1YZrJyNLZMUC1iZrHYpQaDr9hiuTE9zL//v5gvW4jU8WE77Th9fYIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Be9f+g/R"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Be9f+g/R"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ED63732CA7 X-Spam-Score: -1.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: aPEfQBIy9wN1 Hi, Am Samstag, den 20.11.2021, 00:46 +0000 schrieb Jaft: > > On Friday, November 19, 2021, 01:55:44 PM CST, Liliana Marie > > Prikler wrote: > > [...] > > Guile is not racket, it's round brackets everywhere. > > Guile doesn't allow square brackets, like Racket does? I don't think > I've ever found that to be the case. I know at least some of the RnRS > standards don't allow it but I didn't think Guile was a strict > adherent. Not that I'm pushing back since, clearly, it falls outside > the style guide for Guix but it's the first I've heard that Guile > requires parentheses everywhere. Guile does allow you to write in that style and accepts it in the wild, but it's not a typical Guile coding style. Round brackets are much preferred. > [...] > > > > + (home-page "https://dmedvinsky.github.io/gsimplecal/") > > > + (synopsis "Lightweight calendar applet written in C++ > > > using GTK") > > > + (description "Gsimplecal was intentionally made for use > > > with > > > tint2 panel > > > +in the openbox environment to be launched upon clock click but, > > > of > > > course, it > > > +will work without it.") > > That's... not very descriptive, is it? > > I was using the description provided by the author on their GitHub > site; should I come up with my own description, in my own words, > instead? The synopsis already pretty much covers what it is (a > calendar applet so a calendar pops up when activated; a GTK simple > calendar) so I figured that, combined, they gave a good snapshot of > what it is and what it's aiming for. > > But I can definitely alter it to something else if that isn't > sufficient; just double checking so let me know and I shall do that. The description should not rely on the synopsis to do the explanation. You can filter Guix' output so that only one or the other appears, so both ought to make sense on their own. On that note, mentioning C++ and GTK in the synopsis might be a little overkill for a package with a description that is about as large, but fair enough. What about the following: "gsimplecal is a lightweight calendar application written in C++ using GTK. Launched once, it pops up a small calendar applet, launched again it closes the running instance. It can additionally be configured to show the current time in different timezones."? > Sure thing! I've attached what I have, so far, for the updated patch, > below, and I'll update it again if the description needs tweaking. > > > > * gnu/packages/calendar.scm (gsimplecal): New variable > --- Again a reminder to put comments after this little dashed line if you want to do inline comments. We have to filter the large verbage from the commit message otherwise. > gnu/packages/calendar.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > > diff --git a/gnu/packages/calendar.scm b/gnu/packages/calendar.scm > index 8ec36d4fa2..3c61a109a3 100644 > --- a/gnu/packages/calendar.scm > +++ b/gnu/packages/calendar.scm > @@ -10,6 +10,7 @@ > ;;; Copyright © 2020 Brendan Tildesley > ;;; Copyright © 2020 Tanguy Le Carrour > ;;; Copyright © 2020 Peng Mei Yu > +;;; Copyright © 2021 Wamm K. D. > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -36,6 +37,7 @@ (define-module (gnu packages calendar) > #:use-module (guix build-system cmake) > #:use-module (guix build-system python) > #:use-module (gnu packages admin) > + #:use-module (gnu packages autotools) > #:use-module (gnu packages base) > #:use-module (gnu packages check) > #:use-module (gnu packages dav) > @@ -405,3 +407,32 @@ (define-public ccal > ;; COPYING.LESSER specifies LGPL 3.0, but all source files say > ;; 'Lesser GPL version 2 or later'. > (license (list license:gpl2+ license:lgpl2.1+)))) > + > +(define-public gsimplecal > + (let ((commit "f00b80d86300397b52c3cf7d8dfc8de5cdee921d") > + (revision "1")) Revision counting typically starts at 0. On that note, this seems to be the release commit, so you can use (commit (string-append "v" version)) below with version simply being "2.2". > + (package > + (name "gsimplecal") > + (version (git-version "2.2" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url " > https://github.com/dmedvinsky/gsimplecal/") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 (string-append/shared > + "1qyf65l088dqsz25hm6s1cv18j" > + "52yaias0llqvpqwjfnvssa5cxg"))) > + (modules '((guix build utils))))) > + (build-system gnu-build-system) > + (native-inputs > + `(("autoconf" ,autoconf) > + ("automake" ,automake) > + ("pkg-config" ,pkg-config))) > + (inputs `(("gtk+" ,gtk+))) Inputs are typically ordered before native-inputs. > + (home-page "https://dmedvinsky.github.io/gsimplecal/") > + (synopsis "Lightweight calendar applet written in C++ using > GTK") > + (description "Gsimplecal was intentionally made for use with > tint2 panel > +in the openbox environment to be launched upon clock click but, of > course, it > +will work without it.") > + (license license:bsd-3)))) Cheers