[bug#47460] [PATCH] gnu: Add python-plumbum.

[bug#47460] [PATCH] gnu: Add python-plumbum.

[jgart via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Hi Guix!

Here is a patch for python-plumbum.

This was an effort of the today's Guix Packaging Meetup.

best regards,

jgart

libremiami.org

[-- Attachment #2: 0001-gnu-Add-python-plumbum.patch --]
[-- Type: application/octet-stream, Size: 1810 bytes --]

From 71f55eb299da49c7cfc71c5ad737a134f3fa3cc8 Mon Sep 17 00:00:00 2001
From: LibreMiami <packaging-guix@libremiami.org>
Date: Sun, 28 Mar 2021 21:06:10 -0400
Subject: [PATCH 1/2] gnu: Add python-plumbum.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/python-xyz.scm (python-plumbum): New variable.

Co-authored-by: Léo Le Bouter <lle-bout@zaclys.net>
Co-authored-by: jgart <jgart@dismail.de>
Co-authored-by: Ryan Prior <rprior@protonmail.com>
Co-authored-by: Andrea Pierré <a.pierre@zaclys.net>
---
 gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9f57992fdd..c3da1de994 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -24239,3 +24239,27 @@ number of words, syllables, and sentences.")
      "This package provides a Python library that can parse OPML, FOAF, and
 iGoogle subscription lists.")
     (license license:expat)))
+
+(define-public python-plumbum
+  (package
+    (name "python-plumbum")
+    (version "1.7.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "plumbum" version))
+        (sha256
+          (base32
+            "1kidj821k79dw064rlxh84xamb9h79ychg3pgj81jlvm5hs48xri"))))
+    (build-system python-build-system)
+    (native-inputs
+     ;; not actually used since there are no tests
+     ;; but required for build
+     `(("python-pytest" ,python-pytest)))
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://plumbum.readthedocs.io")
+    (synopsis "Python shell combinators library")
+    (description "Plumbum is a library of tools for replacing shell scripts
+with Python code.")
+    (license license:expat)))
-- 
2.31.1

[bug#47460] [PATCH] gnu: Add python-plumbum.

[Nicolas Goaziou]

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/python-xyz.scm (python-plumbum): New variable.

Applied. Thank you.

The patch didn't apply cleanly because the package definition was at the
end of the file. I moved it elsewhere.

Regards,
-- 
Nicolas Goaziou

[bug#47460] [PATCH] gnu: Add python-plumbum.

[jgart via Guix-patches via]

Hi Nicolas, thank you for merging the patch! It is much appreciated. 

Should we not add packages at the end of files going forward? How do you recommend avoiding that in the future?
I'd like to relay the tip to the group.

Also, I noticed that you forgot to add the co-authors listed
in the patch commit message:

Co-authored-by:·Léo·Le·Bouter·<lle-bout@zaclys.net>
Co-authored-by:·jgart·<jgart@dismail.de>
Co-authored-by:·Ryan·Prior·<rprior@protonmail.com>
Co-authored-by:·Andrea·Pierré·<a.pierre@zaclys.net>

If it is too much hassle to add it at this point then don't worry but it would be much appreciated,
otherwise.

all the best,

jgart

libremiami.org

[bug#47460] [PATCH] gnu: Add python-plumbum.

[Nicolas Goaziou]

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> Should we not add packages at the end of files going forward? How do
> you recommend avoiding that in the future?

You can try adding them alphabetically, by topic, or even randomly
within the file. Anything but the end of the file is fine, actually,
unless your package is named "python-zzz".

> Also, I noticed that you forgot to add the co-authors listed
> in the patch commit message:
>
> Co-authored-by:·Léo·Le·Bouter·<lle-bout@zaclys.net>
> Co-authored-by:·jgart·<jgart@dismail.de>
> Co-authored-by:·Ryan·Prior·<rprior@protonmail.com>
> Co-authored-by:·Andrea·Pierré·<a.pierre@zaclys.net>
>
> If it is too much hassle to add it at this point then don't worry but it would be much appreciated,
> otherwise.

I don't think I can change a commit message without rewriting history.
That's not an option. Sorry.

Regards,
-- 
Nicolas Goaziou