unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#74972] [PATCH] add font-monaspace package
@ 2024-12-19 13:46 Josep Bigorra
  2024-12-20 15:25 ` [bug#74972] [PATCH v2] gnu: fonts: Add font-monaspace Noé Lopez via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Josep Bigorra @ 2024-12-19 13:46 UTC (permalink / raw)
  To: 74972

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

Hi all,
I hereby submit a patch adding the beautiful Monaspace font families.
This works nicely in my Guix system so I want to upstream it. Hope I
didn't miss anything.

Regards,
Joe

[-- Attachment #2: 0001-add-font-monaspace-package.patch --]
[-- Type: text/x-patch, Size: 1939 bytes --]

From 030da8462240259aac4c46f398d7e2b4e9db9aa0 Mon Sep 17 00:00:00 2001
Message-ID: <030da8462240259aac4c46f398d7e2b4e9db9aa0.1734615915.git.jjbigorra@gmail.com>
From: Josep Bigorra <jjbigorra@gmail.com>
Date: Thu, 19 Dec 2024 14:44:46 +0100
Subject: [PATCH] add font-monaspace package

---
 gnu/packages/fonts.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 69d7d03..d7afe14 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2023 chris <chris@bumblehead.com>
 ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <sirgazil@zoho.com>
 ;;; Copyright © 2024 Christina O'Donnell <cdo@mutix.org>
+;;; Copyright © 2024 Josep Bigorra <jjbigorra@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3893,3 +3894,23 @@ (define-public font-dina
 It is relatively compact to allow a lot of code on screen, while (hopefully) clear
 enough to remain readable even at high resolutions.")
     (license license:expat)))
+
+(define-public font-monaspace
+  (package
+    (name "font-monaspace")
+    (version "1.101")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        "https://github.com/githubnext/monaspace/archive/refs/tags/v1.101.tar.gz")
+       (sha256
+        (base32 "076gx85and4xb262y0rbqvy7f6w732krzlh236xr7v3zbsw1h872"))))
+    (build-system font-build-system)
+    (home-page "https://monaspace.githubnext.com")
+    (synopsis "An innovative superfamily of fonts for code")
+    (description
+     "The Monaspace type system is a monospaced type superfamily with some modern tricks up its sleeve.
+     It consists of five variable axis typefaces. Each one has a distinct voice, but they are all metrics-compatible with one another,
+     allowing you to mix and match them for a more expressive typographical palette.")
+    (license license:silofl1.1)))
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#74972] [PATCH v2] gnu: fonts: Add font-monaspace.
  2024-12-19 13:46 [bug#74972] [PATCH] add font-monaspace package Josep Bigorra
@ 2024-12-20 15:25 ` Noé Lopez via Guix-patches via
  2024-12-20 15:31 ` [bug#74972] [PATCH] add font-monaspace package Noé Lopez via Guix-patches via
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-12-20 15:25 UTC (permalink / raw)
  To: 74972; +Cc: Noé Lopez, Zhu Zihao, 宋文武

From: Josep Bigorra <jjbigorra@gmail.com>

* gnu/packages/fonts.scm (font-monaspace): New variable.

Change-Id: I25559696f792a8dbf4961dfba2be906fb6d5f0c0
---
 gnu/packages/fonts.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 69d7d039aa..b36a46ebb3 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -60,6 +60,7 @@
 ;;; Copyright © 2023 chris <chris@bumblehead.com>
 ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <sirgazil@zoho.com>
 ;;; Copyright © 2024 Christina O'Donnell <cdo@mutix.org>
+;;; Copyright © 2024 Josep Bigorra <jjbigorra@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3893,3 +3894,27 @@ (define-public font-dina
 It is relatively compact to allow a lot of code on screen, while (hopefully) clear
 enough to remain readable even at high resolutions.")
     (license license:expat)))
+
+(define-public font-monaspace
+  (package
+    (name "font-monaspace")
+    (version "1.101")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/githubnext/monaspace")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "00bpzzpwz5m20ap0c1gy0rf99pc76g8lk6jr0wh7xs8fjazq7lf1"))))
+    (build-system font-build-system)
+    (home-page "https://monaspace.githubnext.com")
+    (synopsis "Innovative superfamily of fonts for code")
+    (description
+     "The Monaspace type system is a monospaced type superfamily with some modern
+tricks up its sleeve.  It consists of five variable axis typefaces.  Each one has a
+distinct voice, but they are all metrics-compatible with one another, allowing you to
+mix and match them for a more expressive typographical palette.")
+    (license license:silofl1.1)))

base-commit: 5e82c33839b1c02a3db8ef22f7b52e10d97a2f78
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#74972] [PATCH] add font-monaspace package
  2024-12-19 13:46 [bug#74972] [PATCH] add font-monaspace package Josep Bigorra
  2024-12-20 15:25 ` [bug#74972] [PATCH v2] gnu: fonts: Add font-monaspace Noé Lopez via Guix-patches via
@ 2024-12-20 15:31 ` Noé Lopez via Guix-patches via
  2024-12-20 15:34 ` [bug#74972] Control message for 74972 Noé Lopez via Guix-patches via
  2024-12-20 17:24 ` [bug#74972] Josep Bigorra
  3 siblings, 0 replies; 5+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-12-20 15:31 UTC (permalink / raw)
  To: 74972; +Cc: Josep Bigorra

Hi,

Thank you for your patch, there are a few issues with it that are
reported by guix lint: it is better to use a git origin instead of an
archive, your synopsys starts with an article (”an”) and sentences in
the description are not separated with two spaces.  It is also missing a
commit messages.

These are only small changes, the rest of the patch works well :) I have
sent a second version to fix the issues listed.

Have a good day,
Noé Lopez

> Hi all,
> I hereby submit a patch adding the beautiful Monaspace font families.
> This works nicely in my Guix system so I want to upstream it. Hope I
> didn't miss anything.
> 
> Regards,
> Joe
> From 030da8462240259aac4c46f398d7e2b4e9db9aa0 Mon Sep 17 00:00:00 2001
> Message-ID: <030da8462240259aac4c46f398d7e2b4e9db9aa0.1734615915.git.jjbigorra@gmail.com>
> From: Josep Bigorra <jjbigorra@gmail.com>
> Date: Thu, 19 Dec 2024 14:44:46 +0100
> Subject: [PATCH] add font-monaspace package
> 
> ---
>  gnu/packages/fonts.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 69d7d03..d7afe14 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -60,6 +60,7 @@
>  ;;; Copyright © 2023 chris <chris@bumblehead.com>
>  ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <sirgazil@zoho.com>
>  ;;; Copyright © 2024 Christina O'Donnell <cdo@mutix.org>
> +;;; Copyright © 2024 Josep Bigorra <jjbigorra@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3893,3 +3894,23 @@ (define-public font-dina
>  It is relatively compact to allow a lot of code on screen, while (hopefully) clear
>  enough to remain readable even at high resolutions.")
>      (license license:expat)))
> +
> +(define-public font-monaspace
> +  (package
> +    (name "font-monaspace")
> +    (version "1.101")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        "https://github.com/githubnext/monaspace/archive/refs/tags/v1.101.tar.gz")
> +       (sha256
> +        (base32 "076gx85and4xb262y0rbqvy7f6w732krzlh236xr7v3zbsw1h872"))))
> +    (build-system font-build-system)
> +    (home-page "https://monaspace.githubnext.com")
> +    (synopsis "An innovative superfamily of fonts for code")
> +    (description
> +     "The Monaspace type system is a monospaced type superfamily with some modern tricks up its sleeve.
> +     It consists of five variable axis typefaces. Each one has a distinct voice, but they are all metrics-compatible with one another,
> +     allowing you to mix and match them for a more expressive typographical palette.")
> +    (license license:silofl1.1)))
> -- 
> 2.46.0




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74972] Control message for 74972
  2024-12-19 13:46 [bug#74972] [PATCH] add font-monaspace package Josep Bigorra
  2024-12-20 15:25 ` [bug#74972] [PATCH v2] gnu: fonts: Add font-monaspace Noé Lopez via Guix-patches via
  2024-12-20 15:31 ` [bug#74972] [PATCH] add font-monaspace package Noé Lopez via Guix-patches via
@ 2024-12-20 15:34 ` Noé Lopez via Guix-patches via
  2024-12-20 17:24 ` [bug#74972] Josep Bigorra
  3 siblings, 0 replies; 5+ messages in thread
From: Noé Lopez via Guix-patches via @ 2024-12-20 15:34 UTC (permalink / raw)
  To: control, 74972

user guix
tags 74972 + reviewed-looks-good
thanks




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74972]
  2024-12-19 13:46 [bug#74972] [PATCH] add font-monaspace package Josep Bigorra
                   ` (2 preceding siblings ...)
  2024-12-20 15:34 ` [bug#74972] Control message for 74972 Noé Lopez via Guix-patches via
@ 2024-12-20 17:24 ` Josep Bigorra
  3 siblings, 0 replies; 5+ messages in thread
From: Josep Bigorra @ 2024-12-20 17:24 UTC (permalink / raw)
  To: 74972

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

Thanks a lot for your work Noé LGTM

[-- Attachment #2: Type: text/html, Size: 60 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-12-20 18:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-19 13:46 [bug#74972] [PATCH] add font-monaspace package Josep Bigorra
2024-12-20 15:25 ` [bug#74972] [PATCH v2] gnu: fonts: Add font-monaspace Noé Lopez via Guix-patches via
2024-12-20 15:31 ` [bug#74972] [PATCH] add font-monaspace package Noé Lopez via Guix-patches via
2024-12-20 15:34 ` [bug#74972] Control message for 74972 Noé Lopez via Guix-patches via
2024-12-20 17:24 ` [bug#74972] Josep Bigorra

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).