From: Brian Cully via Guix-patches via <guix-patches@gnu.org>
To: Hilton Chain <hako@ultrarare.space>
Cc: 63863@debbugs.gnu.org
Subject: [bug#63863] [PATCH v5 1/1] gnu: home: Add support for home-pipewire-service
Date: Sat, 16 Dec 2023 10:17:21 -0500 [thread overview]
Message-ID: <9E63989C-2927-45B5-B1BF-5C5E8FF1D5C1@spork.org> (raw)
In-Reply-To: <13252a733171e18f4d39d0185ddf3e8e3c06bc15.1685747062.git.bjc@spork.org>
Hilton Chain <hako@ultrarare.space> writes:
> I'd prefer the following:
>
> (define (home-pipewire-asoundrc config)
> (match-record config <home-pipewire-configuration>
> (pipewire)
> (mixed-text-file
> "asoundrc"
> "<" pipewire "/share/alsa/alsa.conf.d/50-pipewire.conf>\n"
> "<" pipewire "/share/alsa/alsa.conf.d/99-pipewire-default.conf>\n"
> "pcm_type.pipewire {\n"
> " lib \"" pipewire "/lib/alsa-lib/libasound_module_pcm_pipewire.so\"\n"
> "}\n"
> "ctl_type.pipewire {\n"
> " lib \"" pipewire "/lib/alsa-lib/libasound_module_ctl_pipewire.so\"\n"
> "}\n")))
>
>
> or:
>
> (define (home-pipewire-asoundrc config)
> (match-record config <home-pipewire-configuration>
> (pipewire)
> (mixed-text-file
> "asoundrc"
> #~(begin
> (use-modules (ice-9 format))
> (format #f "~
> <~a/share/alsa/alsa.conf.d/50-pipewire.conf>
> <~@*~a/share/alsa/alsa.conf.d/99-pipewire-default.conf>
> pcm_type.pipewire {
> lib \"~@*~a/lib/alsa-lib/libasound_module_pcm_pipewire.so\"
> }
> ctl_type.pipewire {
> lib \"~@*~a/lib/alsa-lib/libasound_module_ctl_pipewire.so\"
> }~%" #$pipewire)))))
I prefer the former to the latter; I often find ‘format’ strings to be pretty confusing, and the documentation doesn't tend to help much. I know I'm not alone in this, and since this is fairly simple, I'll use the straight concatenation, which has the additional benefit of preserving indentation.
> One thing to note: the wireplumber package is built with elogind integration, so
> it fails to start when elogind is not present:
>
> [wireplumber] failed to start systemd logind monitor: -2 (No such file or directory)
>
> I think we can add a wireplumber variant built with "-Delogind=disabled" and
> maybe mention it in the documentation.
Sounds reasonable. I don't know how long wireplumber has been able to be built without systemd stuff, just that I tried running it with seatd/greetd and it failed. Have you got it working without elogind?
I'm not sure when I'll be able to have a look at it, so I'd rather the current patch go in, and we can add elogind-less variants afterwards.
--
-bjc
next prev parent reply other threads:[~2023-12-16 15:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 23:04 [bug#63863] [PATCH] gnu: home: Add support for home-pipewire-service Brian Cully via Guix-patches via
2023-06-09 20:22 ` Ludovic Courtès
2023-06-12 5:50 ` Andrew Tropin
2023-06-12 15:56 ` Brian Cully via Guix-patches via
2023-06-13 4:39 ` Andrew Tropin
2023-06-13 12:20 ` Brian Cully via Guix-patches via
2023-06-14 9:08 ` Andrew Tropin
2023-06-15 13:16 ` [bug#63863] [PATCH v2] " Brian Cully via Guix-patches via
2023-06-15 13:19 ` Brian Cully via Guix-patches via
2023-06-15 13:26 ` [bug#63863] [PATCH v3] " Brian Cully via Guix-patches via
2023-06-15 13:27 ` Brian Cully via Guix-patches via
2023-06-20 12:41 ` [bug#63863] [PATCH v4 0/1] " Brian Cully via Guix-patches via
2023-06-20 12:41 ` [bug#63863] [PATCH v4 1/1] " Brian Cully via Guix-patches via
2023-07-02 12:39 ` [bug#63863] [PATCH v5 0/1] " Brian Cully via Guix-patches via
2023-07-02 12:39 ` [bug#63863] [PATCH v5 1/1] " Brian Cully via Guix-patches via
2023-11-12 14:14 ` Hilton Chain via Guix-patches via
2023-08-23 8:25 ` Tanguy LE CARROUR
2023-08-23 18:44 ` brian via Guix-patches via
2023-08-25 6:44 ` Tanguy LE CARROUR
2023-10-11 11:34 ` taosabella
2023-11-05 15:09 ` [bug#63863] (no subject) Jakob Honal
2023-12-16 15:17 ` Brian Cully via Guix-patches via [this message]
2023-12-16 15:23 ` [bug#63863] [PATCH v6] gnu: home: Add support for home-pipewire-service Brian Cully via Guix-patches via
2023-12-20 8:46 ` bug#63863: " Oleg Pykhalov
2023-12-22 15:22 ` [bug#63863] [PATCH v7] " Brian Cully via Guix-patches via
[not found] ` <handler.63863.D63863.17030619999937.notifdone@debbugs.gnu.org>
2023-12-22 15:22 ` [bug#63863] closed (Re: [bug#63863] [PATCH v6] gnu: home: Add support for home-pipewire-service) Brian Cully via Guix-patches via
2023-12-26 12:57 ` bug#63863: " Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9E63989C-2927-45B5-B1BF-5C5E8FF1D5C1@spork.org \
--to=guix-patches@gnu.org \
--cc=63863@debbugs.gnu.org \
--cc=bjc@spork.org \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).