From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uGqrDsVO1l/YawAA0tVLHw (envelope-from ) for ; Sun, 13 Dec 2020 17:26:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qGp+CsVO1l8yPAAAB5/wlQ (envelope-from ) for ; Sun, 13 Dec 2020 17:26:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E00E89403CB for ; Sun, 13 Dec 2020 17:26:28 +0000 (UTC) Received: from localhost ([::1]:57144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koV8d-00060Z-Ns for larch@yhetil.org; Sun, 13 Dec 2020 12:26:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koV8F-0005yr-0V for guix-patches@gnu.org; Sun, 13 Dec 2020 12:26:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koV8E-0001PY-PM for guix-patches@gnu.org; Sun, 13 Dec 2020 12:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koV8E-0001Y1-MQ for guix-patches@gnu.org; Sun, 13 Dec 2020 12:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#41066] [PATCH] gnu: bootloader: Improve support for chain loading. Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Dec 2020 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41066 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Received: via spool by 41066-submit@debbugs.gnu.org id=B41066.16078803035831 (code B ref 41066); Sun, 13 Dec 2020 17:26:02 +0000 Received: (at 41066) by debbugs.gnu.org; 13 Dec 2020 17:25:03 +0000 Received: from localhost ([127.0.0.1]:50013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koV7H-0001Vw-3k for submit@debbugs.gnu.org; Sun, 13 Dec 2020 12:25:03 -0500 Received: from smtpout2.vodafonemail.de ([145.253.239.133]:43984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koV7F-0001V1-Ft for 41066@debbugs.gnu.org; Sun, 13 Dec 2020 12:25:02 -0500 Received: from smtp.vodafone.de (unknown [10.2.0.35]) by smtpout2.vodafonemail.de (Postfix) with ESMTP id 163601270FC; Sun, 13 Dec 2020 18:24:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-smtpout-mb-15sep; t=1607880295; bh=5u8kiCFDlJN3TCecHOSZJE7PXvb1FqJNQttYxTuurLQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=itgGUrTa4AuJtQ5UGHypUOSTcPmBH43pmA1KL8wMYShcEoBHzoGAHfruIXbVGs12I pBta+NGO+Yi18/366pfnpwypatkOu9Oey4gAyGPgcPTP1WEEM2zux3mlyLK9F118wj 7p+ep4bJaGbSURIarOVkyy3+vpzp/PzhzWpwqBKM= Received: from macbook-pro.kuh-wiese.my-router.de (dslb-002-202-077-025.002.202.pools.vodafone-ip.de [2.202.77.25]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id D541D1420C3; Sun, 13 Dec 2020 17:24:54 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Stefan In-Reply-To: <20201213154149.47423b18@scratchpost.org> Date: Sun, 13 Dec 2020 18:24:53 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <9A42CB53-1D8B-406C-B046-46883BC9962F@vodafonemail.de> References: <7A4ABEA8-4500-4D55-BCCE-BFB37FB06B2C@vodafonemail.de> <20200524131316.4c6e8a50@scratchpost.org> <3197004D-0131-4781-99FD-60EBE434E794@vodafonemail.de> <023CBBED-35CD-4AD3-97C4-0DE0B7623B9A@vodafonemail.de> <6E5ECFBA-57F4-485F-9403-1D04CF82062D@vodafonemail.de> <4D71A75A-5722-457C-A5CE-98CE51A53450@vodafonemail.de> <975EC414-6A81-444B-9BB0-AE303C6A9511@vodafonemail.de> <20201116103346.55ff8422@scratchpost.org> <20201117164755.1a27422b@scratchpost.org> <20201118190559.1f9fed82@scratchpost.org> <10AB4620-ECD3-4199-A9E4-CE0F906AC3BE@vodafonemail.de> <98EF392F-E84E-4CEB-8166-C28D16552057@vodafonemail.de> <7FDE10B2-EA52-4598-AE22-25181DE76A86@vodafonemail.de> <20201213154149.47423b18@scratchpost.org> X-Mailer: Apple Mail (2.3124) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1726 X-purgate-ID: 155817::1607880294-000006C0-B2302219/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41066@debbugs.gnu.org, Mathieu Othacehe Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.80 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=vodafonemail.de header.s=vfde-smtpout-mb-15sep header.b=itgGUrTa; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E00E89403CB X-Spam-Score: -0.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: EmxQgoibW/8x Hi Danny! > (1) Export chain-bootloader-installer. I totally agree with Ludo's = earlier > comment in that this is not the right abstraction for GENERAL = bootloader > chaining (which would be a LOT more difficult/impossible to do). > I'm not sure whether "efi-bootloader-chain-installer" would be better = (use > whatever you think is best)--in any case, please do not make it seem = like > this function is in any way generic, which it is absolutely not. Done, I chose chain-efi-bootloader-installer. > (2) efi-bootloader-profile cosmetic comment and import cleanup. Also, = some > more cosmetic comment cleanup in some other procedure. Please use = extra > patch(es). Undone. > (3) Definition of procedure chain-bootloader-installer. This = procedure does > not fail if the conditions are weird (collection is not a directory, > bootloader-target is not a directory). If there is no good reason for = that, > please use (error "...") to make it fail instead of silently = continuing. > If there are good reasons, nevermind. Done. > Since this is merely moving the existing procedure, please, if you do > these changes I suggest, do those in an extra commit (so the moving = commit > is clearing only moving the procedure, not changing it). No, it=E2=80=99s not strictly moving. Its pulling functionality out of = efi-bootloader-chain into the new function = chain-efi-bootloader-installer, which I put on top. Putting it below = doesn=E2=80=99t make the diff prettier. > (4) gnu/bootloader/grub.scm font installer doesn't use symlinks = anymore. > Fine, but maybe also make an extra patch for that. Please use your = judgement. Done. Bye Stefan