From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35403)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZGdj-0002LO-Sh
 for guix-patches@gnu.org; Mon, 25 Nov 2019 10:51:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZGdi-0002kP-NA
 for guix-patches@gnu.org; Mon, 25 Nov 2019 10:51:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:43607)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iZGdi-0002kH-Hw
 for guix-patches@gnu.org; Mon, 25 Nov 2019 10:51:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZGdi-00022Z-GH
 for guix-patches@gnu.org; Mon, 25 Nov 2019 10:51:02 -0500
Subject: bug#38286: [PATCH] gnu: Add netcat-openbsd.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.38286.D38286.15746970487811.done@debbugs.gnu.org>
Mime-Version: 1.0
Message-Id: <9911a65e-701c-45fc-96db-d70162e6bda2@www.fastmail.com>
In-Reply-To: <87lfs5zgc7.fsf@gnu.org>
References: <3dfac477-b081-49f4-86b3-2c142bb39f6b@www.fastmail.com>
 <87blt5k336.fsf@gnu.org> <20191121101755.GD15074@E5400>
 <550ee09b-7126-4acd-87ab-4e3a77cb346c@www.fastmail.com>
 <8e0a1df0-2df6-4efe-b8e5-02cf468ab8d9@www.fastmail.com>
 <cd5ab7d8-685c-48b7-be48-4545f4876528@www.fastmail.com>
 <87lfs5zgc7.fsf@gnu.org>
Date: Mon, 25 Nov 2019 15:50:19 +0000
From: "Alex Griffin" <a@ajgrf.com>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 38286-done@debbugs.gnu.org
Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>, Efraim Flashner <efraim@flashner.co.il>

Pushed as 377606238f0260a849a1f529d94e1546276a5db6.
--=20
Alex Griffin

On Sun, Nov 24, 2019, at 11:03 AM, Ludovic Court=C3=A8s wrote:
> Hello!
>=20
> "Alex Griffin" <a@ajgrf.com> skribis:
>=20
> > From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 20=
01
> > From: Alex Griffin <a@ajgrf.com>
> > Date: Tue, 19 Nov 2019 19:59:32 -0600
> > Subject: [PATCH] gnu: Add netcat-openbsd.
> >
> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
>=20
> Overall LGTM; I like that we=E2=80=99re not taking responsibility for =
all these
> patches.  :-)
>=20
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://salsa.debian.org/debian/netcat-op=
enbsd.git")
> > +                    (commit (string-append "debian/" version))))
> > +              (sha256
> > +               (base32
> > +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk=
3m"))))
>=20
> I suspect =E2=80=98guix lint=E2=80=99 suggests a =E2=80=98file-name=E2=
=80=99 field here.  :-)
>=20
> > +    (home-page "https://packages.debian.org/sid/netcat-openbsd")
> > +    (synopsis "TCP/IP swiss army knife")
>=20
> Could you make that more factual, like =E2=80=9CRead and write data ov=
er TCP/IP=E2=80=9D
> (same as for =E2=80=98netcat=E2=80=99 actually)?
>=20
> > +    (description
> > +     "A simple Unix utility which reads and writes data across netw=
ork
>          ^
> Please write full sentences.
>=20
> OK to push with changes along these lines!
>=20
> Thanks,
> Ludo=E2=80=99.
>