unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: calum <calumirwin1@gmail.com>, 47465@debbugs.gnu.org
Subject: [bug#47465] [PATCH] Added wlrctl to xdisorg
Date: Mon, 29 Mar 2021 15:50:31 +0200	[thread overview]
Message-ID: <97eef11b9cbaeea1035fb05a2e8925c8350c085b.camel@telenet.be> (raw)
In-Reply-To: <20210329105622.5812-1-calumirwin1@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2651 bytes --]

Hi,

On Mon, 2021-03-29 at 23:56 +1300, calum wrote:
> ---
>  gnu/packages/xdisorg.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)

Please include a commit message.  There are plenty of examples
in the git history to base you on.  Also see section
16.6 ‘Submitting Patches’ of the manual.

> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index 56ac53edec..6d936efee6 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -80,6 +80,7 @@

You should add a copyright line.

>    #:use-module (gnu packages base)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages check)
> +  #:use-module (gnu packages cmake)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages documentation)
>    #:use-module (gnu packages flex)
> @@ -2788,3 +2789,33 @@ and execute @file{.desktop} files of the Application type.")
>       "The @command{hsetroot} command composes wallpapers for X.
>  This package is the fork of hsetroot by Hyriand.")
>      (license license:gpl2+)))
> +
> +(define-public wlrctl
> +  (package
> +    (name "wlrctl")
> +    (version "0.2.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://git.sr.ht/~brocellous/wlrctl")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("cmake" ,cmake)
> +       ("scdoc" ,scdoc)))
> +    (inputs
> +     `(("libxkbcommon" ,libxkbcommon)
> +       ("wayland" ,wayland)))

If this is a wayland package, shouldn't this be in (gnu packages freedesktop)?
I'm not sure myself where it should be, but at least that's were the 'wayland'
package resides.

> +    (home-page "https://git.sr.ht/~brocellous/wlrctl")
> +    (synopsis "Command line utility for wlroots automation and extensions")
> +    (description
> +     "wlrctl is a command line utility for miscellaneous wlroots Wayland
> +extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
> +(window/toplevel command), virtual-keyboard (keyboard command),
> +and virtual-pointer (pointer command) protocols.")
> +    (license license:expat)))

The package definition seems about right to me, but I don't have time to
actually test this.

Greetings,
Maxime.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2021-03-29 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 10:56 [bug#47465] [PATCH] Added wlrctl to xdisorg calum
2021-03-29 13:50 ` Maxime Devos [this message]
2021-03-30 10:32   ` Calum Irwin
2021-04-04 17:49     ` Leo Famulari
2021-03-30 10:29 ` [bug#47465] [PATCH v2] gnu: Add wlrctl calum
2021-06-27  4:26 ` [bug#47465] [PATCH] " calum
2021-06-27  4:30 ` [bug#47465] [PATCH] Added wlrctl to xdisorg Calum Irwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97eef11b9cbaeea1035fb05a2e8925c8350c085b.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=47465@debbugs.gnu.org \
    --cc=calumirwin1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).