[bug#53973] [PATCH] gnome-shell-extension-gsconnect: Update to 48

[bug#53973] [PATCH] gnome-shell-extension-gsconnect: Update to 48

[Justin Veilleux]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

This is an update to the gsconnect extension. The last version was not 
compatible with new GNOME.

I've disabled the new tests, because I do not know how to make them work.

Cheers.

[-- Attachment #2: 0001-gnu-gnome-shell-extension-gsconnect-Update-to-48.patch --]
[-- Type: text/x-patch, Size: 2549 bytes --]

From dc3ea56474ca71a34168047389617aa418a5207d Mon Sep 17 00:00:00 2001
From: terramorpha <terramorpha@cock.li>
Date: Sun, 13 Feb 2022 11:15:55 -0500
Subject: [PATCH] gnu: gnome-shell-extension-gsconnect: Update to 48

* gnu/packages/gnome-xyz (gnome-shell-extension-gsconnect): Update to 48
---
 gnu/packages/gnome-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 7f67f12672..49245b53f8 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2021 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Songlin Jiang <hollowman@hollowman.ml>
-;;; Copyright © 2021 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2021, 2022 Justin Veilleux <terramorpha@cock.li>
 ;;; Copyright © 2021 Attila Lendvai <attila@lendvai.name>
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson@protonmail.com>
 ;;;
@@ -403,8 +403,7 @@ (define-public gnome-shell-extension-dash-to-dock
 (define-public gnome-shell-extension-gsconnect
   (package
     (name "gnome-shell-extension-gsconnect")
-    ;; v33 is the last version to support GNOME 3.34
-    (version "33")
+    (version "48")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -414,10 +413,11 @@ (define-public gnome-shell-extension-gsconnect
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1q03axhn75i864vgmd6myhmgwrmnpf01gsd1wl0di5x9q8mic2zn"))))
+                "15agblnm7k1wqnnz6gwhwym992fzqkdz8mkm04805783bx60b8bh"))))
     (build-system meson-build-system)
     (arguments
-     `(#:configure-flags
+     `(#:tests? #f
+       #:configure-flags
        (let* ((out (assoc-ref %outputs "out"))
               (name+version (strip-store-file-name out))
               (gschema-dir (string-append out
@@ -442,7 +442,7 @@ (define-public gnome-shell-extension-gsconnect
              (let* ((glib (assoc-ref inputs "glib:bin"))
                     (gapplication (string-append glib "/bin/gapplication"))
                     (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
-               (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop"
+               (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
                  (("gapplication") gapplication))
                (for-each
                 (lambda (file)
-- 
2.34.0

[bug#53973] [PATCH] gnome-shell-extension-gsconnect: Update to 48

[Liliana Marie Prikler]

Am Sonntag, dem 13.02.2022 um 12:05 -0500 schrieb Justin Veilleux:
> This is an update to the gsconnect extension. The last version was
> not  compatible with new GNOME.
> 
> I've disabled the new tests, because I do not know how to make them
> work.
Rather than disabling all tests, you should strive to only disable
those that fail.  If that's all of them, then you still have to explain
that in the comment of #:tests? #f.

Cheers

[bug#53973] [PATCH v2] gnome-shell-extension-gsconnect: Update to 48

[Justin Veilleux]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi, I added the necessary clarification: all tests do fail.

Cheers

On 2022-02-13 14:32, Liliana Marie Prikler wrote:
> Am Sonntag, dem 13.02.2022 um 12:05 -0500 schrieb Justin Veilleux:
>> This is an update to the gsconnect extension. The last version was
>> not  compatible with new GNOME.
>>
>> I've disabled the new tests, because I do not know how to make them
>> work.
> Rather than disabling all tests, you should strive to only disable
> those that fail.  If that's all of them, then you still have to explain
> that in the comment of #:tests? #f.
> 
> Cheers

[-- Attachment #2: 0001-gnu-gnome-shell-extension-gsconnect-Update-to-48.patch --]
[-- Type: text/x-patch, Size: 2569 bytes --]

From a687235fc6b679c27b846ada86b8063d00a2714e Mon Sep 17 00:00:00 2001
From: terramorpha <terramorpha@cock.li>
Date: Sun, 13 Feb 2022 11:15:55 -0500
Subject: [PATCH] gnu: gnome-shell-extension-gsconnect: Update to 48

* gnu/packages/gnome-xyz (gnome-shell-extension-gsconnect): Update to 48
---
 gnu/packages/gnome-xyz.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 7f67f12672..ed0d0ac4c7 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2021 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Songlin Jiang <hollowman@hollowman.ml>
-;;; Copyright © 2021 Justin Veilleux <terramorpha@cock.li>
+;;; Copyright © 2021, 2022 Justin Veilleux <terramorpha@cock.li>
 ;;; Copyright © 2021 Attila Lendvai <attila@lendvai.name>
 ;;; Copyright © 2021 Charles Jackson <charles.b.jackson@protonmail.com>
 ;;;
@@ -403,8 +403,7 @@ (define-public gnome-shell-extension-dash-to-dock
 (define-public gnome-shell-extension-gsconnect
   (package
     (name "gnome-shell-extension-gsconnect")
-    ;; v33 is the last version to support GNOME 3.34
-    (version "33")
+    (version "48")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -414,10 +413,11 @@ (define-public gnome-shell-extension-gsconnect
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1q03axhn75i864vgmd6myhmgwrmnpf01gsd1wl0di5x9q8mic2zn"))))
+                "15agblnm7k1wqnnz6gwhwym992fzqkdz8mkm04805783bx60b8bh"))))
     (build-system meson-build-system)
     (arguments
-     `(#:configure-flags
+     `(#:tests? #f ;; every test fails
+       #:configure-flags
        (let* ((out (assoc-ref %outputs "out"))
               (name+version (strip-store-file-name out))
               (gschema-dir (string-append out
@@ -442,7 +442,7 @@ (define-public gnome-shell-extension-gsconnect
              (let* ((glib (assoc-ref inputs "glib:bin"))
                     (gapplication (string-append glib "/bin/gapplication"))
                     (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
-               (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop"
+               (substitute* "data/org.gnome.Shell.Extensions.GSConnect.desktop.in"
                  (("gapplication") gapplication))
                (for-each
                 (lambda (file)
-- 
2.34.0

bug#53973: [PATCH] gnome-shell-extension-gsconnect: Update to 48

[Ludovic Courtès]

Hi,

Justin Veilleux <terramorpha@cock.li> skribis:

> From a687235fc6b679c27b846ada86b8063d00a2714e Mon Sep 17 00:00:00 2001
> From: terramorpha <terramorpha@cock.li>
> Date: Sun, 13 Feb 2022 11:15:55 -0500
> Subject: [PATCH] gnu: gnome-shell-extension-gsconnect: Update to 48
>
> * gnu/packages/gnome-xyz (gnome-shell-extension-gsconnect): Update to 48

Applied, thanks!

Ludo’.