unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#45598] [PATCH] Add nord-theme
@ 2021-01-01 14:20 Ellis Kenyo via Guix-patches via
  2021-01-02  2:59 ` Leo Famulari
  0 siblings, 1 reply; 6+ messages in thread
From: Ellis Kenyo via Guix-patches via @ 2021-01-01 14:20 UTC (permalink / raw)
  To: 45598; +Cc: Ellis Kenyo

---
 gnu/packages/gnome-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 2eb08da50f..8de59dac2e 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -649,3 +649,28 @@ language specification for the Language Server Protocol (LSP).  This tool is
 used in text editing environments to provide a complete and integrated
 feature-set for programming Vala effectively.")
     (license license:lgpl2.1+)))
+
+(define-public nord-theme
+  (let ((commit "07d764c5ebd5706e73d2e573f1a983e37b318915")
+	(revision "0"))
+  (package
+   (name "nord-theme")
+   (version (git-version "1.9.0" revision commit))
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+	   (url "https://github.com/EliverLara/Nordic")
+	   (commit commit)))
+     (sha256
+      (base32
+       "0y2s9d6h1b195s6afp1gb5rb1plfslkpbw2brd30a9d66wfvsqk0"))
+     (file-name (git-file-name name version))))
+   (build-system copy-build-system)
+   (arguments
+    `(#:install-plan
+      `(("." "share/themes/nord" #:exclude ("README.md" "LICENSE" "Art/" "package.json" "package-lock.json" "Gulpfile.js")))))
+   (home-page "https://github.com/EliverLara/Nordic")
+   (synopsis "Dark Gtk3.20+ theme created using the awesome Nord color pallete.")
+   (description "Nordic is a Gtk3.20+ theme created using the awesome Nord color pallete.")
+   (license license:gpl3))))
-- 
2.29.2





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#45598] [PATCH] Add nord-theme
  2021-01-01 14:20 [bug#45598] [PATCH] Add nord-theme Ellis Kenyo via Guix-patches via
@ 2021-01-02  2:59 ` Leo Famulari
  2021-01-02  5:38   ` Ellis Kenyő via Guix-patches via
  0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2021-01-02  2:59 UTC (permalink / raw)
  To: me, 45598

On Fri, Jan 01, 2021 at 02:20:14PM +0000, Ellis Kenyo via Guix-patches via wrote:
> +(define-public nord-theme

Thanks!

> +	   (url "https://github.com/EliverLara/Nordic")

Should it be called "nordic-theme" instead? That seems to be the name
they picked.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#45598] [PATCH] Add nord-theme
  2021-01-02  2:59 ` Leo Famulari
@ 2021-01-02  5:38   ` Ellis Kenyő via Guix-patches via
  2021-01-03 23:34     ` Leo Famulari
  0 siblings, 1 reply; 6+ messages in thread
From: Ellis Kenyő via Guix-patches via @ 2021-01-02  5:38 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 45598

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

The original theme it's based on is called "Nord" and that's the expectation from a user perspective, I'm not quite sure why they renamed it.

On 2 Jan 2021, 03:05, at 03:05, Leo Famulari <leo@famulari.name> wrote:
>On Fri, Jan 01, 2021 at 02:20:14PM +0000, Ellis Kenyo via Guix-patches
>via wrote:
>> +(define-public nord-theme
>
>Thanks!
>
>> +	   (url "https://github.com/EliverLara/Nordic")
>
>Should it be called "nordic-theme" instead? That seems to be the name
>they picked.

[-- Attachment #2: Type: text/html, Size: 1143 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#45598] [PATCH] Add nord-theme
  2021-01-02  5:38   ` Ellis Kenyő via Guix-patches via
@ 2021-01-03 23:34     ` Leo Famulari
  2021-01-04  2:02       ` Ellis Kenyő via Guix-patches via
  0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2021-01-03 23:34 UTC (permalink / raw)
  To: Ellis Kenyő; +Cc: 45598

On Sat, Jan 02, 2021 at 05:38:23AM +0000, Ellis Kenyő wrote:
> The original theme it's based on is called "Nord" and that's the expectation from a user perspective, I'm not quite sure why they renamed it.

Sorry to be a stickler but we usually use upstream names. We might make
exceptions if other distros rename it as well, or if there is some
widely used interface with the other name.

Is that the case? If so, we can call it nord-theme. Otherwise we'll use
nordic-theme.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#45598] [PATCH] Add nord-theme
  2021-01-03 23:34     ` Leo Famulari
@ 2021-01-04  2:02       ` Ellis Kenyő via Guix-patches via
  2021-01-04  2:40         ` bug#45598: " Leo Famulari
  0 siblings, 1 reply; 6+ messages in thread
From: Ellis Kenyő via Guix-patches via @ 2021-01-04  2:02 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 45598

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

I don't mind either way so I'm happy to have it merged as nordic! ☺️

On 3 Jan 2021, 23:40, at 23:40, Leo Famulari <leo@famulari.name> wrote:
>On Sat, Jan 02, 2021 at 05:38:23AM +0000, Ellis Kenyő wrote:
>> The original theme it's based on is called "Nord" and that's the
>expectation from a user perspective, I'm not quite sure why they
>renamed it.
>
>Sorry to be a stickler but we usually use upstream names. We might make
>exceptions if other distros rename it as well, or if there is some
>widely used interface with the other name.
>
>Is that the case? If so, we can call it nord-theme. Otherwise we'll use
>nordic-theme.

[-- Attachment #2: Type: text/html, Size: 1111 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#45598: [PATCH] Add nord-theme
  2021-01-04  2:02       ` Ellis Kenyő via Guix-patches via
@ 2021-01-04  2:40         ` Leo Famulari
  0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2021-01-04  2:40 UTC (permalink / raw)
  To: Ellis Kenyő; +Cc: 45598-done

On Mon, Jan 04, 2021 at 02:02:17AM +0000, Ellis Kenyő wrote:
> I don't mind either way so I'm happy to have it merged as nordic! ☺️

Okay! Pushed as fdfc1c81ba018dd808b0dfd9827a73262c716808 with the name
"nordic-theme.

Thanks!

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=fdfc1c81ba018dd808b0dfd9827a73262c716808




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-04  2:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-01 14:20 [bug#45598] [PATCH] Add nord-theme Ellis Kenyo via Guix-patches via
2021-01-02  2:59 ` Leo Famulari
2021-01-02  5:38   ` Ellis Kenyő via Guix-patches via
2021-01-03 23:34     ` Leo Famulari
2021-01-04  2:02       ` Ellis Kenyő via Guix-patches via
2021-01-04  2:40         ` bug#45598: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).