From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id UNCBOvZFPmbp0gAAe85BDQ:P1 (envelope-from ) for ; Fri, 10 May 2024 18:06:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id UNCBOvZFPmbp0gAAe85BDQ (envelope-from ) for ; Fri, 10 May 2024 18:06:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bJIqMyop; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715357174; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=d/VHyTaMnvZvSEpE+NALXx/6v4neQyXS2AXBq4XpVck=; b=ln4RNuFGwVY++PYAqkJkDOqQVoraAzl5vdPWp4Dp+AofB+qji1mX/J+YD6yXnV8PORGAUP Z88OxhcPy+fj+Tu4EsDNQ8gh/qnQ5vffpQQMZIv8+fdIdGjyDHfTxslt4YIc8NceRCxyi1 szSnR3F08Yv2oKoGkPTXd9kDZappCfBlOC6U0i+Ny08/xwUBQqV+9b/D6N/FIU3tIdF6vh wOOqsCrfyfaZh+Q2WK/0Jg/gpQpDU60rVzTv+sawsaPLLjPhbSZKb29ZniMwNA4O+c17Jx 4HsxLTd5RtHN2En+A04Sr6/2L0VjOqjRe/O5aD/iV4Mh++Alur3yMpSRLUIUTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=bJIqMyop; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715357174; a=rsa-sha256; cv=none; b=ZktzRI7RUkJHv+VAU5mQV48qpDWrHZvr6+QOhC16vcowK/e3j7IaDh0DUpcEePmp2rEsR2 g5nXMePAwbYm7d87BB8Y+KPN8xNAfpo504g1f1+YI4lGtnFTzIoEMPqj8g61Uf74teT0CY 1/Rf+SEVtKXAGAGXfUxSO7mtMkvVqo4cyrpOBiS+y3QiCOgqdATKQI3L/bB5YUfQyETRBq WAISjlfQJdg+MqVyMw+z0HlCY41jC0s61S7COQSrtcQLKn2ghOtG8CKXi7ZI5Q/VbEdwGM oJLh8prlSULF/Qr3j7s/wh8xrdhufE0DSS3DF5IXsqwp9vHDnr58S3RLxLohBg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBABC736EC for ; Fri, 10 May 2024 18:06:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5Sl4-0007fU-7k; Fri, 10 May 2024 12:06:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Sl2-0007fE-Ck for guix-patches@gnu.org; Fri, 10 May 2024 12:06:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5Sl1-0001TP-Nn for guix-patches@gnu.org; Fri, 10 May 2024 12:06:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5Sl0-0003rQ-GH for guix-patches@gnu.org; Fri, 10 May 2024 12:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 May 2024 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq , Maxim Cournoyer Cc: 70282@debbugs.gnu.org, Vivien Kraus Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171535713014834 (code B ref 70282); Fri, 10 May 2024 16:06:02 +0000 Received: (at 70282) by debbugs.gnu.org; 10 May 2024 16:05:30 +0000 Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5SkU-0003rC-7X for submit@debbugs.gnu.org; Fri, 10 May 2024 12:05:30 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:49164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5SkS-0003r6-TK for 70282@debbugs.gnu.org; Fri, 10 May 2024 12:05:29 -0400 Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-a599a298990so539869466b.2 for <70282@debbugs.gnu.org>; Fri, 10 May 2024 09:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715357064; x=1715961864; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=d/VHyTaMnvZvSEpE+NALXx/6v4neQyXS2AXBq4XpVck=; b=bJIqMyopp7Jk7XNNR0a+GzfBJ3NKXHHuuxpquAsRuIOfTqR8OXli45jF1uaU5HODAr msvUB/+/TCwI1/N2i/zwxtWnv2VPsg3oOcuKEClVERcqm3d4dVQOoFJmDv+boBkQG/o8 CewtnvExotBlhxC9IJPmJ1j46wv2IvizPq+1n9flrYcKdXC4/gb6H99mP+9xlgSzoS8t b0WDVLNgixRaIJFa+NiXlp9HYAXIBh9qpH2+1HLw9AEm0RIqfgScLe+E5hQF8wk0H0IA 5mxiMyPCRZEPH6mh5D7nramfwyD2DpuV5RY9uL4zPDp+I9gQdambK3+1w3i9Lsj14wDD 4cuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715357064; x=1715961864; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d/VHyTaMnvZvSEpE+NALXx/6v4neQyXS2AXBq4XpVck=; b=ZAGCrMio5KLnmxZ3fzEI4H6OONzK2i3+IMsBS5LI0R63qY7rE7Cc0VvhIaMVloUzLU Q1UZ+cPKEHYEmHX0v8VQL1ckgtdg2yKFQRWX/Y7SorXf3hMnNNm3JyGz33zRNKhzvMFn p1fTzwy/7wB2emxrzLRVjGY2pTFd8im7wVoRwaXibuOBZhBcBtXV7C46Zd85ri7dl+XC Hz7z71IEiPauQHYqumMsLPOJYFUVn5fDR/+LBYVjXeTersXMst5LEJHn5/5tIyN0bX6q 6oMd+vsHVCqGPLsy9RgLSKag5GKpUI8+fM8HcSeX78kpKDRGZH8wo5ycRgZrCRUXS71S v6Ng== X-Gm-Message-State: AOJu0YzTeRvEpmw1lKS184l3UM7cAmutj7D8ZGl3+ijN0mJnMxIUeL+7 rpA7fyn3guEtrpAVLtqnNSdffXtHlsFIy/EnDZk22CIQSNlmWZIr X-Google-Smtp-Source: AGHT+IFyjvSTOWD+QpiFj36PkjzkC2RVi6TvrzkonWYXaUP+lRla2ZkPsCJasQE7xThyX9HVSeTWkA== X-Received: by 2002:a50:c349:0:b0:572:7ea0:66ca with SMTP id 4fb4d7f45d1cf-5734d6dc34amr2181182a12.36.1715357063844; Fri, 10 May 2024 09:04:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733c2cb54csm1933158a12.60.2024.05.10.09.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 09:04:22 -0700 (PDT) Message-ID: <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 10 May 2024 18:04:21 +0200 In-Reply-To: <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 5.62 X-Migadu-Queue-Id: BBABC736EC X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 5.62 X-TUID: Rv2lPM/mtyf6 Am Freitag, dem 10.05.2024 um 14:59 +0000 schrieb Dariqq: > Hi Liliana and Maxim, >=20 > On 09.05.24 00:11, Liliana Marie Prikler wrote: > > Hi Dariqq, > >=20 > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: > > > [...] > > >=20 > > > On 08.05.24 21:51, Maxim Cournoyer wrote: > > >=20 > > > > [...] > > > > Perhaps a simple patch would convey the change better and be > > > > easier > > > > to > > > > maintain in the future / be readily available for other > > > > distributions to > > > > use. > > >=20 > > > The simple patch that would do this is basically the patch from > > > nixos > > > in=C2=A0 v1 of this which adds a shebang line for gjs to the service > > > invocation files (rather than the dbus service invoking $gjs > > > $service). The problem then is that wrap-program changes the > > > filename > > > to * .real which makes gjs unhappy. > > >=20 > > > [...] > > > Maybe another comment, similiar to the one Liliana suggested > > > earlier > > > in this thread, could be added at the beginning to inform about > > > changing to wrap script + patch instead once that is a viable > > > option? > > The pattern we typically use is to add an autotools-style > > "variable", > > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > > substitute* to fill it in.=C2=A0 I don't think it's a requirement, but > > since > > Maxim suggested, it'd definitely be nice to have. > >=20 >=20 > Tried this today and as the js service files are created from a > common template using mesons 'configure_file' method this sets all=20 > autotools-style variables unknown to meson to the empty string.=20 > Afterwardes the susbtitute* at the wrapping phase is unable to > replace anything ofc. >=20 > So I think I would need to either change the naming-scheme of the=20 > placeholders or substitute them into the template file=C2=A0 before the > files get configured by meson. Or you add an option to meson_options.txt to fill it in, so that you can provide the right value via #:configure-flags Cheers