From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QDr4Cm81sWVx8wAA62LTzQ:P1 (envelope-from ) for ; Wed, 24 Jan 2024 17:06:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QDr4Cm81sWVx8wAA62LTzQ (envelope-from ) for ; Wed, 24 Jan 2024 17:06:07 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=PWhfMiSD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1706112366; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=95gB6eANIskK2+/o1ik4ZmwEz493Wkr79WVQpYFkn0I=; b=iFWaEJGWsaNCU6P+44UmX3Ghbeo0aFuOYbAq/PaNhVpNFd0iJwytyXs6MLxKm3FypJaEHN lz29z0XyPLeTkZFS90CQXZcr1wYs/88B2dUSPXamnLkByD+JNuANhLAvQbuW0386rgTIXX PNou5bm9/IdW+yK06ulvO8FduAvTrU2TP1icRzD+2HLYgG7TvA+KEGiupnz7LN37pZRK33 9pOlSLy/GcIsvL5FcMZsnbne0tmAIm56ONPjMwUDoJHjAnVktfjRRoOHb41OkZ8WTrXqPK 1S+cniA7kC7rtkprkQKMKKZLnDp7+6yCr/5NI0Tn65wouMRbG2PREwKpYKunPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=PWhfMiSD; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1706112366; a=rsa-sha256; cv=none; b=HnfZyvhjv9/7VzddkPt7IWXvi9De61SRxZSknclP5oLoStwWHiPoUnzngUQ4G9/I1/jT6j nsMgeFxLSwdUjlkk04YYLnNeRk0y8nWIE8BBlC54qpTUTMOVNmIEUUVDLL7bkSzq7dD5wp 1svE9I5BFyn5YrJA1/0Nafi0aLqEWEnIwWNnJW5cm6BMAhhOhDOSxIpOYilXilAQqGne6x aNLmghkoX6b9GoiDtzYqKd7jps3afGQdaAafPglHhtbWrZDMlHpGK7bX5e3kjmJIVX3ZoC /pWrwtMrZZl4MivDKbxiO43TXa3pmx0k8CRlZ3BaU9ymT0+uZ36Y8nvXOQJbOw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2EC71777E for ; Wed, 24 Jan 2024 17:06:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSflI-0002iy-BH; Wed, 24 Jan 2024 11:06:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSflF-0002if-Dh for guix-patches@gnu.org; Wed, 24 Jan 2024 11:05:57 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSflF-00052b-5p for guix-patches@gnu.org; Wed, 24 Jan 2024 11:05:57 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSflK-00012m-8U for guix-patches@gnu.org; Wed, 24 Jan 2024 11:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings. Resent-From: Romain Garbage Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jan 2024 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic Courtes Cc: Andreas Enge , Sharlatan Hellseher , 68682@debbugs.gnu.org, Efraim Flashner , Eric Bavier Received: via spool by 68682-submit@debbugs.gnu.org id=B68682.17061123063927 (code B ref 68682); Wed, 24 Jan 2024 16:06:02 +0000 Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 16:05:06 +0000 Received: from localhost ([127.0.0.1]:46350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfkP-00011G-9m for submit@debbugs.gnu.org; Wed, 24 Jan 2024 11:05:05 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSfkM-00010c-Oy for 68682@debbugs.gnu.org; Wed, 24 Jan 2024 11:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:message-id:in-reply-to:references: subject:mime-version:content-transfer-encoding; bh=95gB6eANIskK2+/o1ik4ZmwEz493Wkr79WVQpYFkn0I=; b=PWhfMiSDPzWOEpiaVJe6Fn5/lta1gZnuEmuu7j48ezw/77DCHZ7Wr48g OuT/1wJdMKvKo6/bmHRs9gCdAzJC3yA11Taj6DYNS9JTWZnEaSTvV4Qw+ YXd6e0rB2ElMvD+JevC56YbimAgynQxOotWubGKytLVGe3U03mS63bTE7 E=; Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of romain.garbage@inria.fr designates 128.93.142.32 as permitted sender) identity=mailfrom; client-ip=128.93.142.32; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="romain.garbage@inria.fr"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 include:mailout.safebrands.com a:basic-mail.safebrands.com a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160 ip4:89.107.174.7 mx ~all" Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@zcs-store5.inria.fr) identity=helo; client-ip=128.93.142.32; receiver=mail2-relais-roc.national.inria.fr; envelope-from="romain.garbage@inria.fr"; x-sender="postmaster@zcs-store5.inria.fr"; x-conformance=spf_only X-IronPort-AV: E=Sophos;i="6.05,216,1701126000"; d="scan'208";a="148437392" X-MGA-submission: MDHSJLzTgb2KJTaRNNct4P3tnT319mZD0R3CCCaTm6M02/+FBCG0PnXjS8+H9tvGeZrzInmxZoUwlsVq1FZftjzd/2HnhV3kJD3Du7l9THWzhPAHI6zQu0djdEcxp3t5JM1ABc58A9otkwZIQBR99aEC19l2cp95aUcJmynCtAi9+g== Received: from zcs-store5.inria.fr ([128.93.142.32]) by mail2-relais-roc.national.inria.fr with ESMTP; 24 Jan 2024 17:04:51 +0100 Date: Wed, 24 Jan 2024 17:04:50 +0100 (CET) From: Romain Garbage Message-ID: <971019240.17863501.1706112290823.JavaMail.zimbra@inria.fr> In-Reply-To: <878r4evl6f.fsf@gnu.org> References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@inria.fr> <878r4evl6f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [193.50.110.153] X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - FF115 (Linux)/8.8.15_GA_4581) Thread-Topic: maths: arpack-ng: Modify build settings. Thread-Index: 1JwDey5/7j6KSo5azVRjT/Z8LnfKXA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.13 X-Spam-Score: 2.13 X-Migadu-Queue-Id: C2EC71777E X-Migadu-Scanner: mx12.migadu.com X-TUID: WuB0BgLKdYs8 Hello :) ----- Mail original ----- > De: "Ludovic Courtes" > =C3=80: "Andreas Enge" > Cc: "Romain Garbage" , "Eric Bavier" , "Sharlatan Hellseher" > , 68682@debbugs.gnu.org, "Efraim Flashner" > Envoy=C3=A9: Mercredi 24 Janvier 2024 14:51:52 > Objet: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settin= gs. > Hi! :-) >=20 > Andreas Enge skribis: >=20 >> I see that the ISO C binding flag installs additional headers, but I do = not >> see why the flag for building shared libraries would be needed. In the c= urrent >> arpack-ng, there is already a shared library in the lib/ subdirectory. >> >> Could you explain how adding the flag makes a difference? >=20 > The goal should be to build shared libraries only. If that=E2=80=99s alr= eady > happening without passing =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99, I a= gree we can drop > it, in an effort to keep the package definition minimal. >=20 > Romain, could you confirm that =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99= is indeed > unnecessary and send a new version without it if it is? I built the package with and without '-DBUILD_SHARED_LIBS=3DON' and compare= d the outputs: ``` $ diff -r /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0 /gnu/= store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0 Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li= b/libarpack.so and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.= 9.0/lib/libarpack.so differ Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li= b/libarpack.so.2 and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-= 3.9.0/lib/libarpack.so.2 differ Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li= b/libarpack.so.2.1.0 and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack= -ng-3.9.0/lib/libarpack.so.2.1.0 differ diff -r /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/lib/pkg= config/arpack.pc /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.= 0/lib/pkgconfig/arpack.pc 1c1 < prefix=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0 --- > prefix=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0 3,4c3,4 < libdir=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/lib < includedir=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/= include/arpack-ng --- > libdir=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0/lib > includedir=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0/= include/arpack-ng $ diff -u /tmp/*arpack-ng # these files contain the output of 'ldd /gnu/st= ore/*arpack-ng/lib/libarpack.so' +++ /tmp/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng=092024-01-24 16:53:44.8= 05910227 +0100 @@ -1,9 +1,9 @@ -=09linux-vdso.so.1 (0x00007ffe84d4b000) -=09libblas.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-3.= 9.0/lib/libblas.so.3 (0x00007f9208982000) -=09liblapack.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-= 3.9.0/lib/liblapack.so.3 (0x00007f9208200000) -=09libgfortran.so.5 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort= ran-11.3.0-lib/lib/libgfortran.so.5 (0x00007f9207e00000) -=09libm.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l= ib/libm.so.6 (0x00007f92088a5000) -=09libgcc_s.so.1 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfortran= -11.3.0-lib/lib/libgcc_s.so.1 (0x00007f92081e6000) -=09libquadmath.so.0 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort= ran-11.3.0-lib/lib/libquadmath.so.0 (0x00007f920819d000) -=09libc.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l= ib/libc.so.6 (0x00007f9207c04000) -=09/gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/lib/ld-linux-x86= -64.so.2 (0x00007f9208a22000) +=09linux-vdso.so.1 (0x00007ffdb2fb5000) +=09libblas.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-3.= 9.0/lib/libblas.so.3 (0x00007f0e9f582000) +=09liblapack.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-= 3.9.0/lib/liblapack.so.3 (0x00007f0e9ee00000) +=09libgfortran.so.5 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort= ran-11.3.0-lib/lib/libgfortran.so.5 (0x00007f0e9ea00000) +=09libm.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l= ib/libm.so.6 (0x00007f0e9f4a5000) +=09libgcc_s.so.1 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfortran= -11.3.0-lib/lib/libgcc_s.so.1 (0x00007f0e9ede6000) +=09libquadmath.so.0 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort= ran-11.3.0-lib/lib/libquadmath.so.0 (0x00007f0e9ed9d000) +=09libc.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l= ib/libc.so.6 (0x00007f0e9e804000) +=09/gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/lib/ld-linux-x86= -64.so.2 (0x00007f0e9f622000) ``` To me, it doesn't seem that the '-DBUILD_SHARED_LIBS=3DON' option is necess= ary, but I might miss something. What do you think? Cheers, Romain