[bug#27464] [PATCH] gnu: Add ht.

[bug#27464] [PATCH] gnu: Add ht.

[Gábor Boskovits]

    * gnu/packages/hexedit.scm (ht): New variable.
---
 gnu/packages/hexedit.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
index d2aaec306..7fc5a20ff 100644
--- a/gnu/packages/hexedit.scm
+++ b/gnu/packages/hexedit.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
+;;; Copyright © 2017 Gábor Boskovits <boskovits@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,3 +45,23 @@ file can be a device as the file is read a piece at a time.  You can modify
 the file and search through it.")
     (home-page "http://rigaux.org/hexedit.html")
     (license license:gpl2+)))
+
+(define-public ht
+  (package
+    (name "ht")
+    (version "2.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://sourceforge.net/projects/hte/files/ht-source/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+                (base32
+                  "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9i"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses",ncurses)))
+    (synopsis "The HT Editor: A file editor/viewer/analyzer for executables")
+    (description "This program is a file viewer, editor and analyzer for text, binary,
+and (especially) executable files.")
+    (home-page "http://hte.sourceforge.net/")
+    (license license:gpl2)))
+
-- 
2.13.0

[bug#27464] miniLZO

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 61 bytes --]

This software uses miniLZO. I guess it is ok to leave as is.

[-- Attachment #2: Type: text/html, Size: 429 bytes --]

[bug#27464] miniLZO

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 351 bytes --]

Hullo,

On 24/06/17 00:45, Gábor Boskovits wrote:
> This software uses miniLZO. I guess it is ok to leave as is.

miniLZO isn't a stand-alone library but a subset of LZO specifically
meant to be bundled with other software. It's also GPL2+, so it should
be fine.

...unless you had a specific objection in mind?

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

[bug#27464] [PATCH] gnu: Add ht.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 2585 bytes --]

On 23/06/17 18:16, Gábor Boskovits wrote:
>     * gnu/packages/hexedit.scm (ht): New variable.
> ---
>  gnu/packages/hexedit.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
> index d2aaec306..7fc5a20ff 100644
> --- a/gnu/packages/hexedit.scm
> +++ b/gnu/packages/hexedit.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
> +;;; Copyright © 2017 Gábor Boskovits <boskovits@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,3 +45,23 @@ file can be a device as the file is read a piece at a time.  You can modify
>  the file and search through it.")
>      (home-page "http://rigaux.org/hexedit.html")
>      (license license:gpl2+)))
> +
> +(define-public ht
> +  (package
> +    (name "ht")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://sourceforge.net/projects/hte/files/ht-source/"

I'd re-format this to wrap at <= 80 characters. I'm old.

> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +                (base32
> +                  "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9i"))))

The two lines above should be indented with a single space:

  (sha256
   (base32
    ("0foobar..."

In a properly configured™ Emacs editor, hitting C-M-q at the start of
the package expression will do the Right Thing.

> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses",ncurses)))

Missing space before ,ncurses. Does this compile? If so, cool.

(It does!)

> +    (synopsis "The HT Editor: A file editor/viewer/analyzer for executables")

In the spirit of section 6.7.4 of the Guix manual, I'd shorten this to

   (synopsis "Editor, viewer, and analyzer for executable files")

> +    (description "This program is a file viewer, editor and analyzer for text, binary,
> +and (especially) executable files.")

s/This program/ht/

> +    (home-page "http://hte.sourceforge.net/")
> +    (license license:gpl2)))
> +

Spurious newline:

  $ git am ~/this
  Applying: gnu: Add ht.
  .git/rebase-apply/patch:39: new blank line at EOF.
  warning: 1 line adds whitespace errors.

All in all trivial things! I'll leave a day or so for other reviewers.
You can submit a new patch if you like, or I can make the changes myself
when I push.

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

[bug#27464] miniLZO

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]

[Re-CCing the bug]

On 24/06/17 15:20, Gábor Boskovits wrote:
> Ok, thanks. That is also what I thought. Then this patch is fine by me.
>
> 2017. jún. 24. 15:18 ezt írta ("Tobias Geerinckx-Rice" <me@tobias.gr
> <mailto:me@tobias.gr>>):
>
>     miniLZO isn't a stand-alone library but a subset of LZO specifically
>     meant to be bundled with other software. It's also GPL2+, so it should
>     be fine.

So configure.ac also allows linking to the full library, instead of
inlining the mini version. I guess I wasn't expecting that level of
flexibility.

In that case, I think we should use our ‘lzo’ package instead. Adding it
as an input seems to suffice, no configure flags necessary. Sorry to
change my mind on you! :-)

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]

bug#27464: [PATCH] gnu: Add ht.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 171 bytes --]

On 23/06/17 18:16, Gábor Boskovits wrote:
> * gnu/packages/hexedit.scm (ht): New variable.

Pushed as 24b91ebd2e78a103aee128e5e089b6d6bf339fd9.

Thanks!

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]