From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id qMc8CHlMXWZIPAAAA41jLg (envelope-from ) for ; Mon, 03 Jun 2024 06:54:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id ULsZA3lMXWav1gAA62LTzQ (envelope-from ) for ; Mon, 03 Jun 2024 06:54:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="jv79LO/K"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717390456; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8VFt2m9nsubJn+xofFtAb6iYg8QogVcdb6kaxdFAJqg=; b=I6/frw3i/fPUQqF3SCU+ZT3JTjrq3282g8h0ErX4XzZxd6g6ddgpxlyGVTU8fYRe5PXgCa w3wpD8O1Q6JZixls3Y50UQLFHT6DfQ+5r4nGV4HUaSy8HjU+HuHnBYU58McxrRkuMfCbJ1 EJ5Z7cZENBtqxuuQ+KNJgm3zJaSznkgFEM/Zoozpkf/lTlpDMjs+dtJajS/8ynP6BX68n1 fFhPo9JedOQy4y9cvOTxehkNV07iJEqp16FQhy/mBuJSnjssrtiQTU+8ipiP9tuGCZRQtD BxioabQHTA1p6yvCEbMp35KRvYEuegEc7981KeNQySeLr7eczJluxioTMEUe1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717390456; a=rsa-sha256; cv=none; b=evPiDzxyAx5eolzbKMOet8tIy8FmxYronmIQD6iXU1pANQVEDIV/jZ26WFCfSkGivLMqaq hMpAl800XXJr819WBP15cB1th6rq8OD7ffHhnVq/7Gq6S2MMFOZnJzQeK2mvygn/y32/wd 5bhwYGuuW12G9UmerlpIvpZwRnGFp9xK97b7jpFLx77V9yPyhPd8KCM/5knmbMAANb9E5j ojZIQb12qMw5Qi1Ua+Z8d0kTylFYV0jXpCBUSdTBd/d7qLhjtsPeYF0Xr8QKwuBTpEl60A BehWsv6Lc68/LXDVTE2dL2EE4qPsjVXn66KZzQp27AfquzQd7M9Y4Cod9i41lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b="jv79LO/K"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB91770190 for ; Mon, 03 Jun 2024 06:54:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDxxx-0000nO-Mh; Sun, 02 Jun 2024 23:02:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDxxu-0000ju-6W for guix-patches@gnu.org; Sun, 02 Jun 2024 23:02:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDuOc-0008BE-7o for guix-patches@gnu.org; Sun, 02 Jun 2024 19:13:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDuOo-0001xn-EJ for guix-patches@gnu.org; Sun, 02 Jun 2024 19:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71320] [PATCH] services: nix: Fix activation. Resent-From: kiasoc5 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71320-done@debbugs.gnu.org Received: via spool by 71320-done@debbugs.gnu.org id=D71320.17173700077453 (code D ref 71320); Sun, 02 Jun 2024 23:14:02 +0000 Received: (at 71320-done) by debbugs.gnu.org; 2 Jun 2024 23:13:27 +0000 Received: from localhost ([127.0.0.1]:48687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDuOE-0001w9-VJ for submit@debbugs.gnu.org; Sun, 02 Jun 2024 19:13:27 -0400 Received: from layka.disroot.org ([178.21.23.139]:36218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDuOB-0001vo-Qd for 71320-done@debbugs.gnu.org; Sun, 02 Jun 2024 19:13:25 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6D2E240C71; Mon, 3 Jun 2024 01:03:44 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NStRZZml3-uo; Mon, 3 Jun 2024 01:03:43 +0200 (CEST) Message-ID: <948fa1a4-7955-4cc2-94dd-097ecae619da@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1717369420; bh=z7LYHrPkkZnWlJn9AWU0TxkRCODV2Pl5roANFaeBNXI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=jv79LO/KG2CpVJTb5bTDEsHMs3MsouE0HnYtE5HogHigz0jW5fEnl6KPl37dnHgl/ x0RkdaWEk+hENuvrZQ50OLRagOAK1qhh3jP8QqyWBNFBuUsHbEs8pH4IwVq1UFuu/Y iVAuTgek0TIyqEZKr3ILE3FzLiztgtWsrO/JFB9q165p6JAUOP3wjf/XCOlUqru5XI LZhr6thr5QeAXu9jicjpBCzWI8HwjC5OEDKvCoxzcr4aS9o9umzJDd37f2hMG9EEeG bFu0/vmSgQobce5NnnkpFmTqLOAWmZ5WCxba8xvIKfjcgmyWj2Ub5iiQzgbLH9Pb5J ix8rsIXUEgXcA== Date: Sun, 2 Jun 2024 19:03:36 -0400 MIME-Version: 1.0 References: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> <87cyozlc4v.fsf@gnu.org> <8734pv9wnr.fsf@gmail.com> Content-Language: en-US In-Reply-To: <8734pv9wnr.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: kiasoc5 X-ACL-Warn: , kiasoc5 via Guix-patches From: kiasoc5 via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.84 X-Spam-Score: -3.84 X-Migadu-Queue-Id: BB91770190 X-Migadu-Scanner: mx11.migadu.com X-TUID: 6P4q1hzUGMHS On 6/2/24 11:44, Oleg Pykhalov wrote: > Hi Ludovic, > > Thank you for the review. > > Ludovic Courtès writes: > >> Oleg Pykhalov skribis: >> >>> This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. >>> >>> * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if it >>> already exists. >>> >>> Reported-by: kiasoc5 >>> Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 >> >> Please add “Fixes …” if there’s an associated bug report. >> >> Otherwise LGTM, thanks! > > I've replaced 'Reported-by: kiasoc5 ' with: > > Reported by kiasoc5 at > . > > similar to other commits. > > Pushed as bc06affabcf68bbe93e9afee13bef8cc8c6336a2 to master. > > > Regards, > Oleg. Thanks! I'll report bugs to bug-guix next time.