From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WCekDrq04WKS8AAAbAwnHQ (envelope-from ) for ; Wed, 27 Jul 2022 23:57:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id qLyIDbq04WIlvwAAG6o9tA (envelope-from ) for ; Wed, 27 Jul 2022 23:57:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E82C93FAAC for ; Wed, 27 Jul 2022 23:57:13 +0200 (CEST) Received: from localhost ([::1]:55298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGp1k-0005fQ-Ok for larch@yhetil.org; Wed, 27 Jul 2022 17:57:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGp1a-0005fE-2p for guix-patches@gnu.org; Wed, 27 Jul 2022 17:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGp1Z-0006ok-Qw for guix-patches@gnu.org; Wed, 27 Jul 2022 17:57:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGp1Z-0002i7-N8 for guix-patches@gnu.org; Wed, 27 Jul 2022 17:57:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56797] [PATCH] gnu: services: fprintd: Add PAM configuration. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jul 2022 21:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56797 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maya Cc: "56797@debbugs.gnu.org" <56797@debbugs.gnu.org> Received: via spool by 56797-submit@debbugs.gnu.org id=B56797.165895899710379 (code B ref 56797); Wed, 27 Jul 2022 21:57:01 +0000 Received: (at 56797) by debbugs.gnu.org; 27 Jul 2022 21:56:37 +0000 Received: from localhost ([127.0.0.1]:57164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGp1A-0002hH-Fs for submit@debbugs.gnu.org; Wed, 27 Jul 2022 17:56:37 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:51406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGp15-0002gz-2Q for 56797@debbugs.gnu.org; Wed, 27 Jul 2022 17:56:35 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by albert.telenet-ops.be with bizsmtp id 0MwQ2800620ykKC06MwQBR; Wed, 27 Jul 2022 23:56:26 +0200 Message-ID: <946b358e-da78-9307-ff12-8a4a060867a8@telenet.be> Date: Wed, 27 Jul 2022 23:56:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <4AtymQ5ic7YPCQjgRG3Dj73aZuO_Rx7GX8YSKBPeoVoOG_Z8LjXXbqvvfaq-ap0fgLADcsE8zibqDwkO7kazYXa0eMA3EeEaiU_6wGQ0yI8=@protonmail.com> <067bff4c-3ada-0597-2632-9482066df2f2@telenet.be> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------FqDMuO2K94dZxSSWOaIMRGeb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658958986; bh=xMkyPXa4dLMMjlmmjat6AFQTHr3tMgeZjTlGFfNhfn8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=OvZBXrwHalJAcL7mTQVh2/tBozw5gHRolj+S7tbreBwqUaRWfLHOgou/Tgw9yOcg3 Ha9WoluCRXfpDgLETslGTagh7UNpf5H9oB4mclZHoowdIwaZAz/JzIw6iJYEKJ1oVv 4OQ6TlnzTfltK1Y+NJB1yOJSsy45lgBpGsNKRqNJ25cmPS3VjwV9wLyEnE7D7KBxPi RD8/qHXuFGmzL3W7CVFtG16fKR3fqNftFAHSS+lU6iemQOdQBZXNJ78O4KB+3DXqxj 55uirwhUyjrkzFzuh2x2gS4q7/WuoMR0+nuvyqHHlZRFdLxJjEQK3BwM2syQ7zJx8v G0t1eIjc0bJ4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658959034; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Wlyrhwe6Lkpn/avFXz3zZV2PKbiMlcvDI8s2eNUWHNE=; b=cr2o/evcz4h/rN3DMEgN5ooO90VUh9bmvJvpOWT0VHNM+cTHOH4XqS+7ozrzhS1B1jph20 jh/m9VARRDEMP3Lf5KDZZt4ju1RYEqHo3MJJ4A5wUFgQAQJOB15tEm1tjqjX3LvaM0EkIV 0zRIbi9O+RACKlqbGLX6WWP7gOOpMwox5NdfYdRByCTpBNX2xNJtRHmOx3k8sDK1f9KKK7 KazwI3d8aSivbnzvOXB0yyi7MEOwgX9a5lkHXc9LATZ7A6ClMezkDAho5tCXbqqo+/TVRf 48JxHGCTtzBLLcBo7rDJg0x2FA3qoUORxLHx3mx1/ixGhdPA8ltDyTmOauWZPw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658959034; a=rsa-sha256; cv=none; b=uLtk9dRfemlkeTef5b9lAPZsa7Z0Fcd5nAEFJc1e9xVC7e2Iib822ftwbL9eZAINdq4TMT 4jrGEvO8DOE+8iWUzbwl0Ud9Os/dNnXg5fQubrh+5N0GNCFPG5jjpJdH9tN9MpfvJS/qIW LIZHv2pqAkRryTlRKg69ZmMopHSGgKp/1vI9xj8F5rG3TxfpsqzsXhSZu64PG9AMR+LMWo W/m3JyM7v2jUyz+JXr29xUTO4anqcXm+x6mP8ZHjfX4ru6zKc32yuUJlSnuD3rcCvx0l/I bHWq2ib2ig4AVfrFi9GCfLeBOnyyHa9D5YpbjPIHe1yo0OJHH1BLh+SdJiTklg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=OvZBXrwH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=telenet.be header.s=r22 header.b=OvZBXrwH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E82C93FAAC X-Spam-Score: 4.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: 53M8+xE7WjEm This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------FqDMuO2K94dZxSSWOaIMRGeb Content-Type: multipart/mixed; boundary="------------V9suXCP4uEO1yrc3tmVEYPni"; protected-headers="v1" From: Maxime Devos To: Maya Cc: "56797@debbugs.gnu.org" <56797@debbugs.gnu.org> Message-ID: <946b358e-da78-9307-ff12-8a4a060867a8@telenet.be> Subject: Re: [bug#56797] [PATCH] gnu: services: fprintd: Add PAM configuration. References: <4AtymQ5ic7YPCQjgRG3Dj73aZuO_Rx7GX8YSKBPeoVoOG_Z8LjXXbqvvfaq-ap0fgLADcsE8zibqDwkO7kazYXa0eMA3EeEaiU_6wGQ0yI8=@protonmail.com> <067bff4c-3ada-0597-2632-9482066df2f2@telenet.be> In-Reply-To: --------------V9suXCP4uEO1yrc3tmVEYPni Content-Type: multipart/mixed; boundary="------------yoqXd0bcol7lubBtIGyug9o8" --------------yoqXd0bcol7lubBtIGyug9o8 Content-Type: multipart/alternative; boundary="------------j0I01C0iGxl6Zr3O45dWJ1bt" --------------j0I01C0iGxl6Zr3O45dWJ1bt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyNy0wNy0yMDIyIDIyOjI2LCBNYXlhIHdyb3RlOg0KPj4gRG9jdW1lbnRhdGlvbiBp cyBtaXNzaW5nIChpbiB0aGUgbWFudWFsKSwgc28gYXMtaXMsIHRoaXMgbmV3IGZlYXR1cmUg aXMNCj4+IGhhcmQgdG8gZmluZC4NCj4gT2g/IEkgZGlkbid0IGtub3cgdGhhdC4gRG9lc24n dCBkZWZpbmUtY29uZmlndXJhdGlvbiBnZW5lcmF0ZSBkb2N1bWVudGF0aW9uIGF1dG9tYXRp Y2FsbHk/IElmIGl0IGRvZXMgbm90LCBJIHdpbGwgaGFwaWxseSBhZGQgaXQsIGJ1dCBJIGhh dmUgbmV2ZXIgd3JpdHRlbiBhbnksIHNvIGl0IHdpbGwgYmUgYSBsZWFybmluZyBwcm9jZXNz Lg0KPg0KVGhlcmUgaXMgc29tZSBwcm9jZWR1cmUgdGhhdCB0YWtlcyBhIHJlY29yZCB0eXBl IGFuZCBnZW5lcmF0ZXMgc29tZSANCmRvY3VtZW50YXRpb24sIGJ1dCBpdCBpcyBub3QgYXV0 b21hdGljYWxseSBjb3BpZWQgaW50byB0aGUgbWFudWFsLCB5b3UgDQp3aWxsIGhhdmUgdG8g ZG8gdGhhdCB5b3Vyc2VsZiAoYW5kIG1heWJlIHR3ZWFrIHRoZSByZXN1bHQgYSBsaXR0bGU6 IA0Kd2hhdCdzIGEgZ29vZCBkb2NzdHJpbmcgaW4gY29kZSBkb2Vzbid0IGFsd2F5cyBmaXQg dmVyeSB3ZWxsIGluIGEgbWFudWFsKS4NCg0KPj4gQWxzbywgdGhlIG1hbnVhbCByZXF1aXJl ZCBnaXZpbmcgZXZlcnkgdG9wLWxldmVsIHByb2NlZHVyZSBhIGRvY3N0cmluZw0KPj4gSUlS QywNCj4gVGhlcmUgaXMgdGhhdCByZXF1aXJlbWVudCwgeWVzLiBCdXQgdGhlcmUgd2VyZW4n dCBhbnkgYXJvdW5kIHRoaXMgbWV0aG9kIHNvIEkgdGhvdWdodCB0aGUgY29uZmlndXJhdGlv biBzdWZmaWNlZCwgYnV0IGlmIGl0IGlzIGEgcmVxdWlyZW1lbnQsIEkgd2lsbCBkbyB0aGF0 Lg0KPg0KSSBkb24ndCBrbm93IGlmIHRoZSByZXF1aXJlbWVudCBpcyBvdmVybHkgc3RyaWN0 bHkgZm9ybXVsYXRlZCBvciBpZiB0aGUgDQpzdXJyb3VuZGluZyBjb2RlIGlzIHdyb25nLg0K DQo+PiBUaGlzIGRvY3VtZW50YXRpb24gaXMgdW5jbGVhciAtLSBkb2VzIHRoaXMgZmllbGQg bmVlZCB0byBiZSBzZXQgdG8gdGhlDQo+PiBfbmFtZV8gIG9mIHRoZSBtb2R1bGUsIG9yIHRv IHRoZV9maWxlIG5hbWVfICBvZiB0aGVfc2hhcmVkIGxpYnJhcnlfICAoYXMNCj4+IGEgZmls ZS1saWtlLCBub3QgYSBkaXJlY3QgZmlsZSBuYW1lLCBiZWNhdXNlIG9mIHN0YWdpbmcpLCBv ciAuLi4/ICBBbHNvLA0KPj4gdGhlICdsaXN0JyBjaGVjayBjYW4gYmUgbW9yZSBwcmVjaXNl LCBJSVJDIHRoZXJlIHdhcyBzb21lIG1ldGhvZCBmb3Igbm90DQo+PiBqdXN0IHVzaW5nIGxp c3Q/IGJ1dCBkb2luZyB0aGluZ3MgbGlrZSBsaXN0LW9mLXN0cmluZ3M/Lg0KPiBUaGUgbmFt ZSBvZiB0aGUgcGFtIG1vZHVsZSwgbm90IGEgc2hhcmVkIGxpYnJhcnkuIFNvIHRoZSBmaWxl IGluIC9ldGMvcGFtLmQuIEl0IGlzIGEgZGlyZWN0IG5hbWUsIHNpbmNlIGl0IGlzIG5vdCBp bnNpZGUgdGhlIHN0b3JlLCBwYW0gbW9kdWxlcyBoYXZlIHN0YXRpYyBwYXRoLg0KVG8gYmUg Y2xlYXIsIGl0IGlzIGNsZWFyIGlmIHlvdSBsb29rIGF0IHRoZSBkZWZhdWx0IHZhbHVlLCBi dXQgSSB0aGluayANCml0J3MgYmVzdCB0byBiZSBleHBsaWNpdCBpbiB0aGUgZG9jdW1lbnRh dGlvbi4NCg0KPiBBcyBmb3IgdGhlIGNvbmZpZ3VyYXRpb24gb3B0aW9ucywgaXQncyBteSBm aXJzdCB0aW1lIHVzaW5nIHRoZW0gYW5kIEkgZGlkbid0IHJlYWxseSB1bmRlcnN0YW5kIHRo ZSBkZWZpbmUtc3ludGF4IGRlZmluaXRpb24sIHNvIEkgcmVhbGx5IGp1c3Qgc2tpbW1lZCB0 aHJvdWdoIHRoZSBndWl4IHJlcG9zaXRvcnkgZm9yIHNvbWUgdXNlcy4NCklJUkMsIHRoZXJl IGFyZSBzb21lIHByb2NlZHVyZXMgeW91IGNhbiB1c2UgdG8gZGVmaW5lIGxpc3Qtb2YteD8g DQpwcm9jZWR1cmVzIGJ1dCBJIGRvbid0IHJlY2FsbCB0aGUgZGV0YWlscy4NCg0KR3JlZXRp bmdzLA0KTWF4aW1lLg0KDQo= --------------j0I01C0iGxl6Zr3O45dWJ1bt Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 27-07-2022 22:26, Maya wrote:
Documentation is missing (=
in the manual), so as-is, this new feature is
hard to find.

Oh? I didn't know that. Does=
n't define-configuration generate documentation automatically? If it does=
 not, I will hapilly add it, but I have never written any, so it will be =
a learning process.

There is some procedure that takes a record type and generates some documentation, but it is not automatically copied into the manual, you will have to do that yourself (and maybe tweak the result a little: what's a good docstring in code doesn't always fit very well in a manual).

Also, the manual required =
giving every top-level procedure a docstring
IIRC,

There is that requirement, y=
es. But there weren't any around this method so I thought the configurati=
on sufficed, but if it is a requirement, I will do that.
I don't know if the requirement is overly strictly formulated or if the surrounding code is wrong.

This documentation is un=
clear -- does this field need to be set to the
_na=
me_ of the module, or to the _file=
 name_ of the _shared library_ (as
a file-like, not a direct file name, because of staging), or ...?  Also,
the 'list' check can be more precise, IIRC there was some method for not
just using list? but doing things like list-of-strings?.

The name of the pam module=
, not a shared library. So the file in /etc/pam.d. It is a direct name, s=
ince it is not inside the store, pam modules have static path.
To be clear, it is clear if you look at the default value, but I think it's best to be explicit in the documentation.

As for the configuration o=
ptions, it's my first time using them and I didn't really understand the =
define-syntax definition, so I really just skimmed through the guix repos=
itory for some uses.
IIRC, there are some procedures you can use to define list-of-x? procedures but I don't recall the details.

Greetings,
Maxime.

--------------j0I01C0iGxl6Zr3O45dWJ1bt-- --------------yoqXd0bcol7lubBtIGyug9o8 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------yoqXd0bcol7lubBtIGyug9o8-- --------------V9suXCP4uEO1yrc3tmVEYPni-- --------------FqDMuO2K94dZxSSWOaIMRGeb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuG0iAUDAAAAAAAKCRBJ4+4iGRcl7jJA AP480VbT6N45DMuPETsfXRHpBgyaxUFHtAZW3GolGWy6PwD7B9qnBatrQLgWVAm4GkoFVZgoQl4s ko1lhAFfWPH6owE= =heSx -----END PGP SIGNATURE----- --------------FqDMuO2K94dZxSSWOaIMRGeb--