unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet).
@ 2017-08-20 18:07 Hartmut Goebel
       [not found] ` <handler.28163.B.150325246411213.ack@debbugs.gnu.org>
  2017-08-23 13:40 ` [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet) Efraim Flashner
  0 siblings, 2 replies; 4+ messages in thread
From: Hartmut Goebel @ 2017-08-20 18:07 UTC (permalink / raw)
  To: 28163

* gnu/packages/kde.scm (libksysguard)[arguments]<#:phases>'check':
  Set QT_QPA_PLATFORM=offscreen. Enable all tests except of the
  failing one.
---
 gnu/packages/kde.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index a65a61f96..0f21b8a9d 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -301,8 +301,10 @@ used in KDE development tools Kompare and KDevelop.")
              (substitute* "processcore/CMakeLists.txt"
                (("KAUTH_HELPER_INSTALL_DIR") "KDE_INSTALL_LIBEXECDIR"))))
          (replace 'check
-           (lambda _         ;other tests require a display and therefore fail
-             (zero? (system* "ctest" "-R" "chronotest")))))))
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             ;; TODO: Fix this failing test-case
+             (zero? (system* "ctest" "-E" "processtest")))))))
     (home-page "https://www.kde.org/info/plasma-5.10.4.php")
     (synopsis "Network enabled task and system monitoring")
     (description "KSysGuard can obtain information on system load and
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#28163] Acknowledgement ([PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet).)
       [not found] ` <handler.28163.B.150325246411213.ack@debbugs.gnu.org>
@ 2017-08-20 18:12   ` Hartmut Goebel
  0 siblings, 0 replies; 4+ messages in thread
From: Hartmut Goebel @ 2017-08-20 18:12 UTC (permalink / raw)
  To: 28163

Despite the subject, this is a single patch :-) I carved it out from a
larger `git am` patch-set, but it is independent from the others.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet)
  2017-08-20 18:07 [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet) Hartmut Goebel
       [not found] ` <handler.28163.B.150325246411213.ack@debbugs.gnu.org>
@ 2017-08-23 13:40 ` Efraim Flashner
  2017-08-24 10:46   ` bug#28163: " Hartmut Goebel
  1 sibling, 1 reply; 4+ messages in thread
From: Efraim Flashner @ 2017-08-23 13:40 UTC (permalink / raw)
  To: 28163; +Cc: Hartmut Goebel

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

This patch works on my aarch64 machine. I would move the setenv line to
a separate phase before the 'check phase.

LGTM!

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#28163: [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet)
  2017-08-23 13:40 ` [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet) Efraim Flashner
@ 2017-08-24 10:46   ` Hartmut Goebel
  0 siblings, 0 replies; 4+ messages in thread
From: Hartmut Goebel @ 2017-08-24 10:46 UTC (permalink / raw)
  To: Efraim Flashner, 28163-close

Pushed as e3c13d044f8c7fdeef5079e16591dc4302f5c31b after moving the
setenf into a phase called "check-setup".

Thanks for reviewing.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-24 10:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 18:07 [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet) Hartmut Goebel
     [not found] ` <handler.28163.B.150325246411213.ack@debbugs.gnu.org>
2017-08-20 18:12   ` [bug#28163] Acknowledgement ([PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet).) Hartmut Goebel
2017-08-23 13:40 ` [bug#28163] [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet) Efraim Flashner
2017-08-24 10:46   ` bug#28163: " Hartmut Goebel

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).