From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4OotFv8iZmBjVgEAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 21:46:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4DQcEP8iZmAFfgAA1q6Kng (envelope-from ) for ; Thu, 01 Apr 2021 19:46:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E18AABB58 for ; Thu, 1 Apr 2021 21:46:06 +0200 (CEST) Received: from localhost ([::1]:36998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS3GX-00082d-Se for larch@yhetil.org; Thu, 01 Apr 2021 15:46:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS3Fa-0007i6-MP for guix-patches@gnu.org; Thu, 01 Apr 2021 15:45:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lS3FV-000646-Ou for guix-patches@gnu.org; Thu, 01 Apr 2021 15:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lS3FV-0001ib-Ll for guix-patches@gnu.org; Thu, 01 Apr 2021 15:45:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47540] [PATCH] gnu: Add prips. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: david larsson , 47540@debbugs.gnu.org Received: via spool by 47540-submit@debbugs.gnu.org id=B47540.16173063006584 (code B ref 47540); Thu, 01 Apr 2021 19:45:01 +0000 Received: (at 47540) by debbugs.gnu.org; 1 Apr 2021 19:45:00 +0000 Received: from localhost ([127.0.0.1]:58722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS3FT-0001i8-Li for submit@debbugs.gnu.org; Thu, 01 Apr 2021 15:44:59 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:51010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS3FR-0001hy-Dh for 47540@debbugs.gnu.org; Thu, 01 Apr 2021 15:44:58 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id nXkv240070mfAB406XkvWj; Thu, 01 Apr 2021 21:44:55 +0200 Message-ID: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> From: Maxime Devos Date: Thu, 01 Apr 2021 21:44:46 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-dJ9+wJe64WdixGqcSMfY" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617306295; bh=df1yBLh9tbrdapd9rt6PN2gDCrKM/EJ1uvsXwurKi9Q=; h=Subject:From:To:Date:In-Reply-To:References; b=JhOIb44cV+WdoI8MYBcf8ZR+yUkuHKzqIIL2kxxhyLOfmry6GhmR+DepHwKFUsrKg p8oQLkydytBkolen4dhjfPavuS/ghRWmiPgIlzEhU31MZuvACLew6aX4gq4QsOVvqf NohsFbGutaN+FWcG5YRyb6OTviixvK1MGO/hy7K9mGP3xphctu6J79SQKNunzlXz6b A45NisU5rf+nIvWYeUcYUBw3XEQ+5Yp6foCOTQLJ93qkKwYExcQIk4oB9PDW6jXAg/ ybPLhHDZD/yi50vw2oMgFW6R16lsb8i6ESi4MqyK0B0eD52ABFuanomaGjOHlDe356 OYgKLSDoHOfBA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617306367; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=df1yBLh9tbrdapd9rt6PN2gDCrKM/EJ1uvsXwurKi9Q=; b=AGgOOdk8vGHLwv4VYBnMjaonkqyIgjUk3Q+F4dtgiuZXfJsqurtHl4VPC1t3Xo0KNNlIcg DDskyutuVx3gpCl7KmJwz6q7SOlrLscDlh9gZ2yQBW0in5gQpOcDegD5f7i6+ovJG168Ei fzZGtjIypZJE5bMwczv/YrLxA67epKLUqcgkQE2/QgfHJ/ktUNZOvwk2bvbYWQsFkeZywl hUTg1w6sBZr0IgY9Ylq/I0BOW405pVttT0nzbJZClUWfh033GyFl3Flx5ZoVmzZneaZGgl 1Fwt/P/+kcoG6tH6EKH5LQ4lfD20Uy3QS0M6ktymEPwEo3kp0FKCBtXZIJcKQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617306367; a=rsa-sha256; cv=none; b=hUZ+dDlKJRWgyVyoa/c9r3DiVTG0eN8TTqQ26V+nG3uv38cQxc/Q3cIXVF5d96DSADpW/K aosstHBQt5ZU3lw6IPCtzZ4WEjEkwRr5DA6UNREUFfib5AkXKiAGPvPmV8ChlE+5HhF04T dikIu8du5g7iUa7TtlhYVF1kGgC8/om3JpgqApFYcDp9qo28SapXt6V5OL5F2Hjk/N3nd9 IZel2MNsyklyftglG7jMfBLs17LPatZWDe420UkcDS+KQBUtUrZ0XElxRa7UGuYYXFJwBG SFlWe8GnI330IznSlh50DxFSajHG/L6Ykyj/a3GuMDAQSEAmE60eyrOgzmhH+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=JhOIb44c; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=JhOIb44c; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E18AABB58 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: wwyMj6Cy0USa --=-dJ9+wJe64WdixGqcSMfY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Some comments on the patch. On Thu, 2021-04-01 at 15:11 +0200, david larsson wrote: > [...] > +(define-public prips > + (package > + (name "prips") > + (version "1.1.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://devel.ringlet.net/files/sys/" > + name "/" name "-" version ".tar.xz")) > + (sha256 > + (base32=20 > "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn")))) > + (build-system gnu-build-system) > + (arguments > + '(#:make-flags (list "CC=3Dgcc") As "CC=3Dgcc" is a constant, I would write '("CC=3Dgcc") here, though admittedly this is largely a matter of taste. Another problem: when cross-compiling, "gcc" will be a compiler for the build system, not the host system (assuming I got the terminology right). Instead, write `(#:make-flags (list (string-append "CC" ,(cc-for-target))) ...) (The quasiquote ` is important.) (TODO to self: fix other packages that incorrectly set "CC=3Dgcc" ...) > + #:phases (modify-phases > + %standard-phases %standard-phases shouldn't be on a separate line here. > + (delete 'configure) > + (delete 'check) Prips has some tests, so don't delete this phase. > + (replace 'install > + (lambda _ > + (let* > + ((bin-dir (string-append %output "/bin")) > + (bin-file (string-append bin-dir "/prips"))) The ((bin-dir ...)) should be on the same line as 'let*'. > + (mkdir-p bin-dir) > + (copy-file "prips" bin-file) > + (chmod bin-file #o700))))))) Why are you making bin/prips writable? Shouldn't this be (chmod bin-file #o600) instead? > + (synopsis "Tool that prints the IP addresses in a given range") > + (description "Prips can be used to print all of the IP addresses in > + a given range. This allows the enhancement of tools only work =E2=80=98Enhancement=E2=80=99 is rather vague and leaning towards marketing= -speak. I do not have an alternative suggestion however. > + on one host at a time (e.g. whois).") > + (home-page "https://devel.ringlet.net/sysutils/prips/") > + (license license:gpl2))) I looked at the source code and it seems prips is actually gpl2+. Greetings, Maxime. --=-dJ9+wJe64WdixGqcSMfY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGYirhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uybAQCxoal1eunp70qhVEm7IQnbnP+P tpvkpTfUHSVTquYNxwD+Mqj0hgYwCTQkhxLAKt2ni8I8NojCq1ilGXK7YZL5rwc= =eMbV -----END PGP SIGNATURE----- --=-dJ9+wJe64WdixGqcSMfY--