From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iCCzCKHt6WFYDgAAgWs5BA (envelope-from ) for ; Fri, 21 Jan 2022 00:17:53 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OLMPBaHt6WEctgAAauVa8A (envelope-from ) for ; Fri, 21 Jan 2022 00:17:53 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC9EF1B99F for ; Fri, 21 Jan 2022 00:17:52 +0100 (CET) Received: from localhost ([::1]:42452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAggh-0003N7-O3 for larch@yhetil.org; Thu, 20 Jan 2022 18:17:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAdri-0002fb-Bz for guix-patches@gnu.org; Thu, 20 Jan 2022 15:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38103) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAdrh-0006RS-QX for guix-patches@gnu.org; Thu, 20 Jan 2022 15:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAdrh-0007Ra-NF for guix-patches@gnu.org; Thu, 20 Jan 2022 15:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53327] [PATCH] gnu: Add mold. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 20:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Rottmann , 53327@debbugs.gnu.org Received: via spool by 53327-submit@debbugs.gnu.org id=B53327.164270977828551 (code B ref 53327); Thu, 20 Jan 2022 20:17:01 +0000 Received: (at 53327) by debbugs.gnu.org; 20 Jan 2022 20:16:18 +0000 Received: from localhost ([127.0.0.1]:59239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAdr0-0007QP-F1 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 15:16:18 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:39316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAdqy-0007QG-4M for 53327@debbugs.gnu.org; Thu, 20 Jan 2022 15:16:17 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id l8GE2600B4UW6Th018GEEK; Thu, 20 Jan 2022 21:16:14 +0100 Message-ID: <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@telenet.be> From: Maxime Devos Date: Thu, 20 Jan 2022 21:16:09 +0100 In-Reply-To: <87fspmyuji.fsf@r0tty.org> References: <87fspmyuji.fsf@r0tty.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6pMduGfiApTMnAj5/dJE" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642709774; bh=Zv50WY+IZTUhjIuO/8uS9cgEPclyZLu+WGdBBK4mlCA=; h=Subject:From:To:Date:In-Reply-To:References; b=huVDAB2YUD1c6cAsDrwPupTHsMQTQjxQRM+viQW4yB3UMIH1k4BpNtzKIA4xod5s1 1VRxxpQXt4c3OIUi+cVv6xqduDfeWXHBqyr/kL3HzQJwPmUW+nT89bCJUpLNTJbXWA wLUt1WzDq4bkYOSZp9+FjCFrTUOJ6Gb8j89woBGHebICOodu6JjnwWVVODgrqPsWdx B4NpHIjJgXTwUBP21hnNPdMQv17qN1VhLWo1mUWBKJT0c5CL3qF1HIcj1TPX0v0HFj Wo+44hWxmA0X+2ik00I9etcjZcv3RihVhV7nNXI118vsI2FpahseDaFzHkhijvY1zH D1hktpXlNGDZQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642720672; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Zv50WY+IZTUhjIuO/8uS9cgEPclyZLu+WGdBBK4mlCA=; b=Qf8GMN5k8pZjJikrsfPIZqiJuHyZZih7iKKL5oBNhSVZsndxj2qi0c2SOfpyzIuLh8pU9i QfUBBaIeey8qMC1A+cmMHteMkaCO7T0i5HkJ+4ltZWu93EqCI1QeoD3jDfacCZeiN3wMbg PkGFVn7KN6RhPGnvCh1QZS38Sf0nCOI2IeTYWxN2/411Pn5vJ3Z/HakdwAhkaOXMM8Pye2 u3Z4oxVPJGJS8OehssZAPB31ReCh+2Iry2+OLU23mfaXBBDl5Xj50h+yVhCs/fagFM9ic/ CvhXizvQvmra2XuYE5A5p+Xki9+7WBFkoCpCWdLOdTAe9FSLT9iTq2FtIjLE9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642720672; a=rsa-sha256; cv=none; b=OW/unckpbIlDnnhU82tyeFIHYsf8aY9Q59d/69CqTWvOCH4xMcc7JZaDBM7O+r7hFyAKPX QMyiXFCp1mNE9HdY6E+Bbg6NpjyU3sHJrilEVcLOUU5O3axQPndPMNoVMUIB/80X1q2j8E aNlrUn6R4tpZvAGUqmarfBPMqNCLgOQqkAmjmRCRrzulJ1Rf2QootQcCKSBZsPtgbrtVz1 E2LTYqQ1q8ePlAutelqkEnxew5NiyT/xK2xA0+C+0vI7gXy0Vj6aTvzi0sfyMAUxVr6l+q 1iR6heBrW8G5i2TElXQcvqKBVmtuWPOXAFpNcegxVoJouQXaxVJp9s7kqiOnHQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=huVDAB2Y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=huVDAB2Y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BC9EF1B99F X-Spam-Score: -5.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: zejqYwGt2+xS --=-6pMduGfiApTMnAj5/dJE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, (*partial* review) There's a directory 'third_party' with bundled code, can it be removed (in an origin snippet)? Andreas Rottmann schreef op ma 17-01-2022 om 20:56 [+0100]: > +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f ; TODO: Tests require clang and h= ardcode `cc` 'clang' =C2=A0can be added to native-inputs and hardcoded =E2=80=98cc=E2=80= =99 can be replaced with 'clang' or 'gcc' with 'substitute*'. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:make-flags (list (string-append "= CC=3D" ,(cc-for-target)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (string-append "CXX=3D" ,(cxx-for-target)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (string-append "PREFIX=3D" %output)) %output is being phased out, instead use #$output (make sure to add ,#~ before (list ...)). > + (inputs (list openssl zlib xxhash)) Why does mold need openssl here? I don't see the relation between linking and TLS. > +=C2=A0=C2=A0=C2=A0 (synopsis "Modern Linker") Why is =E2=80=98Linker=E2=80=99 capitalised? Also, as I understand it, the= point of=C2=A0mold is not chasing whatever is considered =E2=80=98modern=E2=80=99= , but rather being fast and requiring little memory, albeit at the cost of supporting less (less targets, no linker scripts, ...). > + (description "mold is a faster drop-in replacement for existing Unix linkers.") It's a bit short, maybe you could write a bit about memory usage, limitations Since 'mold' is said to be very efficient, it might be interesting to determine if Guix could use 'mold' instead of the linker from 'binutils' by default (with some exceptions like GRUB and Linux which might actually need GNU ld linker scripts) ... that's more something for guix-devel and future patches though. Greetings, Maxime. --=-6pMduGfiApTMnAj5/dJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYenDCRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hoOAP4ib7b0crtdm9UD6bQHntVTtbmd wL8f31BCJZIKExyEPgD7BKNbo6Y1hUT+FZejwo0o2jA/+HysHEtJw2opcphY1gU= =HjET -----END PGP SIGNATURE----- --=-6pMduGfiApTMnAj5/dJE--