unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy.
@ 2024-09-14  2:56 Tobias Geerinckx-Rice via Guix-patches via
  2024-09-16 11:53 ` Andreas Enge
  2024-09-16 20:22 ` Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2024-09-14  2:56 UTC (permalink / raw)
  To: 73242; +Cc: Andreas Enge, Ludovic Courtès

If anything is ‘useless in an initrd’ it better be XML support.  As of
Guile 3.0.9, removing it saves 1418K bytes uncompressed, or 3% of the
total static Guile size.

* gnu/packages/make-bootstrap.scm (%guile-static-initrd): Remove sxml/.

Change-Id: I592dec18c422500eca50663256586ca92df1ac37
---
 gnu/packages/make-bootstrap.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/make-bootstrap.scm b/gnu/packages/make-bootstrap.scm
index 91796efd0f..edc536bff4 100644
--- a/gnu/packages/make-bootstrap.scm
+++ b/gnu/packages/make-bootstrap.scm
@@ -760,6 +760,7 @@ (define %guile-static-initrd
                     "language/elisp"
                     "oop"
                     "scripts"
+                    "sxml"
                     "texinfo"
                     "web"))))
     (name "guile-static-initrd")))

base-commit: c572cf81f4b322af4280ac2133889c997e39d247
prerequisite-patch-id: 65ced16d2330bba0375e48d191afdbb75939c234
prerequisite-patch-id: a84660e898acd198c099d9b5bcafc65731d749b6
prerequisite-patch-id: 51dfb8a914e5ae374b05aabf37071bc23f499442
prerequisite-patch-id: 1ae8937b79e905fa97c9bba8923230b49f02d1d3
prerequisite-patch-id: 995a992e120734d4fb4b198518f78736cf3386bf
prerequisite-patch-id: 6dc38cc7f341b52ccd3aaac580f0762cef08a047
prerequisite-patch-id: c3b6a024c67d2b2d819e83de66b7f6828225bbe7
prerequisite-patch-id: 241cb117acd301ac875feea5574544adb9e2abf4
prerequisite-patch-id: ea111e1c88a7a97ecf8e13b2e608dcfde6a9893f
prerequisite-patch-id: 4fc8aac18afc1b417e3c9825015f6013a7d31209
prerequisite-patch-id: 364ca15152b3e86a77ee64abcf599173ea75d1bd
prerequisite-patch-id: 2f4066d1d249a7c775a86bda300ffe4747eca5ca
prerequisite-patch-id: f20ff1a7a3fd63bc23eb305b23371ed46aede738
prerequisite-patch-id: 66eb3b0b8d5565169223d6dcaaef60e193ecaf17
prerequisite-patch-id: 9a5b632245d8ba1373272bb80f09c26fd19fbfae
prerequisite-patch-id: de8ec49057de5627d9515171a5a416c96230efa4
prerequisite-patch-id: cc1e82738c178db88befbb4779574ee9782e7c30
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy.
  2024-09-14  2:56 [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy Tobias Geerinckx-Rice via Guix-patches via
@ 2024-09-16 11:53 ` Andreas Enge
  2024-09-16 12:11   ` Tobias Geerinckx-Rice via Guix-patches via
  2024-09-16 20:22 ` Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: Andreas Enge @ 2024-09-16 11:53 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 73242, Ludovic Courtès

Am Sat, Sep 14, 2024 at 04:56:50AM +0200 schrieb Tobias Geerinckx-Rice:
> If anything is ‘useless in an initrd’ it better be XML support.  As of
> Guile 3.0.9, removing it saves 1418K bytes uncompressed, or 3% of the
> total static Guile size.

I do not know why I am in cc, having no particular knowledge of initrds;
but indeed I find your argument convincing, assuming you have tested to
boot into the resulting system.

Andreas





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy.
  2024-09-16 11:53 ` Andreas Enge
@ 2024-09-16 12:11   ` Tobias Geerinckx-Rice via Guix-patches via
  0 siblings, 0 replies; 4+ messages in thread
From: Tobias Geerinckx-Rice via Guix-patches via @ 2024-09-16 12:11 UTC (permalink / raw)
  To: Andreas Enge; +Cc: 73242, Ludovic Courtès

Hi Andreas,

On 16 September 2024 11:53:16 UTC, Andreas Enge <andreas@enge.fr> wrote:
>Am Sat, Sep 14, 2024 at 04:56:50AM +0200 schrieb Tobias Geerinckx-Rice:
>> If anything is ‘useless in an initrd’ it better be XML support.  As of
>> Guile 3.0.9, removing it saves 1418K bytes uncompressed, or 3% of the
>> total static Guile size.
>
>I do not know why I am in cc, having no particular knowledge of initrds;

Because you foolishly volunteered for the 'core packages' team covering (gnu packages make-bootstrap).  :-)

Since you bring it up: no, %guile-static-initrd doesn't particularly belong there.  It's there only to keep MAKE-GUILE-STATIC-STRIPPED private.

In fact I'd move it to (gnu system linux-initrd) if I choose to rewrite it to opt into modules rather than out of them.  That saves more than a few megabytes more, and boots fine, at the expense of not having them available at the 'early boot REPL'.

I'll see.

>but indeed I find your argument convincing, assuming you have tested to
>boot into the resulting system.

The patch was sent from one.  Thanks!



Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy.
  2024-09-14  2:56 [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy Tobias Geerinckx-Rice via Guix-patches via
  2024-09-16 11:53 ` Andreas Enge
@ 2024-09-16 20:22 ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2024-09-16 20:22 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 73242, Andreas Enge

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> If anything is ‘useless in an initrd’ it better be XML support.  As of
> Guile 3.0.9, removing it saves 1418K bytes uncompressed, or 3% of the
> total static Guile size.
>
> * gnu/packages/make-bootstrap.scm (%guile-static-initrd): Remove sxml/.
>
> Change-Id: I592dec18c422500eca50663256586ca92df1ac37

LGTM! :-)

Ludo'.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-09-16 20:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-14  2:56 [bug#73242] [PATCH] gnu: guile-static-initrd: Remove (sxml) module hierarchy Tobias Geerinckx-Rice via Guix-patches via
2024-09-16 11:53 ` Andreas Enge
2024-09-16 12:11   ` Tobias Geerinckx-Rice via Guix-patches via
2024-09-16 20:22 ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).