From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yP9nObPwl2KZbgEAbAwnHQ (envelope-from ) for ; Thu, 02 Jun 2022 01:05:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AApJObPwl2IbSgEAauVa8A (envelope-from ) for ; Thu, 02 Jun 2022 01:05:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 814D06A99 for ; Thu, 2 Jun 2022 01:05:23 +0200 (CEST) Received: from localhost ([::1]:40962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwXOy-0007A2-TS for larch@yhetil.org; Wed, 01 Jun 2022 19:05:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwXOh-00079m-4Q for guix-patches@gnu.org; Wed, 01 Jun 2022 19:05:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58301) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwXOg-0001IN-RL for guix-patches@gnu.org; Wed, 01 Jun 2022 19:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwXOg-0005iu-Hl for guix-patches@gnu.org; Wed, 01 Jun 2022 19:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55693] [PATCH v2 2/2] gnu: Add gitlint. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Jun 2022 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55693 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brian Kubisiak , 55693@debbugs.gnu.org Received: via spool by 55693-submit@debbugs.gnu.org id=B55693.165412467921967 (code B ref 55693); Wed, 01 Jun 2022 23:05:02 +0000 Received: (at 55693) by debbugs.gnu.org; 1 Jun 2022 23:04:39 +0000 Received: from localhost ([127.0.0.1]:52198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwXOJ-0005iF-FW for submit@debbugs.gnu.org; Wed, 01 Jun 2022 19:04:39 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:42222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwXOH-0005i6-Ly for 55693@debbugs.gnu.org; Wed, 01 Jun 2022 19:04:38 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by albert.telenet-ops.be with bizsmtp id dz4b270044UW6Th06z4bNb; Thu, 02 Jun 2022 01:04:36 +0200 Message-ID: <93a6870b8289510c35c014974f9e23cd0fa32e0f.camel@telenet.be> From: Maxime Devos Date: Thu, 02 Jun 2022 01:04:30 +0200 In-Reply-To: <20220530231755.5triztiq6knsmeob@peregrine> References: <20220528235330.hz2p6hsw5qcysaqc@peregrine> <20220530231755.5triztiq6knsmeob@peregrine> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-f3V467zku4raZvcbptf/" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654124676; bh=Efwb5DZZF8kZBgml99eMWeezHbrfkKyXb396CX4SFe0=; h=Subject:From:To:Date:In-Reply-To:References; b=Bx1Sz42S76pxJ4fdVtsOBqGs+gQnNMn7UvCJDbETjF+4LcWWUUn68uEVX8QnsJ/eu G2TJoAA9l8htpVQWJm2UjG++qtvy/KhSrkFZCZ5lOO7dSypmZnIIEWZX/XLBe0pPN+ MRCBUAjXdSGeCtuTu9kqR15HpLH5vL/VJ4Z7Vd48wbSyspqcno7RNf+hnnTeIA/aTD iPDlGckmG65qAhNCWmgM8q9efwmKuhvY0vKP4Ydb46wwMZmMbWENylHfdDrXAgiGpc SGmscdyPbU7DHmLb8sLdtYdBVuR0vXqkUjyZIST7/dGoD9uwx4dx9RXLTjajV/wvnL TqY+GYKC1rs+g== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654124723; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Efwb5DZZF8kZBgml99eMWeezHbrfkKyXb396CX4SFe0=; b=upjQHxZWF7+P4JXPP8si0vHC5+y4L7fu/gB+l+BGKywHIxVKfuUtiZW9nbfFWFHiDNqotq 75+ZA3rPcH13XFvHoQmtjEgnYi21QLXAM8gpTs1Z9pvkIhU6Nd+H1VYG6nJfM4FHJe4d/K V1mgvoTILa9Klp/8ahPvNGkLqN/3FsqIbJL5UvC7cMLJ6j6tWmk8+RjBphiwKtNF+oTUXy CZd/+uIyryhwx8BqwcwQtUKKsHKyZlM3kJaJqXjthAzGn5xtTtk4mpQ9xKkj7bm1Y6jHJy K8rMkYnlODycL7jwfsyRLPYhT1S9M4vpcFimIy+qxMXPAM/g/XuIZi3dmnxsnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654124723; a=rsa-sha256; cv=none; b=Ghxr7a4m3Nj8/Eb+kGD/mFyc735V/dGgZ2VCG4JmyYLLLy398bHB1AdzXjzUxVHeQQLGZT A6H0hueS6lmyDYJCxyubpZYw2aIYxhoiRbEGZFhU8v/FFQh4otnOBYIDl/+FtXs3pK5rxv p0mzwK9iwTF3dGPn71JGsvyHBO5kbK/vSyfrBEm6P/n5IGY9GEA6FHUDKN9YtmJiEzjDlo /HF9cK+Dm1F3Hf68vhiDdAfbd6wz/OjMGcEWvLUs36H8Z9w5neo7iEnt23LeHSZBSg42ZY Ais6kivNmcsvEKUceiEkZJIdqa1Nbm4N13jXV6x5eKgDFC0U64bW2XCEV1R3rw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Bx1Sz42S; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Bx1Sz42S; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 814D06A99 X-Spam-Score: 3.87 X-Migadu-Scanner: scn1.migadu.com X-TUID: W5dNk6pR822D --=-f3V467zku4raZvcbptf/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Brian Kubisiak schreef op ma 30-05-2022 om 16:17 [-0700]: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= #t))))) Trailing #t aren't required anymore since a long time, it can be removed. > + (inputs > + `(("git" ,git) > + ("python-arrow" ,python-arrow) > + ("python-click" ,python-click) > + ("python-sh" ,python-sh))) Input labels aren't required anymore. Try running "guix style -S inputs". Also, IIUC, Hartmut Goebel would prefer not using quasiquote (`): (arguments (list #:phases #~(modify-phases [stuff] [stuff] ...))) to avoid the complicated quasiquote/unquote construct, with which I agree though it's AFAIK not (yet?) elevated to =E2=80=98official Guix style= =E2=80=99 or such. Otherwise LGTM, though I haven't looked at most of the source code of gitlint (for malware or such) or in detail at the description and synopsis (for clarity and such). Greetings, Maxime. --=-f3V467zku4raZvcbptf/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpfwfhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lUjAQCnEAIdKRLFckLY2Ex6Wm+zT55O OGM/0GXAVmbEItb0YQD7BRM4gU9QqzvLTbxZIyYOglw8sDDrz2w7eIqCjZS7MgY= =X6mn -----END PGP SIGNATURE----- --=-f3V467zku4raZvcbptf/--