From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0O2QLq1WvGMMDAAAbAwnHQ (envelope-from ) for ; Mon, 09 Jan 2023 19:02:21 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aBlVLq1WvGNpYwAAauVa8A (envelope-from ) for ; Mon, 09 Jan 2023 19:02:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1156864E9 for ; Mon, 9 Jan 2023 19:02:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEwTD-0001ff-Jm; Mon, 09 Jan 2023 13:02:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEwTC-0001fQ-Rd for guix-patches@gnu.org; Mon, 09 Jan 2023 13:02:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEwTC-0000lC-J3 for guix-patches@gnu.org; Mon, 09 Jan 2023 13:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEwTC-0004vu-6w for guix-patches@gnu.org; Mon, 09 Jan 2023 13:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60266] [PATCH] gnu: Add form. Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 Jan 2023 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60266 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Antero Mejr , 60266@debbugs.gnu.org Received: via spool by 60266-submit@debbugs.gnu.org id=B60266.167328731618949 (code B ref 60266); Mon, 09 Jan 2023 18:02:02 +0000 Received: (at 60266) by debbugs.gnu.org; 9 Jan 2023 18:01:56 +0000 Received: from localhost ([127.0.0.1]:38119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEwT5-0004vY-OA for submit@debbugs.gnu.org; Mon, 09 Jan 2023 13:01:56 -0500 Received: from mout02.posteo.de ([185.67.36.66]:55095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEwT3-0004vK-G9 for 60266@debbugs.gnu.org; Mon, 09 Jan 2023 13:01:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5A0D524040D for <60266@debbugs.gnu.org>; Mon, 9 Jan 2023 19:01:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673287307; bh=a2StSm5Ewk1VwNUH0nK/S4cMlnP7kbsNRzI9BXXn54s=; h=Subject:From:To:Date:From; b=jo5+QO/UbJg88iDR8ggXU6cKyz5FEnLwrjaEcNllcni29xSrvJ/HZixQUX5KHhWp0 seXqC4RhAupPA9VuEH3Fz8MRAA1y4pO2yvN6jWewoEL4UOW2d+imzqv2b9gL7LS+4x FkBPL0sY7mIhVhiQpq1bH5l6k8f5B963bohKK2/gVDVBncH+1uNiM/uBTIlIisH2mz Cgq+biHgcqWqOPhIpFID28KPV8RV7MzgfZQUaDQ4uzR+W6LQJSUwndIwW5vcgN8WLt GeMrnzDN78HLkBdHAkRNHDf7klvHTyz5fCStfPc7Gj7wJIn0od3zHLB+23AeBYtZB3 aeUuod/m+xMVA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NrMFz4lf9z6tnG; Mon, 9 Jan 2023 19:01:43 +0100 (CET) Message-ID: <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> From: Eric Bavier Date: Mon, 09 Jan 2023 18:01:33 +0000 In-Reply-To: <20221223011551.32708-1-antero@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fAls992NzDfjcNW52n3I" MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="jo5+QO/U"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673287341; a=rsa-sha256; cv=none; b=jeOVOaTz0EDL4vVmU1FnYmaEM4AI17mhLCB/URVAoqzeDePSHEtpvOyHIsFpPIHdoa8IV2 VhZdGp/RXbZ2nQorT16BCaZztofYSbsRY0PBrzGlKRVRrCJrXYS6f43ELAJARXkU6pS72h U1GCeCfxjDC0M9pZwl+SbeWnmHSGv5/qo7ym/EM8RDyAoW4gZ0P74i3TSRAOhWIqr9UIBg MMV+AkwB0AkMQlOr7LyyM9PkVaqBofVWc9QT5dqaGhZ1mZU0Agw495FH0VhN2YVxTcSMaP NRjp2spb4i7GKX3cbSqiOfl155ASoq17FYu6eLHjihU/H242n8Ops3NV6FbN9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673287341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7pXXOch1RHpG4bJIQcXqLbT1c0DN0g4apumjOy0ws00=; b=DyxGj0pQRP4Y9Fcb2NVJiC5CIzgTGxV1imfIDGGEste7zVk3ipIhBcSZV7m+lrSRDVtb+B E+Hl9Wfj+G+HVpxxpQG4PKSNscHBOOXl8XKUbbyFdi/E1u+x21v3vGoISovUiuhzz+G1Bk 9D6I3FHIfhlczAh9yE1SszE+vmXAe/aCzOMxA+tDzQ4ToSETrWk8XdtSzLTOhEl3ufCqXe afP/hjAKUkP+BHjUG9qS9bixyfCOUgwo1SKbAJiIC/uE3kyPOUIIZEzdo6EBixeXiW4nmm ihdyyC+CTu1SCeZrRI/GwpnTlcoJBwhu+9p+I+degGCBCSerMLoCXhlP6kI+Ww== X-Migadu-Queue-Id: 1156864E9 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b="jo5+QO/U"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) X-Migadu-Spam-Score: -4.78 X-Spam-Score: -4.78 X-TUID: NrC7uz4gMDRJ --=-fAls992NzDfjcNW52n3I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Antero, Thank you for the patch. Sorry for the delayed reply, holidays and such. I was able to apply your patch and build a form package. A few comments: On Fri, 2022-12-23 at 01:15 +0000, Antero Mejr wrote: > * gnu/packages/maths.scm (form): New variable. > --- > x86_64 only due to test failures on other platforms. Developers > say other platforms are not "tier 1" supported: > https://github.com/vermaseren/form/issues/426 This may be better as a comment near the `supported-systems` field, along with a short summary of which tests fail on other systems. >=20 > gnu/packages/maths.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) >=20 > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index 050450e12c..08ddd2ecb4 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -8161,3 +8161,58 @@ (define-public optizelle > provided for applications written in C++ and Python. Parallel > computation is supported via MPI.") > (license license:bsd-2)))) > + > +(define-public form > + (let ((commit "28e15eaf0856a0a012795298d6a4b570e764a8b1") This commit is downstream from the 4.3.0 release, so we should include in a comment the rationale for not using just the 4.3.0 release tarball. > + (revision "0")) > + (package > + (name "form") > + (version (git-version "4.3.0" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/vermaseren/form") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "04i932lqwng2hmknvai1gmmb5j17rwrhlj11nr96w9bmj4sq736x"= )) > + (modules '((guix build utils))) > + (snippet #~(substitute* "check/examples.frm" > + (("#pend_if valgrind\\?") > + "#pend_if 0"))))) This snippet appears to be related to the specifics of this package build? E.g. if someone were to grab the source with `guix build -S form`, they would not be able to have valgrind support, correct? If that's the case, perhaps it would be better to apply this substitution in a build phase. > + (build-system gnu-build-system) > + (native-inputs (list autoconf automake doxygen ruby)) > + (inputs (list bash openmpi)) > + (arguments > + (list #:configure-flags #~(list "--enable-parform") For some other maths packages that have both a serial and MPI versions, we've usually provided two packages. See e.g. `petsc` and `petsc- openmpi`. This can be useful if someone does not need a full MPI- capable version of form, and the separation is easily achieved. Also, I see the default compilation flags include `-march=3Dnative`, which will most likely cause a problem with build farm substitutes or `guix challenge`. Could you figure out have to override these flags? Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc.=20 Bonus points for enabling a "tunable" package (c.f. "Package Transformation Options"). > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-hardcoded-path > + (lambda _ > + (substitute* "sources/extcmd.c" > + (("/bin/sh") > + (string-append #$(this-package-input "b= ash") > + "/bin/sh"))))) > + (add-after 'build 'build-doxygen > + (lambda _ > + (with-directory-excursion "doc/doxygen" > + (invoke "make" "html")))) > + (add-before 'check 'mpi-setup > + #$%openmpi-setup) > + (add-after 'install 'install-docs > + (lambda _ > + (let ((doc (string-append #$output "/share= /doc/" > + #$name "-" #$ver= sion > + "/html"))) > + (mkdir-p doc) > + (copy-recursively "doc/doxygen/html" doc= ))))))) > + (home-page "https://www.nikhef.nl/~form/maindir/maindir.html") Maybe we should use https://www.nikhef.nl/~form/ instead? This is the URL specified in the included manpage. > + (synopsis "Symbolic manipulation system for very big expressions") > + (description > + "FORM is a symbolic manipulation system. It reads symbolic expre= ssions > +from files and executes symbolic/algebraic transformations upon them. T= he > +answers are returned in a textual mathematical representation. The size= of the > +considered expressions in FORM is only limited by the available disk spa= ce and > +not by the available RAM.") > + (supported-systems '("x86_64-linux")) > + (license license:gpl3+)))) Thanks, `~Eric --=-fAls992NzDfjcNW52n3I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJGBAABCgAwFiEEo6S0GQB0CHyn3laYvEXKZ+L40AcFAmO8Vn0SHGJhdmllckBw b3N0ZW8ubmV0AAoJELxFymfi+NAHUpwQAJwkC27XBHydtH34AqDU7FgE6q5p75sY JaHfs+JrCEzU8nQqfMx0HErVokmQ1BL4pYaWoXxZwcKLspTsoFmVtIFb00ZUZar0 /jK5nbzjdpCruq+3VwX4yGHooe4KL+whsc1XpbDPrdemKa0NinJZNDRqFE1KptHy mBm9fVDjUojPdrbWe/Fk/e8Hn65+zz9Ue/n4prPK2DPv73Kryh2WoC+8fYeAjPU/ W95ozHDLneQzsbmE2W9ofgwtJpxZu0N3tQti++9QblYjoCwH7YCCM8l04FkMjNKl 9PoiCOlrv3Ak33MmiRm2qZ9CEq2vu+JFdXMcdwTU8wXwyWzCVH285IOft6HH8FE0 Y7eIKO+7YaojUpRE692ziRLMvTiMTtWbW5lo5o5Ge3yyXz7a22yAcO0VOWG66EeG vvuKsdwXMf+r2YAhaUkZo2Z5sYt1JEFl+ESMmJMSGQowW/QagVTJTaZTFEeO6Ag4 EM3z/e0lQTNKCwlTK+u1IfQBx0vFxiKsAUs2ySx6EPxdCJPeEZRe9iJJu7vfuP1i QrYNhZ/JeQSZ09wJX5OugnqwpJUNxUoRctwxO2S0t6576nvYAUB1uErdXSjcsVSJ EFhg0Sv5MsSsOCjcKNzPOOevT+fX14Llz1OtREUOfP4X3Cvnx+FWaZhZ5L1FNRsD 8seOIr9ABapd =0vQ5 -----END PGP SIGNATURE----- --=-fAls992NzDfjcNW52n3I--