unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: 48120@debbugs.gnu.org
Subject: [bug#48120] [PATCH] etc: committer: Read #~, #$ and #+ correctly.
Date: Thu, 17 Jun 2021 15:36:02 +0200	[thread overview]
Message-ID: <927c6dc244aea404128d54055663409bd7f1e7e1.camel@telenet.be> (raw)
In-Reply-To: <cb4614f9e7fde30068113fc409b28fdda2882854.camel@telenet.be>


[-- Attachment #1.1: Type: text/plain, Size: 201 bytes --]

Hi Guix,

I haven't gotten around to making a new revision
of the whole patch series yet, but I want to note
that this individual patch is simple and functions
on its own.

Greetings,
Maxime.

[-- Attachment #1.2: Type: text/x-patch, Size: 1090 bytes --]

From 3f6404ab0367d91bb665748a8eab17976e9a2c11 Mon Sep 17 00:00:00 2001
From: Maxime Devos <maximedevos@telenet.be>
Date: Fri, 30 Apr 2021 22:53:12 +0200
Subject: [PATCH] etc: committer: Read #~, #$ and #+ correctly.

Some package definitions use G-expressions (see, e.g., chez-scheme).
Import (guix gexp) such that Guile knows how to read those.
Otherwise, an exception such as the following might be raised:

ERROR: In procedure read:
In procedure scm_lreadr: gnu/services/networking.scm:480:16: Unknown # object: #\~

* etc/committer.scm.in: Import (guix gexp).
---
 etc/committer.scm.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/etc/committer.scm.in b/etc/committer.scm.in
index 1f19ccfd6d..b61121bc4b 100755
--- a/etc/committer.scm.in
+++ b/etc/committer.scm.in
@@ -36,7 +36,8 @@
         (ice-9 popen)
         (ice-9 match)
         (ice-9 rdelim)
-        (ice-9 textual-ports))
+        (ice-9 textual-ports)
+        (guix gexp))
 
 (define (read-excursion port)
   "Read an expression from PORT and reset the port position before returning
-- 
2.32.0


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-06-17 13:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 14:36 [bug#48120] [PATCH]: Teach etc/committer.scm.in some stuff Maxime Devos
2021-05-06  7:50 ` [bug#48120] [PATCH] " Maxime Devos
2021-05-09 18:34   ` Xinglu Chen
2022-05-22  3:33   ` [bug#48120] [PATCH]: " Maxim Cournoyer
2022-05-22  9:04     ` Maxime Devos
2022-05-22 13:13       ` Maxim Cournoyer
2021-06-17 13:36 ` Maxime Devos [this message]
2021-08-07 12:06 ` Ricardo Wurmus
2021-11-22 23:07 ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=927c6dc244aea404128d54055663409bd7f1e7e1.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=48120@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).