From: Kyle Andrews <kyle.c.andrews@gmail.com>
To: 36805@debbugs.gnu.org
Subject: [bug#36805] Small patch to remove TODO for (@@ (guix build-system r) bioconductor-uri)
Date: Wed, 24 Jul 2019 23:13:46 -0400 [thread overview]
Message-ID: <92658660d50853e4eec92f536d8b3eb720aab911.camel@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
Hi,
I am a heavy R user trying to get my feet wet with guix. Here is a
patch to remove the hard-coded bioconductor release by adding an
optional 3rd argument to the function with an appropriate default
value. I hope this is helpful.
Regards,
Kyle Andrews
[-- Attachment #2: 0001-NAME-and-VERSION-are-not-enough-for-Bioconductor-URI.patch --]
[-- Type: text/x-patch, Size: 1577 bytes --]
From 729e621cc2175864937b6a4a3e754bd128ac9056 Mon Sep 17 00:00:00 2001
From: Kyle Andrews <kyle.c.andrews@gmail.com>
Date: Wed, 24 Jul 2019 22:51:20 -0400
Subject: [PATCH] NAME and VERSION are not enough for Bioconductor URI. Need
RELEASE.
---
guix/build-system/r.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/guix/build-system/r.scm b/guix/build-system/r.scm
index fbf08d3aa7..93b2f2f14f 100644
--- a/guix/build-system/r.scm
+++ b/guix/build-system/r.scm
@@ -47,13 +47,14 @@ available via the first URI, the second URI points to the archived version."
(string-append "mirror://cran/src/contrib/Archive/"
name "/" name "_" version ".tar.gz")))
-(define (bioconductor-uri name version)
+(define* (bioconductor-uri name version
+ #:optional
+ (release (@@ (guix import cran) %bioconductor-version)))
"Return a URI string for the R package archive on Bioconductor for the
-release corresponding to NAME and VERSION."
+release corresponding to NAME, package VERSION, and Bioconductor RELEASE."
(list (string-append "https://bioconductor.org/packages/release/bioc/src/contrib/"
name "_" version ".tar.gz")
- (string-append "https://bioconductor.org/packages/"
- (@@ (guix import cran) %bioconductor-version)
+ (string-append "https://bioconductor.org/packages/" release
"/bioc/src/contrib/Archive/"
name "_" version ".tar.gz")))
--
2.22.0
next reply other threads:[~2019-07-25 3:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:13 Kyle Andrews [this message]
2019-07-25 13:48 ` [bug#36805] Small patch to remove TODO for (@@ (guix build-system r) bioconductor-uri) zimoun
2019-07-26 4:17 ` Kyle Andrews
2019-07-26 9:46 ` Ricardo Wurmus
2019-09-14 21:04 ` [bug#37404] add herbstluftwm window manager package (v0.7.2) to guix (gnu/packages/wm.scm) Kyle Andrews
2019-09-16 8:57 ` bug#37404: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92658660d50853e4eec92f536d8b3eb720aab911.camel@gmail.com \
--to=kyle.c.andrews@gmail.com \
--cc=36805@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).