* [bug#72572] [PATCH] gnu: Add elinks.
@ 2024-08-11 9:29 Adam Faiz via Guix-patches via
2024-08-15 16:57 ` [bug#72572] QA review for 72572 Nicolas Graves via Guix-patches via
2024-08-17 3:28 ` [bug#72572] [PATCH] gnu: Add elinks Zheng Junjie
0 siblings, 2 replies; 3+ messages in thread
From: Adam Faiz via Guix-patches via @ 2024-08-11 9:29 UTC (permalink / raw)
To: 72572
From e5f84076855745ba103053933beafbd75a4c68d2 Mon Sep 17 00:00:00 2001
Message-ID: <e5f84076855745ba103053933beafbd75a4c68d2.1723368423.git.adam.faiz@disroot.org>
From: AwesomeAdam54321 <adam.faiz@disroot.org>
Date: Sun, 11 Aug 2024 17:26:37 +0800
Subject: [PATCH] gnu: Add elinks.
* gnu/packages/web-browsers.scm (elinks): New variable.
---
gnu/packages/web-browsers.scm | 57 +++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 4a2b28916d..adb9444dac 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -97,6 +97,7 @@ (define-module (gnu packages web-browsers)
#:use-module (gnu packages python-xyz)
#:use-module (gnu packages qt)
#:use-module (gnu packages readline)
+ #:use-module (gnu packages regex)
#:use-module (gnu packages sdl)
#:use-module (gnu packages sqlite)
#:use-module (gnu packages suckless)
@@ -105,6 +106,7 @@ (define-module (gnu packages web-browsers)
#:use-module (gnu packages tls)
#:use-module (gnu packages web)
#:use-module (gnu packages webkit)
+ #:use-module (gnu packages xml)
#:use-module (gnu packages xorg))
(define-public midori
@@ -218,6 +220,61 @@ (define-public links
;; linking of the program with openssl.
(license license:gpl1+)))
+(define-public elinks
+ (package
+ (name "elinks")
+ (version "0.17.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/rkd77/elinks")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0ij738y1ig2cdfdim85al9iyqz6cwrfac0zg0mqrqj9af0q25r95"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:configure-flags
+ #~(list "--enable-finger"
+ "--enable-html-highlight"
+ "--enable-gopher"
+ "--enable-gemini"
+ "--enable-cgi"
+ "--enable-bittorrent"
+ "--enable-nntp"
+ "--enable-256-colors"
+ "--enable-true-color"
+ "--with-brotli"
+ "--with-lzma"
+ "--with-libev")))
+ (native-inputs
+ (list autoconf
+ automake
+ gnu-gettext
+ pkg-config))
+ (inputs
+ (list brotli
+ bzip2
+ expat
+ gnutls
+ gpm
+ libev
+ libgcrypt
+ libidn
+ lua
+ tre
+ xz
+ zlib))
+ (synopsis "Advanced text mode web browser")
+ (description "ELinks is a feature-rich program for browsing the web
+in text mode. It can render both frames and tables, is highly customisable
+and can be extended via Lua scripts. It is like an enhanced Lynx and Links.")
+ (home-page "http://elinks.cz/")
+ (license license:gpl2+)))
+
(define-public luakit
(package
(name "luakit")
base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#72572] QA review for 72572
2024-08-11 9:29 [bug#72572] [PATCH] gnu: Add elinks Adam Faiz via Guix-patches via
@ 2024-08-15 16:57 ` Nicolas Graves via Guix-patches via
2024-08-17 3:28 ` [bug#72572] [PATCH] gnu: Add elinks Zheng Junjie
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Graves via Guix-patches via @ 2024-08-15 16:57 UTC (permalink / raw)
To: control, 72572; +Cc: Adam Faiz
user guix
usertag 72572 + reviewed-looks-good
thanks
Guix QA review form submission:
Hi Adam,
Thanks for this package, it builds deterministically and no lints. I just have a doubt over the license given both the description that it's GPVv2 and not later (so license:gpl2 would seem more appropriate instead of license:gpl2+). Additionnally, other licenses are evocated in this file :
https://github.com/rkd77/elinks?tab=License-1-ov-file#readme
although I'm not sure we should include all these licenses.
Items marked as checked: Lint warnings, Package builds, Commit messages, New package tests, New package synopsis and descriptions
--
Best regards,
Nicolas Graves
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#72572] [PATCH] gnu: Add elinks.
2024-08-11 9:29 [bug#72572] [PATCH] gnu: Add elinks Adam Faiz via Guix-patches via
2024-08-15 16:57 ` [bug#72572] QA review for 72572 Nicolas Graves via Guix-patches via
@ 2024-08-17 3:28 ` Zheng Junjie
1 sibling, 0 replies; 3+ messages in thread
From: Zheng Junjie @ 2024-08-17 3:28 UTC (permalink / raw)
To: 72572; +Cc: adam.faiz
[-- Attachment #1: Type: text/plain, Size: 3482 bytes --]
Adam Faiz via Guix-patches via <guix-patches@gnu.org> writes:
> From e5f84076855745ba103053933beafbd75a4c68d2 Mon Sep 17 00:00:00 2001
> Message-ID: <e5f84076855745ba103053933beafbd75a4c68d2.1723368423.git.adam.faiz@disroot.org>
> From: AwesomeAdam54321 <adam.faiz@disroot.org>
> Date: Sun, 11 Aug 2024 17:26:37 +0800
> Subject: [PATCH] gnu: Add elinks.
>
> * gnu/packages/web-browsers.scm (elinks): New variable.
> ---
> gnu/packages/web-browsers.scm | 57 +++++++++++++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index 4a2b28916d..adb9444dac 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -97,6 +97,7 @@ (define-module (gnu packages web-browsers)
> #:use-module (gnu packages python-xyz)
> #:use-module (gnu packages qt)
> #:use-module (gnu packages readline)
> + #:use-module (gnu packages regex)
> #:use-module (gnu packages sdl)
> #:use-module (gnu packages sqlite)
> #:use-module (gnu packages suckless)
> @@ -105,6 +106,7 @@ (define-module (gnu packages web-browsers)
> #:use-module (gnu packages tls)
> #:use-module (gnu packages web)
> #:use-module (gnu packages webkit)
> + #:use-module (gnu packages xml)
> #:use-module (gnu packages xorg))
>
> (define-public midori
> @@ -218,6 +220,61 @@ (define-public links
> ;; linking of the program with openssl.
> (license license:gpl1+)))
>
> +(define-public elinks
> + (package
> + (name "elinks")
> + (version "0.17.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/rkd77/elinks")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0ij738y1ig2cdfdim85al9iyqz6cwrfac0zg0mqrqj9af0q25r95"))))
> + (build-system gnu-build-system)
can you switch to meson-build-system? I think it's better this way.
> + (arguments
> + (list
> + #:configure-flags
> + #~(list "--enable-finger"
> + "--enable-html-highlight"
> + "--enable-gopher"
> + "--enable-gemini"
> + "--enable-cgi"
> + "--enable-bittorrent"
> + "--enable-nntp"
> + "--enable-256-colors"
> + "--enable-true-color"
> + "--with-brotli"
> + "--with-lzma"
> + "--with-libev")))
> + (native-inputs
> + (list autoconf
> + automake
> + gnu-gettext
> + pkg-config))
> + (inputs
> + (list brotli
> + bzip2
> + expat
> + gnutls
> + gpm
> + libev
> + libgcrypt
> + libidn
> + lua
> + tre
> + xz
> + zlib))
> + (synopsis "Advanced text mode web browser")
> + (description "ELinks is a feature-rich program for browsing the web
> +in text mode. It can render both frames and tables, is highly customisable
> +and can be extended via Lua scripts. It is like an enhanced Lynx and Links.")
> + (home-page "http://elinks.cz/")
> + (license license:gpl2+)))
> +
> (define-public luakit
> (package
> (name "luakit")
>
> base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-17 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-11 9:29 [bug#72572] [PATCH] gnu: Add elinks Adam Faiz via Guix-patches via
2024-08-15 16:57 ` [bug#72572] QA review for 72572 Nicolas Graves via Guix-patches via
2024-08-17 3:28 ` [bug#72572] [PATCH] gnu: Add elinks Zheng Junjie
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).