From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2MpUHFNE2mBHAgEAgWs5BA (envelope-from ) for ; Mon, 28 Jun 2021 23:51:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eH+oFFNE2mCbJwAA1q6Kng (envelope-from ) for ; Mon, 28 Jun 2021 21:51:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 104FB129DE for ; Mon, 28 Jun 2021 23:51:15 +0200 (CEST) Received: from localhost ([::1]:55838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxz9u-0006x0-1X for larch@yhetil.org; Mon, 28 Jun 2021 17:51:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxz9m-0006wm-Gp for guix-patches@gnu.org; Mon, 28 Jun 2021 17:51:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxz9i-0003vk-8A for guix-patches@gnu.org; Mon, 28 Jun 2021 17:51:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxz9i-0001bm-1W for guix-patches@gnu.org; Mon, 28 Jun 2021 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49170] [PATCH v2]: gnu: Add python-fire Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Jun 2021 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49170 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 49170@debbugs.gnu.org, =?UTF-8?Q?=D8=AF=D8=A7=D9=86=DB=8C=D8=A7=D9=84_?= =?UTF-8?Q?=D8=A8=D9=87=D8=B2=D8=A7=D8=AF=DB=8C?= Received: via spool by 49170-submit@debbugs.gnu.org id=B49170.16249170526166 (code B ref 49170); Mon, 28 Jun 2021 21:51:01 +0000 Received: (at 49170) by debbugs.gnu.org; 28 Jun 2021 21:50:52 +0000 Received: from localhost ([127.0.0.1]:53218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxz9Y-0001bO-8s for submit@debbugs.gnu.org; Mon, 28 Jun 2021 17:50:52 -0400 Received: from out1.migadu.com ([91.121.223.63]:39604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxz9T-0001bC-SJ for 49170@debbugs.gnu.org; Mon, 28 Jun 2021 17:50:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; s=key1; t=1624917046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d5Qe3wqB0MbTDK2muUdjdvqkUEJcth2gdwelx/wqryY=; b=XIiwlztv9bbiEOdAAvcB4pQ9D9Iwy+kY2jbrPlbh+COw7q9dxsidZVOSn+B+1FVNMJU51I +WUj11t0Q00EK/8T5ErwN+PsQYf0a2jE/La6q7cf/lB2ZqIgLyZo+VV7sbf7EBxo0STTbq eg7pCbYIiyynGjZo+70frKy1FWRDM0NPgCuIhb4wUZUXPcJaTUQmc/2HWuGBkM4aTy5j0j e5Oi1uPSz8PvTt+jBpern595UmjCTvLjNO6t+T8Ttvvcj2MQxdeVCiE5snOAv/p3Tuugmg gTHtOhH8I+mfECAE5JwaX63vuOX7ovDDhL8rXmLZvAInRUOqd29G2K+yIg7FJw== References: <20210622133326.346547-1-dani.behzi@ubuntu.com> <6F62A6C8-CD81-49A0-BCC1-E1F733B31A61@ubuntu.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <9050ffe5-22a9-066b-7acd-428118d6e7b5@raghavgururajan.name> Date: Mon, 28 Jun 2021 17:50:44 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N2uEEzWCWjxs0vXn45AuaLExl4KemhdyC" X-Migadu-Auth-User: rg@raghavgururajan.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Raghav Gururajan X-ACL-Warn: , Raghav Gururajan via Guix-patches From: Raghav Gururajan via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624917075; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=d5Qe3wqB0MbTDK2muUdjdvqkUEJcth2gdwelx/wqryY=; b=Cg7WAlAqjR71gccqhpVPS4Pe78IEecVGVItp+0ANrq2XCkeJZy7DSlhLKXknwLnIMMuSaQ 9Ojt8Jh18orkuHuVFzze54bNxK6QbDvocpDgrskJob1Z31cClaNne4H8peNKhzHtALCm9E GICAm8g+i90BHeGZAqhUNWlqfDszOfBxa046LbdmhkzgTIbKFTZCw4EvlbRKg+r8B+Bpw4 WJahDJa59OXhiHYqfRIZlMk/0Ep0fQdsBKEJX6wus3b6B0hpyvALmfW4IjCIuE9qeh5AGs qd/OjcBsXWkZ1aOk4D9YjTgnIB30og+KKJNEwEs3RnJ27gqlUkOu4SZerlKGXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624917075; a=rsa-sha256; cv=none; b=ascftYMqBJKZvmM3M4mvveO11xfYWW+dT8RooSsNglnDApHSlIjDB49pDq82btKq49KpRU XhSTtXHj6Nl+ua3jWGKewv+FnpFzk8U+/HjelnL/FZBKE6rhRv4iLBvrw46imiNPaAIH7p LxjsKRUuJZjC3gamldF7vczl/RhQ2oJtiLMIIWoTgkYRGadCkZUPYGbR9CFUoGaQ/y8a/j HQlJNvy8u/LF98B9/Y4TNPtAVKMDyXzIzRrvtFqEFPvyJDm+iaLGCkOnuUtgCpqjKLrybU khu6vwqOU5qpnc52perrnyMIYDwJ3D1UoT2TKyj0mOqV3ZK5oU4tgYBgAt1U1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=XIiwlztv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=XIiwlztv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 104FB129DE X-Spam-Score: -5.02 X-Migadu-Scanner: scn1.migadu.com X-TUID: vrxc8KW1kiQM This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N2uEEzWCWjxs0vXn45AuaLExl4KemhdyC Content-Type: multipart/mixed; boundary="o0WSf6jwTz7dlfr976Ixkg96rvM5i1z4K"; protected-headers="v1" From: Raghav Gururajan To: Maxime Devos Cc: =?UTF-8?B?2K/Yp9mG24zYp9mEINio2YfYstin2K/bjA==?= , 49170@debbugs.gnu.org Message-ID: <9050ffe5-22a9-066b-7acd-428118d6e7b5@raghavgururajan.name> Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire References: <20210622133326.346547-1-dani.behzi@ubuntu.com> <6F62A6C8-CD81-49A0-BCC1-E1F733B31A61@ubuntu.com> In-Reply-To: --o0WSf6jwTz7dlfr976Ixkg96rvM5i1z4K Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-CA Content-Transfer-Encoding: quoted-printable Hi Maxim! > I'm a bit late, as this has already been merged, > but this should have been something like: >=20 >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + (invoke "pytest"))))))) Ah my bad to miss it. Thanks for catching it. > That way, tests can be disabled with "--without-tests". > Try "./pre-inst-env guix build pytest --without-tests=3Dpytests". > Respecting #:tests? can also be important for cross-compilation. >=20 > Could you send a follow-up patch, or could someone directly > commit such a change? I pushed as e61874a598. Regards, RG. --o0WSf6jwTz7dlfr976Ixkg96rvM5i1z4K-- --N2uEEzWCWjxs0vXn45AuaLExl4KemhdyC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYNpENAUDAAAAAAAKCRBfWBZkf4vlUWis AQDmeBPlpeE4/CiJphNvKoyfR5WOPNZiJ8bLK0dcoP3nnAEAt7lgKgYkgja5W+hcAAd8qt4RpijW OTd3//JpWzet2gM= =xmw/ -----END PGP SIGNATURE----- --N2uEEzWCWjxs0vXn45AuaLExl4KemhdyC--