From: Leo Famulari <leo@famulari.name>
To: 30362@debbugs.gnu.org
Subject: [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2.
Date: Mon, 5 Feb 2018 17:44:58 -0500 [thread overview]
Message-ID: <8e97c3ee870379f4c7ff5582b48bb814c949ccf6.1517870696.git.leo@famulari.name> (raw)
* gnu/packages/webkit.scm (webkitgtk-2.4): Remove variable.
(webkitgtk/gtk+-2): Move the package to ...
* gnu/packages/gnucash.scm: ... here, and make it private.
---
gnu/packages/gnucash.scm | 40 ++++++++++++++++++++++++++++++++++++++++
gnu/packages/webkit.scm | 47 -----------------------------------------------
2 files changed, 40 insertions(+), 47 deletions(-)
diff --git a/gnu/packages/gnucash.scm b/gnu/packages/gnucash.scm
index 25200e3f9..ee97790e4 100644
--- a/gnu/packages/gnucash.scm
+++ b/gnu/packages/gnucash.scm
@@ -28,8 +28,10 @@
#:use-module (guix build-system glib-or-gtk)
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
+ #:use-module (gnu packages base)
#:use-module (gnu packages docbook)
#:use-module (gnu packages documentation)
+ #:use-module (gnu packages flex)
#:use-module (gnu packages gnome)
#:use-module (gnu packages gnupg)
#:use-module (gnu packages glib)
@@ -244,3 +246,41 @@ OFX DirectConnect, YellowNet, GeldKarte, and DTAUS discs are currently
supported. AqBanking is used by GnuCash, KMyMoney, and QBankManager.")
;; AqBanking is licensed under the GPLv2 or GPLv3
(license (list license:gpl2 license:gpl3))))
+
+;; Latest release of the stable 2.4 series, with WebKit1 support. Also the last
+;; GTK+2 port. This package is unmaintained upstream and not safe to use with
+;; untrusted input. However, it is still required by GnuCash.
+;; TODO Remove this package once GnuCash has been updated.
+(define webkitgtk/gtk+-2
+ (package (inherit webkitgtk)
+ (name "webkitgtk-gtk2")
+ (version "2.4.11")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://www.webkitgtk.org/releases/"
+ "webkitgtk-" version ".tar.xz"))
+ (sha256
+ (base32
+ "1xsvnvyvlywwyf6m9ainpsg87jkxjmd37q6zgz9cxb7v3c2ym2jq"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; no tests
+ ;; FIXME: Disabling parallel building is a quick hack to avoid the
+ ;; failure described in
+ ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
+ ;; A more structural fix is needed.
+ #:parallel-build? #f
+ #:configure-flags
+ '("--enable-webkit2=no"
+ "--with-gtk=2.0")
+ #:phases (modify-phases %standard-phases
+ (add-after
+ 'unpack 'set-gcc
+ (lambda _ (setenv "CC" "gcc") #t)))))
+ (native-inputs
+ `(("flex" ,flex)
+ ("which" ,which)
+ ,@(package-native-inputs webkitgtk)))
+ (propagated-inputs
+ `(("gtk+-2" ,gtk+-2)
+ ("libsoup" ,libsoup)))))
diff --git a/gnu/packages/webkit.scm b/gnu/packages/webkit.scm
index 340221640..c08ba9176 100644
--- a/gnu/packages/webkit.scm
+++ b/gnu/packages/webkit.scm
@@ -142,50 +142,3 @@ HTML/CSS applications to full-fledged web browsers.")
license:lgpl2.1+
license:bsd-2
license:bsd-3))))
-
-;; Latest release of the stable 2.4 series, with WebKit1 support.
-(define-public webkitgtk-2.4
- (package (inherit webkitgtk)
- (name "webkitgtk")
- (version "2.4.11")
- (source (origin
- (method url-fetch)
- (uri (string-append "http://www.webkitgtk.org/releases/"
- name "-" version ".tar.xz"))
- (sha256
- (base32
- "1xsvnvyvlywwyf6m9ainpsg87jkxjmd37q6zgz9cxb7v3c2ym2jq"))))
- (build-system gnu-build-system)
- (arguments
- '(#:tests? #f ; no tests
- ;; FIXME: Disabling parallel building is a quick hack to avoid the
- ;; failure described in
- ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
- ;; A more structural fix is needed.
- #:parallel-build? #f
- #:phases (modify-phases %standard-phases
- (add-after
- 'unpack 'set-gcc
- (lambda _ (setenv "CC" "gcc") #t)))))
- (native-inputs
- `(("flex" ,flex)
- ("which" ,which)
- ,@(package-native-inputs webkitgtk)))))
-
-;; Last GTK+2 port, required by GnuCash.
-(define-public webkitgtk/gtk+-2
- (package (inherit webkitgtk-2.4)
- (name "webkitgtk-gtk2")
- (arguments
- `(;; FIXME: Disabling parallel building is a quick hack to avoid the
- ;; failure described in
- ;; https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00837.html
- ;; A more structural fix is needed.
- #:parallel-build? #f
- #:configure-flags
- '("--enable-webkit2=no"
- "--with-gtk=2.0")
- ,@(package-arguments webkitgtk-2.4)))
- (propagated-inputs
- `(("gtk+-2" ,gtk+-2)
- ("libsoup" ,libsoup)))))
--
2.16.1
next reply other threads:[~2018-02-05 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 22:44 Leo Famulari [this message]
2018-02-06 7:51 ` [bug#30362] [PATCH] gnu: Don't export GnuCash's webkitgtk-gtk2 Danny Milosavljevic
2018-04-23 12:59 ` Ludovic Courtès
2018-06-09 5:18 ` Chris Marusich
2018-06-10 5:04 ` bug#30362: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e97c3ee870379f4c7ff5582b48bb814c949ccf6.1517870696.git.leo@famulari.name \
--to=leo@famulari.name \
--cc=30362@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).