From: Andrew Miloradovsky <andrew@interpretmath.pw>
To: Brett Gilio <brettg@posteo.net>
Cc: 38509@debbugs.gnu.org
Subject: [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0
Date: Sat, 7 Dec 2019 13:31:28 +0000 [thread overview]
Message-ID: <8e8894cf-1ab3-374c-0444-70552ed425f3@interpretmath.pw> (raw)
In-Reply-To: <878snoor4q.fsf@posteo.net>
Hi Brett,
WRT the differences, it seems to be mostly fixes and refactoring:
- https://github.com/libuv/libuv/tree/v1.34.0
WRT the failed tests, it is due to treating EAGAIN as the failure:
- https://github.com/libuv/libuv/issues/2531
Not sure how to properly fix it, fixing the tests themselves is
non-trivial, and retrying several more times likely won't work either.
On 12/7/19 1:34 AM, Brett Gilio wrote:
> Brett Gilio <brettg@posteo.net> writes:
>
>> Andrew Miloradovsky <andrew@interpretmath.pw> writes:
>>
>>> - (arguments
>>> - '(;; XXX: Some tests want /dev/tty, attempt to make connections, etc.
>>> - #:tests? #f))
>>> + (arguments '(#:tests? #f))
>>> + ;; tests 122-124 (getnameinfo_basic_ip*) fail
>>> + ;; https://github.com/libuv/libuv/issues/2531
>> Hi Andrew,
>>
>> Thank you for your submission. I have some questions before we go
>> forward with this patch. First, I'd like to note that this change would
>> trigger a huge rebuild of thousands of dependent packages.
>>
>> brettg@oryx ~/Repos/guix$ ./pre-inst-env guix refresh -l libuv
>> Building the following 2067 packages would ensure 5397 dependent packages are rebuilt:
>>
>> That said, is there some particular functionality or security that is
>> provided with this patch? If so, it would be great if you could
>> elaborate on that in the Git sub-header of the commit message.
>>
>> Since this patch would trigger such a massive rebuild it will need to go
>> to the `core-updates` branch to rest before it sees master. So having
>> that detail in the commit message will make it easier for us to see what
>> we are working with.
>>
>> Lastly, just curious if there is a way to work around the issues with
>> tests 122-124 as shown in your above snippet. I know that the tests were
>> blanket disabled before, so I am just curious if there is a _better_ way
>> to do this, maybe i'm wrong. If the issue is that the tests require
>> network functionality that can usually be spoofed with some
>> effort. Also, stylistically, comments not on the same line as the code
>> they are commenting usually go before the code in question.
>>
>> I hope that makes sense! Let me know if you have any questions, I am
>> happy to help.
> Actually, on further exploration of the `core-updates` branch, libuv is
> already at 1.34 there.
>
next prev parent reply other threads:[~2019-12-08 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 8:57 [bug#38509] [PATCH] gnu: libuv: Update to 1.34.0 Andrew Miloradovsky
2019-12-07 1:27 ` Brett Gilio
2019-12-07 1:34 ` Brett Gilio
2019-12-07 13:31 ` Andrew Miloradovsky [this message]
2020-01-27 23:20 ` bug#38509: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8894cf-1ab3-374c-0444-70552ed425f3@interpretmath.pw \
--to=andrew@interpretmath.pw \
--cc=38509@debbugs.gnu.org \
--cc=brettg@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).