From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AA9eJH+nXmSqogAASxT56A (envelope-from ) for ; Fri, 12 May 2023 22:54:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EByMJH+nXmSFQAAA9RJhRA (envelope-from ) for ; Fri, 12 May 2023 22:54:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 250CEBD09 for ; Fri, 12 May 2023 22:54:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxZm9-0001Bv-RG; Fri, 12 May 2023 16:54:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxZm7-00019f-4z for guix-patches@gnu.org; Fri, 12 May 2023 16:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxZm6-0003Xa-SA for guix-patches@gnu.org; Fri, 12 May 2023 16:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxZm6-0007NQ-OD for guix-patches@gnu.org; Fri, 12 May 2023 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63435] Add vcmi 1.2.1 to games.scm Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 May 2023 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Vagrant Cascadian , 63435@debbugs.gnu.org Cc: iyzsong@envs.net Received: via spool by 63435-submit@debbugs.gnu.org id=B63435.168392481828303 (code B ref 63435); Fri, 12 May 2023 20:54:02 +0000 Received: (at 63435) by debbugs.gnu.org; 12 May 2023 20:53:38 +0000 Received: from localhost ([127.0.0.1]:33656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxZlh-0007MQ-S1 for submit@debbugs.gnu.org; Fri, 12 May 2023 16:53:38 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:60910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxZlf-0007M6-PQ for 63435@debbugs.gnu.org; Fri, 12 May 2023 16:53:36 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-50bd875398dso15719409a12.1 for <63435@debbugs.gnu.org>; Fri, 12 May 2023 13:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683924810; x=1686516810; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bHxSWNKxZYH6U0CqkAa35B7MOdf9EKeaHtYtWHG/YPE=; b=AN1y1CJSGLOU5uxuP87JioPUBJL2iJ/4TVuUeJb0WRyjVfDknSlc3C5Nqoca31qctP rTf8aCa2LpiIyLJJsyprfnIt7V23e8wUH/cDYyECiHQ4F8EVz29SMLAj3HgM2JPxgnHf bUlFo9VmBIzgflS75jYwwIC+b2d1rXDXPv6rA/r6m5SSlmBGN/s86qPRBZNjysofunFv wmjW57HAAZuIKhPc9zk9Kr/N9o32lmlJw5Ey/VFYBTKavjMN6vd0SlHcuDov/zjQU/1k PL/FPAWrX+retWXj517EyKYkqaSCgiofMiK+hB19FG/k/IZECFhM8RBkKxn4kIfYAexH 41Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683924810; x=1686516810; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bHxSWNKxZYH6U0CqkAa35B7MOdf9EKeaHtYtWHG/YPE=; b=biK8T5qPVtP8uuAyGIJ5+WlIIZbWC9UHkm8K6I5dwRsgMA13dR485fSm1wVCfF9t5Z /Q+Vas219ycbXVfDIcRjIY4Gd6CtBYPvFn8qYhzKQxnzTINm/DZ4GXUbl/NN2vFCC1Zv muD8g/cllBZbFnESJZKDIVrYAujNn5LcWWJmaFy3wUgRkm7CtXLsQA4AfkihryMwhQbW Iu4usfSxBo4hh1DDABlW2ebegv0xt47Fn0e8AILeaCjKnXUuiirXtg0BmBZm7XZQT6Wg sWQl5gEGsN86iROmi84lNNv4KMnX62WCCzEel8VS7VugfNeZiiguP7OHKGJXjPF8eHWM X0nw== X-Gm-Message-State: AC+VfDyKwAKTfNnmAlkCW1pUSQcs/rxkM339+YWv2u0mzYj7V/hQEMMc Py+bVv6jZPGsL4CyQxkCrsXEg0nRsGZI7A== X-Google-Smtp-Source: ACHHUZ60gXwbgKPKWpnEX5v/gHHPZqPnR4yvqpQWzn+Spvvz/ueTagEjh9JXGSQeSUUAM2xeC0t+Mw== X-Received: by 2002:a17:907:86a7:b0:96a:42de:1cd5 with SMTP id qa39-20020a17090786a700b0096a42de1cd5mr9833611ejc.4.1683924809620; Fri, 12 May 2023 13:53:29 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id qo28-20020a170907213c00b00965ddf2e221sm5841773ejb.93.2023.05.12.13.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 13:53:29 -0700 (PDT) Message-ID: <8e04176d6691bdc0996fb473b56ead31be954123.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 12 May 2023 22:53:28 +0200 In-Reply-To: <87wn1em5ti.fsf@wireframe> References: <87a5yb4e41.fsf@wireframe> <51be2fdd711bf490e3a925334e571ff7871d6cbb.camel@gmail.com> <873542o7ze.fsf@wireframe> <87zg6ampqf.fsf@wireframe> <9ee9b4f47ee7c5af274074da89febdb4df9ca68d.camel@gmail.com> <87wn1em5ti.fsf@wireframe> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683924863; a=rsa-sha256; cv=none; b=KWKcFBFGZMtHABpKLLyx/oeMkguDIlfx9Dt6h5nfSFnDw3JUFcD4CmwNspOSNnHWddfs7y 6MzC7g2DjYuZusyqAlKp5ieDfegr9M6qMfUZukVDGMG900sjKwoys1X1rpIiGmKKzTbjBo 73IN482gsxbEZSPW8W9jBOQKnVnLUHzFoiBfAAAaKRlcIshf6/LTUZA3r6yyc7MTtfQqy5 p629NAkai5gEApAl7MhmA8ASYt6XhMSlmlGiBq96AT9M7rC4bHB44r8xsF8n4v8Hk/asHN i6guHR42Cud4YkXkikWtPmMgalaplJyDVtCGDOGgLZg4KVQ8ijxA/TEcvIAAMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=AN1y1CJS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683924863; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bHxSWNKxZYH6U0CqkAa35B7MOdf9EKeaHtYtWHG/YPE=; b=jdXcsKpYvHpQe87+LYKItsFqz+pmWwhd1pwaBE6CDcZuiHGM/ZpeDTIa1ZqfLKTetPn6OY m5elPFQZDOLc7O3tEMZa9xrrt7XKLus8YYXn+4rBhBoolEhQvQ1+3fuFPM+smfsrZZuq3+ 5mVk6N+Ha3TB85HwkM2CKQa9X4f/w8EP/b+IMuAVJy1uXJ9Dmc6ODYVgoE0cT/PbFFxhPU qbP1BScoyBu5qmfr4BGZ/VTwXw0mNVOldHR1X+rd1Cf2xnyk6fDz5DOPkrEM3pI8sONchl adDZC6GVO/BCMsKdqtffk0t4prJC2FUNVqxPvb3KUj8Wq2Ezb1qava/FUcBuaA== X-Migadu-Spam-Score: 0.49 X-Spam-Score: 0.49 X-Migadu-Queue-Id: 250CEBD09 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=AN1y1CJS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: E0anhf9DP1ki Am Donnerstag, dem 11.05.2023 um 23:17 -0700 schrieb Vagrant Cascadian: > On 2023-05-12, Liliana Marie Prikler wrote: > > Am Donnerstag, dem 11.05.2023 um 16:07 -0700 schrieb Vagrant > > Cascadian: > >=20 > > > +(define-public vcmi > > > +=C2=A0 (package > > > +=C2=A0=C2=A0=C2=A0 (name "vcmi") > > > +=C2=A0=C2=A0=C2=A0 (version "1.2.1") > > > +=C2=A0=C2=A0=C2=A0 (source (origin > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (method git-fetch) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (uri (git-reference > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url "https://github.com/v= cmi/vcmi") > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit version) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (recursive? #t))) > > Can we do without the recursive checkout? >=20 > There is one component still used with the recursive > checkout. ... AI/Fuzzy* I think? I do not know if it could be built > independently, but I have not seriously looked into it. fuzzylite can be taken from the system which is the preferred approach. >=20 > If tests were enabled, the googletest stuff might be needed; it was a > bit unclear to me if the googletest packaged in guix could > work. Regardless, tests are disabled upstream... so if there is a way > to only download one and not the other, I guess that would save some > bandwith. >=20 > I *think* those are the only two things pulled in. Not that it matters if we aren't building tests, but googletest can and should be unbundled. There's a fair number of packages already setting a precedent. > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (file-name (git-file-name name version)) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (sha256 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (base32 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=20 > > > "1nx3i078cxkak2ci514pf4pgi5269mp08njynsg35pin4yp3fn0p")) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 (patches (search-patches "vcmi-disable-privacy- > > > breach.patch")))) > > IIRC the reproducible builds patch is still missing, right? >=20 > The Debian package implements building man pages and documentation > outside of the upstream build system... >=20 > It did not seem worth patching something that was not used to build > anything... the reproducible builds patch(es) only apply to > documentation which is not part of the upstream build process, so I > left it out of this iteration. >=20 > That said... >=20 > Building vcmimanual.tex appears to be a one-liner, pulling in some > tex related dependencies: >=20 > =C2=A0 > https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/rules#L56 >=20 > And generating manpages used help2man and some templates debian > ships: >=20 > =C2=A0 > https://salsa.debian.org/games-team/vcmi/-/blob/master/debian/rules#L46-4= 8 >=20 > Not sure if the manpages are worth the effort, or if the manual is > worth the larger dependency tree... Fair enough, if it can be left without, let's do without (unless you really want to build the manpage). Alternatively, you can pull the inputs in, but phrase the (build-documentation ...) phase in a way that those inputs can be dropped if someone values their disk space. > > > +=C2=A0=C2=A0=C2=A0 (native-inputs (list boost > > Guix style is, like, a suggestion that can be wrong.=C2=A0 You are > > allowed > > to fight it when the result of doing so is demonstrably better. >=20 > I get that ... but I also like just being able to run guix style and > not having to make those judgement calls. Because other things guix > style may change that are a good idea and it is really difficult to > pick and choose which things to revert and which to keep over time... >=20 > There are some things I think guix style does wrong(in particular, I > always prefer one input per line to make diffs easier to read), but I > do not hold strong opinions on guile coding style and just prefer to > concede to guix style and bear with the results. >=20 > I am also not strongly opinionated (it goes both ways, I guess!)... > so for clarity, are you saying you would prefer: >=20 > =C2=A0 (native-inputs > =C2=A0=C2=A0=C2=A0 (list > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 boost > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... > or: >=20 > =C2=A0 (native-inputs > =C2=A0=C2=A0=C2=A0 (list boost > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ... >=20 > or something else? The latter. If it ever comes to needing (list on its own line you better have a good explanation for that or fix your comments so that they don't go overboard. Cheers