From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +OyvFTqWYWe8zAAA62LTzQ:P1 (envelope-from ) for ; Tue, 17 Dec 2024 15:18:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +OyvFTqWYWe8zAAA62LTzQ (envelope-from ) for ; Tue, 17 Dec 2024 16:18:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="vxs7/arb"; dkim=fail ("headers rsa verify failed") header.d=twistfold.it header.s=a1 header.b=PFnG6wLF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=twistfold.it (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1734448697; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Wkm/wwkR+lQXVdG9ZVAVOZDyFoo7AElafuajwcbkQx4=; b=kiqxNolIf68S2wIekBgooJCEBsD7cHMzqJHnUHsFvoYXREIkHeb3nMbkH42usxsOdMDOyG UBt4StktGlZ8Z4TyyHAqd5wkSKe4yEyRmQf7EySvHa6HAbKUaxYEgIEc2ECNqYVTGvzRAB s1pMr7w6xdI3w9wn/5eqKkagXIRZUYQg3zlRqjJ7IPrd50PEDOn9uvh/q5JtnCKsNphFzo U3G7h1JDRmmq8WZkAwLtW5p1g0qxLLp/zKfjcuzNnrSyUxC85H8oHNz1MkK7sCBeq54wse Qw2l10pmcQGyUDSJtSgatcSplbfJJGTh3OG2eqiFpw/FI7mMDh/7cNf8Xa2iLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="vxs7/arb"; dkim=fail ("headers rsa verify failed") header.d=twistfold.it header.s=a1 header.b=PFnG6wLF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=twistfold.it (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1734448697; a=rsa-sha256; cv=none; b=ADMRM8DsUULP2mVpjPpHLcaA2j8QU2u33RZo7w4v74+L1lL5IlQBlMX2BK314lQ5zfo5Ar ShDc2/lUmqSqoqlKN58BYsH9MdylBTBC6/u0A3mcfp2QYB4rKfBC47cqnK3P9tPrR5FJ9a /QYOW+XmnATbQgwvQpVgZ7Qbv8WrERHz0iwPVuOOBQhLeopoKutSXil2aArUTcG0mwWKaa cOj3kGxHpoApGtx/jdgkZMboBbVco+PHRDmxT0pO7EnlnTehi72ExrmNGUieToxJwJELH5 1rooo70x0ZxJkHyR9JMFRUGjWigB7KxOcKMKLfRoBJK26K1OsGRWLuz+a0qTAA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFC5C7ED92 for ; Tue, 17 Dec 2024 16:18:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNZKt-00037t-HT; Tue, 17 Dec 2024 10:18:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNZKn-00033w-GY for guix-patches@gnu.org; Tue, 17 Dec 2024 10:18:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNZKk-0003uR-DN for guix-patches@gnu.org; Tue, 17 Dec 2024 10:18:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=Wkm/wwkR+lQXVdG9ZVAVOZDyFoo7AElafuajwcbkQx4=; b=vxs7/arbXB4VTQGmB/2QHpoRY17MUj8mdLTT3RlSHe7V4aktdNEcf50SHH/cQZjk0O7JGGqPVP8My+teoa4BqQfLWxdebrTyptCx8a9wkcrpJAekd7920BMyz8meLjU5D3XHHjAvLREEgPc/Bbf1t0JvFz4NQRPBYWttkOGIYH56AN3357MmSyKLtOerH+YFthrjGL7i0tooIdRAKByn/wbOeQmbhxN33YdftyJ0awlGKhZdSgOVBkESuieBbEAZeBn6eu90/6nXVWxsDanr0vbl5AQwCnTP3mnuPDqYc/3jwgdxQysLpfYc/8pXc4/TbbdW3JVqSHl+zncR0YAbfQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNZKk-0005T2-6G for guix-patches@gnu.org; Tue, 17 Dec 2024 10:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6. Resent-From: cage Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Dec 2024 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74818 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Guillaume Le Vaillant Cc: 74818@debbugs.gnu.org Received: via spool by 74818-submit@debbugs.gnu.org id=B74818.173444866320981 (code B ref 74818); Tue, 17 Dec 2024 15:18:02 +0000 Received: (at 74818) by debbugs.gnu.org; 17 Dec 2024 15:17:43 +0000 Received: from localhost ([127.0.0.1]:59896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNZKQ-0005SK-OZ for submit@debbugs.gnu.org; Tue, 17 Dec 2024 10:17:43 -0500 Received: from smtpcmd01-g.aruba.it ([62.149.158.217]:58454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNZKK-0005Rx-Dj for 74818@debbugs.gnu.org; Tue, 17 Dec 2024 10:17:39 -0500 Received: from [192.168.1.5] ([91.197.196.229]) by Aruba Outgoing Smtp with ESMTPSA id NZKCtBRgSAQOYNZKDtax8E; Tue, 17 Dec 2024 16:17:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=twistfold.it; s=a1; t=1734448649; bh=CbFiagVdb43ZrebfSXyXGvYR/cVZWmXiKmTsS76P8m4=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=PFnG6wLFl0aKafTgcnkvQQ0gfpnp/NUuaqWAICbkE004hYhnBfQ5ZNrXACgulpbSL N/hmIv8Od3hONZUgwhg7wskDUSEVSrkfeiWeFmjf4Lp0IA1jJvW5Pm2l3Ycno4aK5E ANu7Za0v/SAuTNjM1wjqDWWNiGkLcPl8helenREx1Lp2c43hDPa4yUevZwqZobXDbV 1sSWX/reIobtZwu/boZ2JxkQbRw3RVITQw1+ldqbhtEykYvIP4fBxxZe6MEYKrYqUk O6Xw49qfIdUI8+1pvh4MNVtYs8nSZwjvBJtig5MQcvkC9d4TyBE/q6pQZmR+eE7cDV LN70+ZR1kjDxA== Message-ID: <8dd71996-a19c-42a0-9c5f-5cdf53718b89@twistfold.it> Date: Tue, 17 Dec 2024 16:17:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: <87ttb2wpkz.fsf@kitej> Content-Language: it-IT, en-US From: cage In-Reply-To: <87ttb2wpkz.fsf@kitej> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfI8nbiQyayg1OtRqI52LERUQGTV/huFVm0Wu6/rRQMsFPylJy6//cIArW2FTDvakIgrJbyBf6cbexwDRVIhz2xhwcyjQzy6vDvNkoGIx/ce55hLOjvme nuu1eaDACpKLB5miRVMTgwHvHjROESLs8u6whDrtpD4cSiLwbvC1fQdHVC4ubr4kCngFkomX7/tZE1P0WMC681NhNljkcWS+hDycupOiRXrzWeWkZFuu8CUX X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cage-dev@twistfold.it Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.83 X-Spam-Score: -3.83 X-Migadu-Queue-Id: BFC5C7ED92 X-TUID: 4Z/NxCEVqjoO On 17/12/24 11:50, Guillaume Le Vaillant wrote: > Hi. Hi, thanks for reviewing this patch! > Why did you replace the 'fix-paths' phase by propagated inputs? > We usually try to avoid propagating inputs if possible as it can > create conflicts in profiles. I was not aware of this issue, sorry! This version of the library, at runtime, tries to guess the path of a valid wish executable and, then, starts a process executing said executable, communicating with the parent process via a pipe. The `fix-path' is no more applicable as it assumes that the path to wish is hardcoded in the source code, which is not true, starting from this version of the library. Moreover leaving the `tk' dependency to `inputs' makes the library unable to guess a path for wish, leading to a crash at runtime. My changes seems to make the library works as intended but I am very open to suggestions if a better solution exists. Bye! C.