From: cage <cage-dev@twistfold.it>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: 74818@debbugs.gnu.org
Subject: [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6.
Date: Tue, 17 Dec 2024 16:17:28 +0100 [thread overview]
Message-ID: <8dd71996-a19c-42a0-9c5f-5cdf53718b89@twistfold.it> (raw)
In-Reply-To: <87ttb2wpkz.fsf@kitej>
On 17/12/24 11:50, Guillaume Le Vaillant wrote:
> Hi.
Hi, thanks for reviewing this patch!
> Why did you replace the 'fix-paths' phase by propagated inputs?
> We usually try to avoid propagating inputs if possible as it can
> create conflicts in profiles.
I was not aware of this issue, sorry! This version of the library, at
runtime, tries to guess the path of a valid wish executable and, then,
starts a process executing said executable, communicating with the
parent process via a pipe. The `fix-path' is no more applicable as it
assumes that the path to wish is hardcoded in the source code, which is
not true, starting from this version of the library. Moreover leaving
the `tk' dependency to `inputs' makes the library unable to guess a path
for wish, leading to a crash at runtime. My changes seems to make the
library works as intended but I am very open to suggestions if a better
solution exists.
Bye!
C.
next prev parent reply other threads:[~2024-12-17 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 11:16 [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6 GNU Guix Live
2024-12-17 10:50 ` Guillaume Le Vaillant
2024-12-17 15:17 ` cage [this message]
2024-12-17 19:27 ` cage
2024-12-17 19:19 ` GNU Guix Live
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dd71996-a19c-42a0-9c5f-5cdf53718b89@twistfold.it \
--to=cage-dev@twistfold.it \
--cc=74818@debbugs.gnu.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).