From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXlDR-0007Gg-FE for guix-patches@gnu.org; Fri, 14 Dec 2018 06:01:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXlDL-0000oz-19 for guix-patches@gnu.org; Fri, 14 Dec 2018 06:01:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXlDK-0000ok-SG for guix-patches@gnu.org; Fri, 14 Dec 2018 06:01:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXlDK-0000rZ-9I for guix-patches@gnu.org; Fri, 14 Dec 2018 06:01:02 -0500 Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-Message-ID: References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> Date: Fri, 14 Dec 2018 12:00:34 +0100 MIME-Version: 1.0 In-Reply-To: <87lg4se6wf.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="03hb0cKU9vFToNmBVgKxG6TkLospBTOzD" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 33598@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD Content-Type: multipart/mixed; boundary="4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> In-Reply-To: <87lg4se6wf.fsf@ambrevar.xyz> --4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 14.12.2018 11:31, Pierre Neidhardt wrote: > I am not sure sure about this. Ludovic, do we have such a thing as "so= urce > substitutes"? I have searched a little bit in my store... Looks like its not the case. After all it seems to me that this is the purpose of a source snippet. >> I also thought about this but could not find another situation where >> this was applicable. >=20 > Look for "emacs-build-system" in files other than emacs.scm. It's used= in quite > a few places. I will have a look at it. > What emacs stuff? You mean the build system? Yes. With the abstraction we could only import the function and do not need the emacs-build-system imported in modules that have nothing to do with emacs otherwise. >> Yes. Maybe we should add some reasoning to the commit message then? >> Depends on whether we just want a description of the changes in a comm= it >> message or also some reasoning if things might be unclear. >=20 > Well, the reasoning above is mostly a nit. What matters most is > - Efficiency, if it really works. > - The abstraction function. Then I will apply the changes to the function and send new patches when I am done. Unless Ludo thinks differently we probably shouldn't merge - The first two patches if they don't work like I expected them to - The last patch in its current form until the changes are implemented and we can start to use the generic function in package definitions Tim. --4po76ZHny5ZZa7VODgeQJ3CNMTe9iNHj7-- --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwTjVIACgkQ0uWPaa77 GdUtfggAry1g9oym3f8h8BmFZ0mGCWOrzlWWpgnlpdqpl3T8tWIn6AFDVs+RvZ5j kUy3Lg1SrLNe3ZeLG3Eet4na0d+Iawdm4yCm7Oy10ZMuIxmnLAkNgw4T8okgSyTi XTTtBGIdAyML9k2XNTfU9wXWA8kNjA76VI+HOH0KtzadagtdFLIoEBJsfDOxBIkh 2XbCRoR22y3HKVkQy1NV7sPcaKCboSxITl4XyHBakbLj/6rTxvTbWPUwzVURBmD1 DeVfxVxViK6Pxdaw+9KiO8AcnIB0bt26d4EeZ3fKJa4xf0HSuxdJ5YEjARWw5BB+ hvOr99IXa2Mv//s5AQas6/I/Ev3enw== =PFcr -----END PGP SIGNATURE----- --03hb0cKU9vFToNmBVgKxG6TkLospBTOzD--