From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4QpPLZo2CWF6IAAAgWs5BA (envelope-from ) for ; Tue, 03 Aug 2021 14:29:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aGJYKJo2CWEcWAAAB5/wlQ (envelope-from ) for ; Tue, 03 Aug 2021 12:29:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 518BA1E5A2 for ; Tue, 3 Aug 2021 14:29:14 +0200 (CEST) Received: from localhost ([::1]:59552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAtXl-0004Yh-CC for larch@yhetil.org; Tue, 03 Aug 2021 08:29:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAtXb-0004VF-9Q for guix-patches@gnu.org; Tue, 03 Aug 2021 08:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAtXa-0003Qs-Mp for guix-patches@gnu.org; Tue, 03 Aug 2021 08:29:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mAtXa-0001qW-Fl for guix-patches@gnu.org; Tue, 03 Aug 2021 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49828] [PATCH 05/20] build-system: minetest: Don't retain references to "bash-minimal". Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Aug 2021 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49828 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 49828@debbugs.gnu.org Received: via spool by 49828-submit@debbugs.gnu.org id=B49828.16279937247069 (code B ref 49828); Tue, 03 Aug 2021 12:29:02 +0000 Received: (at 49828) by debbugs.gnu.org; 3 Aug 2021 12:28:44 +0000 Received: from localhost ([127.0.0.1]:39987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAtXI-0001px-Gf for submit@debbugs.gnu.org; Tue, 03 Aug 2021 08:28:44 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:33296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mAtXF-0001pk-Pk for 49828@debbugs.gnu.org; Tue, 03 Aug 2021 08:28:43 -0400 Received: from nijino.local (194-118-35-216.adsl.highway.telekom.at [194.118.35.216]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GfDgV0H7Pz1LZW9; Tue, 3 Aug 2021 14:28:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GfDgV0H7Pz1LZW9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1627993718; bh=t6RDNSmDudhPqoS4WfT93ihokjKlEUKnmaNdGZwdrrc=; h=Subject:From:To:Date:In-Reply-To:References:From; b=HkEbrCnCq9GAEM917G8v58dOgcau8VaKNAV03ONiJLdEL8eNSCwNbVoAh1Z2OcfYy 4aOjYd3Sd6iW0U8Dw1skfU9+7HlmbiVkP/Lbpy44GG/R/Sug9OS0lYUAuFwvL5+zxX DmEGiEMVIOQp1Y0Mjj3amepXQw9FBKY/KIBuBA88= Message-ID: <8d13a1057f368f47eef8da538c554a379892cacc.camel@student.tugraz.at> From: Leo Prikler Date: Tue, 03 Aug 2021 14:28:37 +0200 In-Reply-To: <265c85f914757066aee6b6933ba58bf1abd2bc84.camel@telenet.be> References: <20210802155019.6122-1-maximedevos@telenet.be> <20210802155019.6122-5-maximedevos@telenet.be> <60c5062a7debff22cee27198c2548605fd7441e0.camel@student.tugraz.at> <265c85f914757066aee6b6933ba58bf1abd2bc84.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627993754; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=t6RDNSmDudhPqoS4WfT93ihokjKlEUKnmaNdGZwdrrc=; b=G6SmY3cQuB97RGArjbCHM2HsstQSAM+dlDu6D0Ly6pjN8ilhYg6V8qEMSupzjbi7YQGb0m Q6F3JL7icRM4g2VTQD9ipXLnpeWzD2EqMhOVAG09RGSyl5AhPzmnayTP1MB13DJm57SL8q ncngNbaiK4Hp8W8k92NXcNFFYFkPONXLOpsxwvBZf2zgrd2uQud3wKuFkLqwYAffZrH2ok Hao1pPERZeU9MhWtiinkXzC7WUNEbmQS65vBarIxXTHnYKh62w+nwWtsQzZkkxTSZAodo+ ccFMTCA2/6VWByvZIx4BNgMsME2VzHxHTr5WoKLRdvh7oD0MTUYhQqJeb/D3mQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627993754; a=rsa-sha256; cv=none; b=Ls3Fg7tuvasFlPCT7arEi6+rflmx5V7qWUGpfHb4QqdJGCd3xxNrCFIqyZbyk/z+foBnIr xzPwYctKp665FQPukY1BRnX+Xf4F7DSIGIIDPDhs8sYgoGzIJnyV+E44GY9V9L8cmhs2pi +u/d3XJyRAVkBnV6TvR3s4THgU6B+9C5MVNCe8sTrF1mv0bIrlhGZ5PRmlpT/dcbAYVwFe R9Vc/vE3s8f5ja/THq1T4iEB33ysvoVL7yIhBd0ID9YgRi9ANKtpyVflCb465jflDWkTpV P94W6zinfTdpDSFy2YVA/PLJvyT41SgJdeGF6S6mYALG9n+aP1+I8QiN81B06Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HkEbrCnC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=HkEbrCnC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 518BA1E5A2 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: vTign7zxlNA1 Hi, Am Dienstag, den 03.08.2021, 13:59 +0200 schrieb Maxime Devos: > Leo Prikler schreef op di 03-08-2021 om 11:17 [+0200]: > > Hi, > > > > I'd merge this and 04/20 into a single patch. 04/20 does of its > > own > > give a good incentive as to why a new build system is to be used > > (this > > could instead be handled by the importer), with this phase added it > > makes slightly more sense. > > As an argument for having a 'minetest-mod-build-system', consider > some ways 'minetest-mod-build-system' could be improved in the > future: > > * a phase could be added to minimise PNG images (e.g. using > 'optipng') > * likewise, for lua code > * some basic tests could be added (e.g. creating a new world and > loading the mod, testing that Minetest doesn't raise an error > during > mod loading) Of course there's more that can be done here, but this just reaffirms my earlier point, that the build system on its own as it is in 04/20 looks rather unfinished. I'd personally prefer introducing it as one whole as it gives a bigger picture of the whole thing rather than digging into every detail. > Also, having "#:install-plan '(("." "share/minetest/mods/the-mod- > name"))" > appear in every package definition seems rather repetitive to me. Perhaps, but it's not like there aren't other groups of things that can be implemented trivially in terms of copy-build-system. > The idea behind "04/20" and "05/20" being separate patches, is to > start > with a basic "minetest-mod-build-system" and gradually improve it. > The small improvements (currently only one, i.e., 05/20) could be > reviewed > separately from each other and whether there should be a > "minetest-mod-build-system" at all. See above. > E.g., see attached a patch that sets #:allowed-references '(), > ensuring > nothing sneaks into the closure. Another change I'm thinking of, is > including > only "tar", "gzip" and the like as implicit inputs, and not "bash" or > "coreutils", > though that's probably useless if shebang patching has been disabled. IMO that patch should also be merged "as one" with the others. > > OTOH, perhaps we shouldn't install those shell scripts in the first > > place? Perhaps we can instead make the importer generate packages > > based directly on copy-build-system, in which those static strings > > are > > already evaluated. WDYT? > > Directly using 'copy-build-system' makes it more difficult to make > the improvements listed above. I don't know what you mean with ‘in > which those static strings are already evaluated’ -- what are ‘those > static strings’ here? ‘Those static strings’ are exactly "the-mod-name" in > #:install-plan '(("." "share/minetest/mods/the-mod-name")) I'm still not quite convinced, that whatever improvements you seem there to be can't be made by using a good enough include regexp. > I suppose it is possible to exclude shell scripts from installation, > but just installing everything (and disabling shebang patching) seems > simpler. Likewise leaving shell references in there and using plain copy-build- system would be simpler than making a new build system, wouldn't it? I don't think that's a good reason not to make a proper install plan. Greetings