unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#74011] [PATCH] gnu: prrte: Record the absolute file name of ‘prted’.
@ 2024-10-25 10:46 Ludovic Courtès
  2024-10-28  9:24 ` bug#74011: Close Andreas Enge
  0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2024-10-25 10:46 UTC (permalink / raw)
  To: 74011; +Cc: Ludovic Courtès

From: Ludovic Courtès <ludovic.courtes@inria.fr>

Previously a command like:

  guix shell --pure openmpi@5 openssh intel-mpi-benchmarks \
    --with-input=openmpi@4=openmpi@5 slurm -- \
    salloc -N2 -- mpirun -np 2 --map-by node IMB-MPI1 PingPong

would silently fail due to ‘prted’ not being found in $PATH.

* gnu/packages/parallel.scm (prrte)[arguments]: Add
‘patch-prted-reference’ phase.

Change-Id: Iff30cb5a4dcc9e9cfe6638d518ee4f19561289a0
---
 gnu/packages/parallel.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/parallel.scm b/gnu/packages/parallel.scm
index 202a98b2bc..85f8a114c3 100644
--- a/gnu/packages/parallel.scm
+++ b/gnu/packages/parallel.scm
@@ -727,7 +727,15 @@ (define-public prrte
                     (("_ABSOLUTE")
                      "")
                     (("PRTE_CONFIGURE_CLI")
-                     "\"[elided to reduce closure]\"")))))
+                     "\"[elided to reduce closure]\""))))
+              (add-after 'unpack 'patch-prted-reference
+                (lambda _
+                  ;; Record the absolute file name of 'prted' instead of
+                  ;; assuming it will be found in $PATH at run time.
+                  (substitute* "src/runtime/prte_mca_params.c"
+                    (("prte_launch_agent =.*")
+                     (string-append "prte_launch_agent = \""
+                                    #$output "/bin/prted\";\n"))))))
 
           #:disallowed-references (list (canonical-package gcc))))
    (inputs (list libevent

base-commit: a1714de3aa4f60d211c166876c3515f96384b0c7
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#74011: Close
  2024-10-25 10:46 [bug#74011] [PATCH] gnu: prrte: Record the absolute file name of ‘prted’ Ludovic Courtès
@ 2024-10-28  9:24 ` Andreas Enge
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Enge @ 2024-10-28  9:24 UTC (permalink / raw)
  To: 74011-done

The patch passes QA. I am pushing it on behalf of the author who is AWK.

Andreas





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-28  9:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25 10:46 [bug#74011] [PATCH] gnu: prrte: Record the absolute file name of ‘prted’ Ludovic Courtès
2024-10-28  9:24 ` bug#74011: Close Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).