From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aCTTMdSmmGHyIAEAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 08:42:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +I6CLdSmmGGXRgAAB5/wlQ (envelope-from ) for ; Sat, 20 Nov 2021 07:42:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7204A2F279 for ; Sat, 20 Nov 2021 08:42:12 +0100 (CET) Received: from localhost ([::1]:36580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moL0l-000054-Lm for larch@yhetil.org; Sat, 20 Nov 2021 02:42:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moL0c-00004q-Af for guix-patches@gnu.org; Sat, 20 Nov 2021 02:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moL0c-0005OU-1T for guix-patches@gnu.org; Sat, 20 Nov 2021 02:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moL0b-00058g-TC for guix-patches@gnu.org; Sat, 20 Nov 2021 02:42:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v2 05/26] guix: node-build-system: Add #:absent-dependencies argument. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 07:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163739411619742 (code B ref 51838); Sat, 20 Nov 2021 07:42:01 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 07:41:56 +0000 Received: from localhost ([127.0.0.1]:41536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moL0W-00058M-J4 for submit@debbugs.gnu.org; Sat, 20 Nov 2021 02:41:56 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moL0U-000584-3w for 51838@debbugs.gnu.org; Sat, 20 Nov 2021 02:41:54 -0500 Received: by mail-wr1-f67.google.com with SMTP id d5so22182067wrc.1 for <51838@debbugs.gnu.org>; Fri, 19 Nov 2021 23:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=JAplla7tb92R7PlPcqHDAPhz/SJUhC38rC6ejofCWWg=; b=mBF/nXIhSgvpqQvIqyFOSxqeTqx9GFIqnhETeH0TzZiQWrYdk1rAsG3V6A4TUgkMuO QwWRaNiOHEHSmAO6LopBT3RPxw0AyC9O66oNA0tUblRrOaoZXyXe6ISWl8RJHMRKYPuM fj1osmChlZWMcVrr2KTwNiAEj0ggYr0pySfWC49mpZRbVpHNvTRrCumNESlqPHVaOPyv krzSLeDAh+oCHaI/QkXMCSPPGZBRFMlydRJnGMwiWfRM7UZRECiCG5je1FpPWqUGos35 KUFZaA5Dt/i+ibfTNDW+bNcK3oAC6Bj+aTvDlVWhxrbZh8kSDcaym5OAkZqPsnltvWC/ XFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=JAplla7tb92R7PlPcqHDAPhz/SJUhC38rC6ejofCWWg=; b=FREcAMqZmFTm6es+34/JEVKxWG8B/6rKhRaWUZ/Te/ENx6i5O8E5xsLQlQYX/5cHJq 7iUC64chDyS0tQwLYe2pl+xa4GNo32R5hOzJldKuD07GudebtWGsxscD5RRzugcBXQfm NqIIn1TbFBlKzuAvx/qfL+NjyrnpRgDT0s50SbR1xmtbel8/rpPoqWHCmKwhA4HoYRwZ AvdLfGZsicZeBytI+RNCJaECXMxU/CgdFW73PHEGHn55KR7XtuAjJ9h0sRtIuLs6uPk7 Cfj6uI5//g2xFdt7oBjRaMI+809Ci+W9hAgddTOHYFVxRrrZRfW+QxXSu+DT12EZhCjP D0Mw== X-Gm-Message-State: AOAM530i+GITXa/mfT630Blib99Uhfn7ZXk9iz7eVJICayxhqTHMXG3P 3x2IrS1+43qMs0lChY98n2M= X-Google-Smtp-Source: ABdhPJxU6Ii6mBzm0IYxOEboyJwkUw8SzLgwzBjjx7VBKyhL6Y4yE6XsXTzWfaOWzEQTF21oky8UvQ== X-Received: by 2002:a5d:6a4d:: with SMTP id t13mr15395488wrw.104.1637394108075; Fri, 19 Nov 2021 23:41:48 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id q24sm4703782wmj.21.2021.11.19.23.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Nov 2021 23:41:47 -0800 (PST) Message-ID: <8c07272b588fc059f3c445fe1f33c63cce8f31f1.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 20 Nov 2021 08:41:46 +0100 In-Reply-To: <20211120043406.952350-5-philip@philipmcgrath.com> References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-5-philip@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637394132; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JAplla7tb92R7PlPcqHDAPhz/SJUhC38rC6ejofCWWg=; b=B4J+lpkdbZQygqIV8Gn66bWJbVLVg7WiTQVrC01CY4H+Bj4yn0GUpHgFJQ7b57fxz8IrUB E4Hn1UUBMb1qRIw3Hlw+XV/QgCxO49z9/y3GU52zt0k2PWDL85+MUpF27fMrDh0wl5ERvA kdcEUQNruWHj/W/QVqLn8pdagxh9HMosG3jKlmdLNFeaX80vLjSMdxxaotkLzg0jDhpmXK YcSLuDFQpUweqU+903LCPANzXB2w3tbHcJlfQ3wAC0htk1KGiwXwbOWmDfX0Ik/I0LiUpk oryhr+hGlaUtQOy6dH4rlRdCQA5VbmNFeVG0uZR8O7D83tOAXcct0bLxsTRLTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637394132; a=rsa-sha256; cv=none; b=BK0AqFDVi9qy2t2RuzNHEczTpXlnFoxfrtucMDfGFBWkgybJa4+SN9yklO4I9savFDLR/o O8d3n2kxdahN3Q5lGFfMeyp8m6JFBaNCrKaLCexWob4OQdyhnOrHmLqFfoY+SX5osU48nA 4o0kT09B8UlprhLBfQ/BPTfi+LwpAhvq/yBMspeFzJFJMlOMSoOs/NYPMF/hR3fGnRjPxm 4nQSSDoTPhuZZdWSNTOaspYX0nonOVY13NLqbbUauHEG3i91r3/aYm8rvbZWqChgT2BjCP fynBWLrF66x4i8lpQsj0d+YSVgsUvLMvB9I5v+dTAYB9CnOaqfM14lyAOCkrwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="mBF/nXIh"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="mBF/nXIh"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7204A2F279 X-Spam-Score: -1.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: 869HCASsTYks Hi, Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath: > Many of Guix's Node.js packages are built without some of the > dependencies they specify in their "package-lock.json" files, > either because we don't have them packaged yet (e.g. test > utilities) or because we don't want them (e.g. to reduce the > closure size). Previously, Guix package definitions would work > around this situation by deleting the `'configure` > phase (i.e. the initial `npm install`). > > This commit adds an optional #:absent-dependencies argument to > `node-build-system` to list Node.js packages that should be > removed from the "package.json" file.Retaining the `'configure` > phase avoids skipping checks for the dependencies that are > intended to be present and other actions performed by `npm > install`, such as automatically building native add-ons with > `node-gyp` when the "gypfile" key is present. > > [...] This is a somewhat decent approach, but I wonder whether we could improve this. Does nodejs complain if a dependency exists in the code, but is not present in the packages.json? In the resolve-dependencies subprocedure, we could check whether we have a matching input somewhere and only include the dependency if we do. WDYT?