From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6OfYKbyfdmKNCAAAbAwnHQ (envelope-from ) for ; Sat, 07 May 2022 18:35:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CD3DKbyfdmI25gAAauVa8A (envelope-from ) for ; Sat, 07 May 2022 18:35:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2128A2C741 for ; Sat, 7 May 2022 18:35:08 +0200 (CEST) Received: from localhost ([::1]:56058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnNOd-0007QP-0E for larch@yhetil.org; Sat, 07 May 2022 12:35:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnNOX-0007Pz-V5 for guix-patches@gnu.org; Sat, 07 May 2022 12:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnNOX-00066u-MJ for guix-patches@gnu.org; Sat, 07 May 2022 12:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnNOX-0000lS-IB for guix-patches@gnu.org; Sat, 07 May 2022 12:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53833] QBE and cproc upstreaming In-Reply-To: <20220207011332.27844-1-jgart@dismail.de> Resent-From: paren@disroot.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 07 May 2022 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53833 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53833@debbugs.gnu.org Cc: liliana.prikler@ist.tugraz.at Received: via spool by 53833-submit@debbugs.gnu.org id=B53833.16519412952923 (code B ref 53833); Sat, 07 May 2022 16:35:01 +0000 Received: (at 53833) by debbugs.gnu.org; 7 May 2022 16:34:55 +0000 Received: from localhost ([127.0.0.1]:52858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnNOQ-0000l4-NW for submit@debbugs.gnu.org; Sat, 07 May 2022 12:34:55 -0400 Received: from knopi.disroot.org ([178.21.23.139]:35680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnNOF-0000km-40 for 53833@debbugs.gnu.org; Sat, 07 May 2022 12:34:54 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7D86B42FE3; Sat, 7 May 2022 18:34:42 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id IgSGqjZBzFWW; Sat, 7 May 2022 18:34:41 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1651941280; bh=he5jmtNxe8RWHJgNgqeVUsJlvog32rJmJC6OpY7CNdU=; h=Date:From:Subject:To:Cc:References; b=aEDZy7TMtJaTvfWISVMyXjZH8+AMY+DZeXT2Ep9dViwv6rOkV4IC9AKdpe1exDoOg ++7JmWZmAUZLtX0HlzkyBOPCGvr7r5dd0vQ/y/Xa2TMOrYPfYMJkK1SOVk/+SQt5h3 y8290TrWtkd2b2jTOzFEl6vA0ZWrLvLw0sdw50DecNWmB8lRyoeynAMlPnj/zfGsnp zk41v0rCYryzMcCz1UWIEMhaeBBcj4IDYGUMFzYKKMdFyMrkZeVVvnWR4hJTYJE/lu Klz158VNbaLnCu7TbrRgbZaUoCx2sG6+8CXo+u5jSmx9k9px3U6oI2B02GTiL5w1pb vxOQ3KZE9e73Q== Date: Sat, 07 May 2022 16:34:40 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <8b70a176c466220eea29aa967d104fdfc2ac93e6@disroot.org> References: undefined undefined X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: paren@disroot.org X-ACL-Warn: , paren--- via Guix-patches From: paren--- via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651941308; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=he5jmtNxe8RWHJgNgqeVUsJlvog32rJmJC6OpY7CNdU=; b=NewIrYMJt2UU8ZSmRZU7BOn9A1LOcgf7Nh894ALorlHIwPzUVDm6YUd5mFj3mVpXNhYnw3 F2bTCAe8yGh1DUZOtJgAcz6Lt4U3E3XVYuULWLrVIlgcAXL7izqrbbZ1Bis0ZgODU+ZUjZ QP0wVQkkyyRCuUKQAH/BsoRaJXBOZ+GK13MuFBfvTYg996rU5NdGAdKXOoXJraEHmgNR6w qCN+V1bYmTqXNcxFPsOp/G41las4lX3kd5mYRF5MCNAIX4d8p668Hg66BzN4J/3YyBZu3B nXzpnsyQ1FLMu8bIlWSouedTNvY3EUTLriBcByHgbRtWVMvrjSVWJnKB/hjbSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651941308; a=rsa-sha256; cv=none; b=uv78gYxZCWBldJXzblpI+o9ZiJnBNvlg9Kuj7EaLUWV37BkfYEfs5DMu2Ba9xtinCoZ85z q74qdfdYSOhHYJowjXbgnRoaPbCiEApTQoCFf8ltGAjp259AEVTIIfOzgCWYxrEHCsoCaF bcly5ul8OpoluR6IXOnm48CJdRQGK8dAXnzVSdsZCNr6d1pXj+JaGKzdGO2xYhRkSA4YW9 VNZUi+xr4sktnI6gIweezdacZ/iQyAGADPdmPYkhqbcbbjbT/DtQdGrBmyqDcbkWvDYLlV 1edLfwaQ8xs7BDSoXJI1IVVsfauxM5RCvXhN8Js64Uz0rZxfhzp9Jg9TVzqJpQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=aEDZy7TM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=aEDZy7TM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2128A2C741 X-Spam-Score: -1.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: CNczM1ECoop6 Hi Liliana, > IMHO, paren's initial patch is slightly better in quality than 55151, > but there are two (three) things lacking. First, the synopsis and > description are subpar. 55151 has a slightly better synopsis, don't > feel too sure about the description though. Second, the "fix-cc" phase > from 55151 should be added after unpack ("patch-test-script" sounds > like a better phase name). It might be better to use (cc-for-target) > in the substitution rather than gcc, but note that this substitution > only applies for native compilation anyway. I have made your suggested improvements, plus substantial changes to the = build recipe that allows you to cross-compile both QBE and cproc. I have confirmed that cross-comp= ilation works for aarch64 and riscv64. Here is the updated code: . The changes are as follows for qbe: * Patch the makefile to support cross-building with a TARGET variable. Th= is is done with a standalone patch. * Set "TARGET" to the appropriate target system. * Set the correct supported systems. (It supports x86_64, aarch64, and ri= scv64 currently.) * Improve the synopsis and description. * Update to the latest commit. Note that tests still aren't provided because they use QEMU. And cproc: * Reenable tests. Not sure why they were disabled in the first place... * Instead of skipping the configuration phase, replace it with an invocat= ion of cproc's hand-written ./configure. Pass the correct arguments to it to allow cross-compilation = to aarch64. * Use gcc:lib as an input to support cross-compilation. * Set the correct supported systems. (It supports riscv64 only under musl= libc right now.) * Improve the synopsis and description. * Update to the latest commit. I think they are ready for upstreaming now. I will send improved patches = to the appropriate issue threads.