From: paren--- via Guix-patches via <guix-patches@gnu.org>
To: 53833@debbugs.gnu.org
Cc: liliana.prikler@ist.tugraz.at
Subject: [bug#53833] QBE and cproc upstreaming
Date: Sat, 07 May 2022 16:34:40 +0000 [thread overview]
Message-ID: <8b70a176c466220eea29aa967d104fdfc2ac93e6@disroot.org> (raw)
In-Reply-To: <20220207011332.27844-1-jgart@dismail.de>
Hi Liliana,
> IMHO, paren's initial patch is slightly better in quality than 55151,
> but there are two (three) things lacking. First, the synopsis and
> description are subpar. 55151 has a slightly better synopsis, don't
> feel too sure about the description though. Second, the "fix-cc" phase
> from 55151 should be added after unpack ("patch-test-script" sounds
> like a better phase name). It might be better to use (cc-for-target)
> in the substitution rather than gcc, but note that this substitution
> only applies for native compilation anyway.
I have made your suggested improvements, plus substantial changes to the build recipe that allows
you to cross-compile both QBE and cproc. I have confirmed that cross-compilation works for aarch64
and riscv64. Here is the updated code: <https://git.sr.ht/~whereiseveryone/guixrus/tree/master/guixrus/packages/qbe.scm>.
The changes are as follows for qbe:
* Patch the makefile to support cross-building with a TARGET variable. This is done with a standalone
patch.
* Set "TARGET" to the appropriate target system.
* Set the correct supported systems. (It supports x86_64, aarch64, and riscv64 currently.)
* Improve the synopsis and description.
* Update to the latest commit.
Note that tests still aren't provided because they use QEMU.
And cproc:
* Reenable tests. Not sure why they were disabled in the first place...
* Instead of skipping the configuration phase, replace it with an invocation of cproc's hand-written
./configure. Pass the correct arguments to it to allow cross-compilation to aarch64.
* Use gcc:lib as an input to support cross-compilation.
* Set the correct supported systems. (It supports riscv64 only under musl libc right now.)
* Improve the synopsis and description.
* Update to the latest commit.
I think they are ready for upstreaming now. I will send improved patches to the appropriate issue
threads.
next prev parent reply other threads:[~2022-05-07 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 1:13 [bug#53833] [PATCH] gnu: Add qbe jgart via Guix-patches via
2022-02-07 9:47 ` Liliana Marie Prikler
2022-02-08 21:10 ` jgart via Guix-patches via
2022-04-05 16:11 ` bug#53833: " Ludovic Courtès
2022-04-25 20:08 ` [bug#53833] " paren--- via Guix-patches via
2022-04-26 18:16 ` paren--- via Guix-patches via
2022-05-07 16:34 ` paren--- via Guix-patches via [this message]
2022-05-07 17:09 ` (unmatched-parenthesis via Guix-patches via
2022-05-07 17:11 ` [bug#53833] [PATCH] gnu: patches: Add qbe-makefile-add-target.patch (unmatched-parenthesis via Guix-patches via
2022-05-07 17:21 ` [bug#53833] [PATCH] gnu: packages: c: Add (unmatched parenthesis copyright statement (unmatched-parenthesis via Guix-patches via
2022-05-07 18:19 ` [bug#53833] Upstreaming QBE and cproc paren--- via Guix-patches via
2022-05-08 20:21 ` [bug#53833] [PATCH v2] gnu: Add qbe (unmatched-parenthesis via Guix-patches via
2022-05-24 6:50 ` Liliana Marie Prikler
2022-05-24 19:44 ` bug#53833: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b70a176c466220eea29aa967d104fdfc2ac93e6@disroot.org \
--to=guix-patches@gnu.org \
--cc=53833@debbugs.gnu.org \
--cc=liliana.prikler@ist.tugraz.at \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).