unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tim Magee <timothy@eastlincoln.net>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 42357@debbugs.gnu.org
Subject: [bug#42357] [PATCH] add package definition for Nextcloud Desktop
Date: Wed, 15 Jul 2020 12:57:46 -0400	[thread overview]
Message-ID: <8ab6db26-8309-750e-b730-2d46a5e6f49a@eastlincoln.net> (raw)
In-Reply-To: <87mu41k6fe.fsf@nckx>


[-- Attachment #1.1: Type: text/plain, Size: 862 bytes --]

> I guess you first added NextCloud to sync.scm, then decided to put it
in its own file (or maybe because I told you so .  Don't forget to
delete all the previous copyright lines (unless you borrowed code from
elsewhere), and packages other than nextcloud-desktop.

What I did is wholesale copy the entire 'sync.scm' file thinking that
the entire file was necessary for ownCloud in particular. I then copied
modified the ownCloud definition until Nextcloud would compile. I will
have to admit that I was a bit confused as to why the ownCloud package
was in a file called 'sync.scm' but I assumed that there was good reason
somewhere. Now that I know that multiple packages can be declared in the
same file, it seems that it would make more sense to place Nextcloud in
sync.scm as well.

Would placing Nextcloud inside sync.scm be a better idea?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2020-07-15 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e7ea0a47-a381-6fc9-8885-518e900843d2.ref@eastlincoln.net>
2020-07-14 22:13 ` [bug#42357] [PATCH] add package definition for Nextcloud Desktop Tim Magee
2020-07-14 23:32   ` Tobias Geerinckx-Rice via Guix-patches via
2020-07-14 23:44     ` Tobias Geerinckx-Rice via Guix-patches via
2020-07-15 16:57       ` Tim Magee [this message]
2020-07-15 20:29         ` Tobias Geerinckx-Rice via Guix-patches via
2020-07-17 18:03           ` Jonathan Brielmaier
2023-05-18 15:12   ` bug#42357: " Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ab6db26-8309-750e-b730-2d46a5e6f49a@eastlincoln.net \
    --to=timothy@eastlincoln.net \
    --cc=42357@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).