From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uFEELuE+42Y0QgAAe85BDQ:P1 (envelope-from ) for ; Thu, 12 Sep 2024 19:20:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id uFEELuE+42Y0QgAAe85BDQ (envelope-from ) for ; Thu, 12 Sep 2024 21:20:01 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=D48q375E; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=osqjukBV; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726168801; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yGbs2SCUJ1+EZEUSRsIxgMlrINHDXbmIo51JuTCKK5c=; b=KGUNjFXgoT3JS2nAxaWiqIX7BdydVR7k0o7cTzisw8IRwb1SauOky4FKcTogJCCyuB7V7Z oYAxr1Ib+IyTlRF7SHFYScFMQmUU7HhY2zF9TUx2WmiA/kWcyWWRwIP23Z9Fq2MS5flM9B b1Qh82jufgM7BxsadSn6ZL0Higi+bdkJHzo88SBKcR3Sax9o3Pou8KRdQdL5VAAVqkN368 UpEBzevXrqqy4hVyMuvuQ7xVLC6eFnmFS1x72DBm5yT9tqxckqvqXKT1Uh9jeExpG1Y85D Xqld+AvtqML78ZOW+ZP8oDb/xUDv3IDJ8ZKkUnLqo1gLM8uFQZhnq7zcuiqFcw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726168801; a=rsa-sha256; cv=none; b=LqeSDIWuFaYFD0/YkLlq62S94pYaSQEqy1NeEwH7udZt2CDEE3s1KFpvpiskBzwCWMDOiC WOpDpjKGAaiHroiHd03E9sIE+yfsVDNwTwOAFr2Z+m3bx0c/Cr8NbsSBL97XyDhni4Lvcc npyFgE+wt+WsHAKjKzJxVvDyVTqxo+n0daZMcAjJM7E2apvgw3iEqt3uR5J+4AXuwX9r76 u5FUp7Jje4j5ahyLvLWXPk2zxO8qCUqUR+AFNGGSs8hzN59kv596zigRPxxYMTguxfPi7y xK4+BKOC0O0GzQvdihiyIzJhN+pnDq+QvvSy808MxnGtH16EhurAo3Cu/D8ucQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=D48q375E; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=osqjukBV; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8DF6C8CE5 for ; Thu, 12 Sep 2024 21:20:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sopMD-0002YV-90; Thu, 12 Sep 2024 15:19:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sopMB-0002Xz-Ci for guix-patches@gnu.org; Thu, 12 Sep 2024 15:19:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sopMA-0006cl-UH for guix-patches@gnu.org; Thu, 12 Sep 2024 15:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=yGbs2SCUJ1+EZEUSRsIxgMlrINHDXbmIo51JuTCKK5c=; b=D48q375E8YPaLsLXxg9aBR/GMzxrFxgZ1kDXARdCUliSOEkTedlOCqOhoAdWmeToG936HEoIf+80eLnTLtks3gqOGa3XBdTim7xnRr5hoteVhd4C99frlU2SWjGqe2knrS9N0qrnIot30h/9nX+jwdVCHtLtIoe+64vpQJ4AePCtMhNGk6rjgtJV8BZNbnmWSzHAjJeVc5XClySJ7lGZiJz6o8Z89dRYOuBV5dWaUAuO+FNx4uD97TkrANRzWX1hC3J8g1gQ5lb5b6jfbMCpSACaaItaV3GZPzvd7MO25CXqQB0NwS3moE11hM6R2LyVKoXeIw1UEkciLxWMR8dw8g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sopMI-0004N8-I8 for guix-patches@gnu.org; Thu, 12 Sep 2024 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Sep 2024 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz Received: via spool by 73028-submit@debbugs.gnu.org id=B73028.172616876416743 (code B ref 73028); Thu, 12 Sep 2024 19:20:02 +0000 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 19:19:24 +0000 Received: from localhost ([127.0.0.1]:41966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sopLg-0004Ly-6F for submit@debbugs.gnu.org; Thu, 12 Sep 2024 15:19:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]:58053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sopLe-0004Lj-6F for 73028@debbugs.gnu.org; Thu, 12 Sep 2024 15:19:22 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A31D5240101 for <73028@debbugs.gnu.org>; Thu, 12 Sep 2024 21:19:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726168747; bh=j5e3B+pPETIm5iCk54ze/NDvgxagJN8J6K13UPNkyp0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=osqjukBVMrHWaWKrqBFCHAnA2g8fvn+Kmyy48dvpnmkHH64VJKLsOp0uCz9WuJFhI VwzIQrb247J9xzthpGqTYoc2KJx+pOYJDvI+lNeyfNAvLplMuZl790+RpPrKUP88Sg wUzftcR+8R8jHlZ4LP9UNT+cMNz6WgndesN3XoljXAJcCw92+/f7HszwofTk1iGY55 sAVIUIwdZYzHblWhWWEE201QFiM2JVB/V105VaIejX6A8W+m+6oH1iOEFMalxRKT37 TzqY/w1hlGkKkHKJQTo2zAXhVt1TBxwPkOS0a2YHGu7Dyi7dfkiRbMuqy024D9IME3 5oZ/vtpfV/bfw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X4S0p0mJDz6tvq; Thu, 12 Sep 2024 21:19:06 +0200 (CEST) Message-ID: <8a62a876-58e8-401f-9716-9b661bd008f5@posteo.net> Date: Thu, 12 Sep 2024 19:19:02 +0000 MIME-Version: 1.0 References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> <877cbhw050.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <877cbhw050.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.71 X-Spam-Score: -4.71 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Queue-Id: 8DF6C8CE5 X-TUID: skh7iQcui3sx On 12.09.24 14:02, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > > [...] > >>>> Maybe it should not be an option at all and instead be #t >>>> unconditionally in 'install-license-files phase in meson-build-system? >>> Given most build phases of the gnu-build-system, which support >>> #:out-of-source? are reused in the meson-build-system, this argument >>> needs to be set to #t (which it currently is). But perhaps there's a >>> way to hide it from the users, perhaps via the 'private-keywords' >>> variable defined in the 'lower' procedure of the (guix build-system >>> meson) module (I haven't tested). >>> >> >> Something like that might be a better solution. I am not sure how >> these 'private-keywords' work: It looks like #:meson is one but you >> can definitly override the default meson being used. Also the >> private-arguments seem to get stripped from the arguments in the bag >> (not sure what that is exactly) so they might not be passed to the >> build phases > > I think your understanding is correct. The private options are accepted > on the build system, but not propagated to the lower build strata > (applied to phases). So what we'd like here is to *not* expose an > #:out-of-source argument at the build system level, and enforce > #:out-of-source #t for the lower build code. I guess the static #t > argument could be added to the bag arguments. > This does not work. I tried adding that to the arguments in the bag (and reverting the previous patch) but get an error: Unrecognized keyword: #:out-of-source? I guess this is because meson-(cross-)build now get a keyword they don't know. Maybe we could replace the install-license-files function with a version that has #:out-of-source? set to #t?. Not sure if there is an elegant way to do this? >> >> Would such a change require rebuilding (basically) everything given >> that currently all packages are already built with #:out-of-source? >> set to the default value #t? > > Yes. To test this kind of change without having to wait for the world > to rebuild first, I sometimes make a copy of the build system files and > suffix them with -v2 or something. It's a bit of a pain, but faster than > waiting for 20k packages to be built. > Previously i have been using the tio package for testing because it had no other dependencies depending on meson. However since it got upgraded it now depends on glib ...