From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UOcLEgG8aGCvoAAAgWs5BA (envelope-from ) for ; Sat, 03 Apr 2021 21:03:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WHF6DAG8aGCAAQAAB5/wlQ (envelope-from ) for ; Sat, 03 Apr 2021 19:03:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8A2A13451 for ; Sat, 3 Apr 2021 21:03:28 +0200 (CEST) Received: from localhost ([::1]:43898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSlYO-0001w3-2R for larch@yhetil.org; Sat, 03 Apr 2021 15:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSlX0-0000xG-9p for guix-patches@gnu.org; Sat, 03 Apr 2021 15:02:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51125) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSlX0-0007sB-2F for guix-patches@gnu.org; Sat, 03 Apr 2021 15:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSlX0-00006N-07 for guix-patches@gnu.org; Sat, 03 Apr 2021 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Apr 2021 19:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47582 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel , 47582@debbugs.gnu.org Received: via spool by 47582-submit@debbugs.gnu.org id=B47582.1617476481340 (code B ref 47582); Sat, 03 Apr 2021 19:02:01 +0000 Received: (at 47582) by debbugs.gnu.org; 3 Apr 2021 19:01:21 +0000 Received: from localhost ([127.0.0.1]:34438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSlWL-00005P-79 for submit@debbugs.gnu.org; Sat, 03 Apr 2021 15:01:21 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:55594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSlWI-000057-0M for 47582@debbugs.gnu.org; Sat, 03 Apr 2021 15:01:20 -0400 Received: from butterfly.local ([213.119.170.42]) by xavier.telenet-ops.be with bizsmtp id oK1F240030vDxTp01K1FDK; Sat, 03 Apr 2021 21:01:16 +0200 Message-ID: <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> From: Maxime Devos Date: Sat, 03 Apr 2021 21:01:01 +0200 In-Reply-To: References: <7403e614931a4e0763650380cd0e0da4db4ec888.1617463189.git.h.goebel@crazy-compilers.com> <35e212d90dd9d99a273e6c667cbd92b41b80219f.1617463189.git.h.goebel@crazy-compilers.com> <8aa40a9619cca1efe195f6007fc007a306919023.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-a4smc+8val6layiwwhCS" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1617476476; bh=zJgs3InbkagXImjOLixnYYam/FQJsnq8W7EaguuCFcE=; h=Subject:From:To:Date:In-Reply-To:References; b=JQbno8xMMKHHCmQSZaXLrg0MJyPe7j7Fh5J+s2bdjjos/ovAx2eHcTvIIAUVUwyRZ KkJvfxfpVQo9CNK5jR503iw6afIldOxn1hkASHtfJMg6298LTlggEXOERJgHKIh0Eq QWYtFeiQdqftwirrAetDhzl94isW8nLwDoWDK29EI9MG0zXYarIbi6wopA+DkVoYfa D05gTinhnoQzkbPN1fXOBnGTMh6VIxTyFzX6oO0MR3OlAPYrZNNa5x2pL/iIbAl8SZ azO+qmGAVP8PhWbfZJhUcUcKeO3o7PyzuuTxeKJcDSCzMmjYhhl7SNl+z3qXdlwnz+ kirc+/wtCrDAQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617476609; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zJgs3InbkagXImjOLixnYYam/FQJsnq8W7EaguuCFcE=; b=iv+61xxNd0gC5vK1xJw24ISOhgHKWXCyshplFYFuI+tweOG0epjUIzO31Y/vfBaEQgZO/v BoKW0f4sYiBwqi/3uY+QdBSqJTquPs5dhGD65Rg2OUYVhak1PnDxclf2Ne/6nEeQAHJl5f k6HgbB14XDS15LxXATc8mSOLim9F7yD0cVW2vV9w+3eA7Q9K/iY2m7LCbEiOFH+tziHyWB 2bmiECL0taEsGxeW3ykcVQ/53PKybyQj3Z4imIW3Wi9l+HvT9KSGRxAMKbTug0OpH1O6t4 mCyuZDmRWXVoqoq4AgBjFlwu/2z8BlLWMlN7BesgBMVSaL0PD++g0/US2hoSUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617476609; a=rsa-sha256; cv=none; b=BwuG7uSdtQHA2cbBRKM0/8h7G3nfShCiiS4zUVW/jEsp2SsuJH5x2WYcy+7ONqxHo3Zq+A f4syARIij1b6YTbR5TwuUjwdgjH+WZfg3i4r/umEYJUaC0DOg2T4iFU0+aH/7vTEFgJqHO HhA5Hgjece2U9xTzMFe9DIC2y4QxsYxXFpQNhd9Uk5qRci4Uj1u7J6trjbU7A0/oqXwRbp Hk075ooMzuL1z7cCF4Tla3WolmEqJg3vFHCuhvGuj60gAj8JQyuYe15gNxWjuIJWVH0meT HcGY4AQeuXRVU0wfGVRwoapcj60s4xfrFzCZiYXGIEWFvofsk9eS4DXtecDZvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=JQbno8xM; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=JQbno8xM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E8A2A13451 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0M2HMcP8AvsG --=-a4smc+8val6layiwwhCS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-04-03 at 19:37 +0200, Hartmut Goebel wrote: > Am 03.04.21 um 18:12 schrieb Maxime Devos: > > Phases do not need to return #t anymore. IIUC the warning message that= results > > if it is left out has been removed on core-updates. >=20 > Okay, will do. Any other remarks? About the following code: > + (substitute* "setup.py" > + (("include_dirs\\s*=3D.*") > + (string-append "include_dirs =3D ['.'] + '" > + (getenv "C_INCLUDE_PATH") "'.split(':'),")) > + (("library_dirs\\s*=3D.*") > + (string-append "library_dirs =3D '" > + (getenv "LIBRARY_PATH") "'.split(':'),"))) When cross-compiling, this code should most likely use CROSS_C_INCLUDE_PATH and CROSS_LIBRARY_PATH instead. (Admittedly, python-build-system does not support cross-compilation yet, so this is not important ... yet.) Suggestion: replace (getenv "C_INCLUDE_PATH") with (getenv ,(if (%current-target-system) "CROSS_C_INCLUDE_PATH" "C_INCLUDE_PATH")). Likewise for LIBRARY_PATH. Some aesthetic nitpicks (YMMV): > + (synopsis "Python module for the SCTP protocol stack and library") A space has been doubled. > * gnu/packages/networking.scm(python-pysctp): New variable. I would put a space between .scm and (python-pysctp). Most commit messages do. +(define-public python-pysctp +(package + (name "python-pysctp") + ... Indentation is wrong here. See 16.5.4 Formatting Code for how to automatic= ally indent code. Greetings, Maxime. --=-a4smc+8val6layiwwhCS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYGi7bRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7u0DAP9dF0lyeAcS5Llq5gibg/f1HN+6 MbtOA0SPqeTwy3FbOwEAzFgswhtvShuOqUK6OMKzRl6GxyYXG4NaFYtdOPm+KwI= =T94u -----END PGP SIGNATURE----- --=-a4smc+8val6layiwwhCS--