From: Maxime Devos <maximedevos@telenet.be>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>, 47582@debbugs.gnu.org
Subject: [bug#47582] [PATCH 2/2] gnu: Add python-pysctp.
Date: Sat, 03 Apr 2021 21:01:01 +0200 [thread overview]
Message-ID: <8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be> (raw)
In-Reply-To: <ad5423a7-2ead-dffe-dee9-82bbfeb7b2f6@crazy-compilers.com>
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
On Sat, 2021-04-03 at 19:37 +0200, Hartmut Goebel wrote:
> Am 03.04.21 um 18:12 schrieb Maxime Devos:
> > Phases do not need to return #t anymore. IIUC the warning message that results
> > if it is left out has been removed on core-updates.
>
> Okay, will do. Any other remarks?
About the following code:
> + (substitute* "setup.py"
> + (("include_dirs\\s*=.*")
> + (string-append "include_dirs = ['.'] + '"
> + (getenv "C_INCLUDE_PATH") "'.split(':'),"))
> + (("library_dirs\\s*=.*")
> + (string-append "library_dirs = '"
> + (getenv "LIBRARY_PATH") "'.split(':'),")))
When cross-compiling, this code should most likely use CROSS_C_INCLUDE_PATH
and CROSS_LIBRARY_PATH instead. (Admittedly, python-build-system does not
support cross-compilation yet, so this is not important ... yet.)
Suggestion: replace (getenv "C_INCLUDE_PATH") with
(getenv ,(if (%current-target-system)
"CROSS_C_INCLUDE_PATH"
"C_INCLUDE_PATH")).
Likewise for LIBRARY_PATH.
Some aesthetic nitpicks (YMMV):
> + (synopsis "Python module for the SCTP protocol stack and library")
A space has been doubled.
> * gnu/packages/networking.scm(python-pysctp): New variable.
I would put a space between .scm and (python-pysctp). Most commit messages
do.
+(define-public python-pysctp
+(package
+ (name "python-pysctp")
+ ...
Indentation is wrong here. See 16.5.4 Formatting Code for how to automatically
indent code.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-04-03 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 15:20 [bug#47582] [PATCH 1/2] gnu: lksctp-tools: Fix build of include file Hartmut Goebel
2021-04-03 15:28 ` [bug#47582] [PATCH 2/2] gnu: Add python-pysctp Hartmut Goebel
2021-04-03 16:12 ` Maxime Devos
2021-04-03 17:37 ` Hartmut Goebel
2021-04-03 19:01 ` Maxime Devos [this message]
2021-04-11 15:07 ` Hartmut Goebel
2021-04-11 15:51 ` Maxime Devos
[not found] ` <handler.47582.B.16174635254261.ack@debbugs.gnu.org>
2021-04-11 15:07 ` bug#47582: Acknowledgement ([PATCH 1/2] gnu: lksctp-tools: Fix build of include file.) Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a02c752caf7b2cbcfbedaca4dba945ca3aa6f50.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=47582@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).