[bug#50397] [PATCH] gnu: Add python-crontab

[bug#50397] [PATCH] gnu: Add python-crontab

[Pradana Adrinusa AUMARS via Guix-patches via]

From 1a41d362dd97eae4c236c689bea871d0512c2f4d Mon Sep 17 00:00:00 2001
From: Pradana AUMARS <paumars@courrier.dev>
Date: Sun, 5 Sep 2021 09:46:58 +0200
Subject: [PATCH] gnu: Add python-crontab

* gnu/packages/python-xyz.scm (python-crontab): New variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7c70829de9..bbc5bad51c 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -108,6 +108,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26556,3 +26557,25 @@ files and directories and adds a datestamp in standard ISO 8601+ format
 YYYY-MM-DD at the beginning of the file or directory name.")
       (home-page "https://github.com/novoid/date2name")
       (license license:gpl3+))))
+
+(define-public python-crontab
+  (package
+   (name "python-crontab")
+   (version "2.5.1")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri name version))
+     (sha256
+      (base32
+       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
+   (build-system python-build-system)
+   (arguments
+    `(#:tests? #f))
+   (native-inputs
+    `(("python-dateutil" ,python-dateutil)))
+   (synopsis "Module for reading and writing crontab files")
+   (description "Crontab module for reading and writing crontab files and accessing the 
+system cron automatically and simply using a direct API.")
+   (home-page "https://gitlab.com/doctormo/python-crontab/")
+   (license license:lgpl3+)))
-- 
2.33.0

[bug#50397] [PATCH] gnu: Add python-crontab

[Xinglu Chen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sun, Sep 05 2021, Pradana Adrinusa AUMARS via Guix-patches via wrote:

> From 1a41d362dd97eae4c236c689bea871d0512c2f4d Mon Sep 17 00:00:00 2001
> From: Pradana AUMARS <paumars@courrier.dev>
> Date: Sun, 5 Sep 2021 09:46:58 +0200
> Subject: [PATCH] gnu: Add python-crontab
>
> * gnu/packages/python-xyz.scm (python-crontab): New variable.
> ---
>  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7c70829de9..bbc5bad51c 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -108,6 +108,7 @@
>  ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
>  ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
>  ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
> +;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -26556,3 +26557,25 @@ files and directories and adds a datestamp in standard ISO 8601+ format
>  YYYY-MM-DD at the beginning of the file or directory name.")
>        (home-page "https://github.com/novoid/date2name")
>        (license license:gpl3+))))
> +
> +(define-public python-crontab
> +  (package
> +   (name "python-crontab")
> +   (version "2.5.1")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (pypi-uri name version))
> +     (sha256
> +      (base32
> +       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
> +   (build-system python-build-system)
> +   (arguments
> +    `(#:tests? #f))

What’s the reason for disabling tests?  There is a test directory in the
Git repo; maybe test tests aren’t included in the PyPi tarball?  If so,
I would suggest using the Git repo instead.

> +   (native-inputs
> +    `(("python-dateutil" ,python-dateutil)))
> +   (synopsis "Module for reading and writing crontab files")
> +   (description "Crontab module for reading and writing crontab files and accessing the 
> +system cron automatically and simply using a direct API.")

The description should consists of one or more complete sentences, see
“16.4.4 Synopses and Descriptions” in the manual.  Maybe prefix the
description with “This Python package provides a …”?

  This Python package provides a crontab module for reading and writing
 crontab files and accessing the system cron automatically and simply
 using a direct API.

Also, wrap lines at 80 characters.

> +   (home-page "https://gitlab.com/doctormo/python-crontab/")
> +   (license license:lgpl3+)))
> -- 
> 2.33.0

I am having some trouble applying the patch.

- --8<---------------cut here---------------start------------->8---
Applying: gnu: Add python-crontab
error: sha1 information is lacking or useless (gnu/packages/python-xyz.scm).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 gnu: Add python-crontab
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
- --8<---------------cut here---------------end--------------->8---

Are you able to apply it to the ‘master’ branch, or is it just me?
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmE0xkAVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5Z4MP+gNxQxG/R6d1MvgsGizFTRmHkQEl
XpJdGU7LA52oewWtdZtWeSta+hWFSEAbEWEvWi3DUKDtomCXuOC8qXHfblYgCX98
buVVjQnrp3k8d9rTA+6ycIC/YEKMVmGlOtuDCm/a8IEjtwBgoFFvqa7vmqnzB71w
GpTrE12TL1WV7Eh9v558r2KQSOnMT81Kg3TGbIHLsw/oW1SlLjgF+wc75gKvbTJS
JDRwSpLstpn1rkA9CQCGqe3hnoL6xcWHUpMNKqXuyw8oFQoMZZy/5bzi+LezrRIO
AnjEZgEe+sRA/vC4OxysfqcwDJl/lbuDU9oRHMAgtfUqnSGc/ixL9UH7FkZnp2jq
9D/eCiBaFGe8sHMgnqtsd29JFi60a71hWdhfLtUDFpFesCxlhhv+61P0jG/oaLQ5
U+OlotdDxKSfALF1BXjHYRsvHviycZf0uGvE6mvB0AX2oP+wc/adY4WGJWizesCZ
RsSnIMNYdgrbkYvYP6oHxJm47FNZxkc9akbtdBTwRsuuM3a2EZmLmNlIs6NwtREQ
zQA51HokmTAT2e0ydLj5f/bHur/hOysidnFTYenredbUcv5yWubwqfBKMsi9d7Qk
fXmmOiBv5Rcn1PjZaeniVdn3kbedP0jzWgW8DOWo0XqliJB5PLlf+yuMmdJCrHOv
hqvE1XgzdLighlwE
=C2MV
-----END PGP SIGNATURE-----

[bug#50397] [PATCH] gnu: Add python-crontab

[Pradana Adrinusa AUMARS via Guix-patches via]

Le dimanche 05 septembre 2021 à 15:29 +0200, Xinglu Chen a écrit :
> On Sun, Sep 05 2021, Pradana Adrinusa AUMARS via Guix-patches via
> wrote:
> 
> > From 1a41d362dd97eae4c236c689bea871d0512c2f4d Mon Sep 17 00:00:00
> > 2001
> > From: Pradana AUMARS <paumars@courrier.dev>
> > Date: Sun, 5 Sep 2021 09:46:58 +0200
> > Subject: [PATCH] gnu: Add python-crontab
> > 
> > * gnu/packages/python-xyz.scm (python-crontab): New variable.
> > ---
> >  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> > 
> > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> > xyz.scm
> > index 7c70829de9..bbc5bad51c 100644
> > --- a/gnu/packages/python-xyz.scm
> > +++ b/gnu/packages/python-xyz.scm
> > @@ -108,6 +108,7 @@
> >  ;;; Copyright © 2021 Franck Pérignon <
> > franck.perignon@univ-grenoble-alpes.fr>
> >  ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> >  ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
> > +;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -26556,3 +26557,25 @@ files and directories and adds a datestamp
> > in standard ISO 8601+ format
> >  YYYY-MM-DD at the beginning of the file or directory name.")
> >        (home-page "https://github.com/novoid/date2name")
> >        (license license:gpl3+))))
> > +
> > +(define-public python-crontab
> > +  (package
> > +   (name "python-crontab")
> > +   (version "2.5.1")
> > +   (source
> > +    (origin
> > +     (method url-fetch)
> > +     (uri (pypi-uri name version))
> > +     (sha256
> > +      (base32
> > +       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
> > +   (build-system python-build-system)
> > +   (arguments
> > +    `(#:tests? #f))
> 
> What’s the reason for disabling tests?  There is a test directory in
> the
> Git repo; maybe test tests aren’t included in the PyPi tarball?  If
> so,
> I would suggest using the Git repo instead.

Compatibility tests fail so they are disabled, they are also disabled
in the AUR so I assumed they are unnecessary.

> 
> > +   (native-inputs
> > +    `(("python-dateutil" ,python-dateutil)))
> > +   (synopsis "Module for reading and writing crontab files")
> > +   (description "Crontab module for reading and writing crontab
> > files and accessing the 
> > +system cron automatically and simply using a direct API.")
> 
> The description should consists of one or more complete sentences,
> see
> “16.4.4 Synopses and Descriptions” in the manual.  Maybe prefix the
> description with “This Python package provides a …”?
> 
>   This Python package provides a crontab module for reading and
> writing
>  crontab files and accessing the system cron automatically and simply
>  using a direct API.
> 
> Also, wrap lines at 80 characters.

Applied.

> 
> > +   (home-page "https://gitlab.com/doctormo/python-crontab/")
> > +   (license license:lgpl3+)))
> > -- 
> > 2.33.0
> 
> I am having some trouble applying the patch.
> 
> --8<---------------cut here---------------start------------->8---
> Applying: gnu: Add python-crontab
> error: sha1 information is lacking or useless (gnu/packages/python-
> xyz.scm).
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Patch failed at 0001 gnu: Add python-crontab
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --
> abort".
> --8<---------------cut here---------------end--------------->8---
> 
> Are you able to apply it to the ‘master’ branch, or is it just me?

My mistake. There was a trailing whitespace. This has been fixed.

I will send a new fixed patch.

[bug#50397] [PATCH] Add python-crontab

[Pradana Adrinusa AUMARS via Guix-patches via]

From ff85b76d2f3b70887dfed17e3d8470c0761a7a28 Mon Sep 17 00:00:00 2001
From: Pradana AUMARS <paumars@courrier.dev>
Date: Sun, 5 Sep 2021 17:56:31 +0200
Subject: [PATCH] Add python-crontab

---
 gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7c70829de9..625415bb90 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -108,6 +108,7 @@
 ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
 ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -26556,3 +26557,26 @@ files and directories and adds a datestamp in standard ISO 8601+ format
 YYYY-MM-DD at the beginning of the file or directory name.")
       (home-page "https://github.com/novoid/date2name")
       (license license:gpl3+))))
+
+(define-public python-crontab
+  (package
+   (name "python-crontab")
+   (version "2.5.1")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (pypi-uri name version))
+     (sha256
+      (base32
+       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
+   (build-system python-build-system)
+   (arguments
+    ;; Comptability tests fail so they are disabled.
+    `(#:tests? #f))
+   (inputs
+    `(("python-dateutil" ,python-dateutil)))
+   (synopsis "Module for reading and writing crontab files")
+   (description "This Python module can read, write crontab files, and
+access the system cron automatically and simply using a direct API.")
+   (home-page "https://gitlab.com/doctormo/python-crontab/")
+   (license license:lgpl3+)))
-- 
2.33.0

[bug#50397] [PATCH] Add python-crontab

[Xinglu Chen]

[-- Attachment #1: Type: text/plain, Size: 2354 bytes --]

On Sun, Sep 05 2021, Pradana Adrinusa AUMARS via Guix-patches via wrote:

> From ff85b76d2f3b70887dfed17e3d8470c0761a7a28 Mon Sep 17 00:00:00 2001
> From: Pradana AUMARS <paumars@courrier.dev>
> Date: Sun, 5 Sep 2021 17:56:31 +0200
> Subject: [PATCH] Add python-crontab
>
> ---

Lacks proper commit message.  Whoever applies the patch can just copy
it from the v1 patch.

>  gnu/packages/python-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 7c70829de9..625415bb90 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -108,6 +108,7 @@
>  ;;; Copyright © 2021 Franck Pérignon <franck.perignon@univ-grenoble-alpes.fr>
>  ;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
>  ;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
> +;;; Copyright © 2021 Pradana Aumars <paumars@courrier.dev>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -26556,3 +26557,26 @@ files and directories and adds a datestamp in standard ISO 8601+ format
>  YYYY-MM-DD at the beginning of the file or directory name.")
>        (home-page "https://github.com/novoid/date2name")
>        (license license:gpl3+))))
> +
> +(define-public python-crontab
> +  (package
> +   (name "python-crontab")
> +   (version "2.5.1")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri (pypi-uri name version))
> +     (sha256
> +      (base32
> +       "0cccrqc10r8781ba81x8r2frs3pl2m4hkm599k5358ak0xr7xgjb"))))
> +   (build-system python-build-system)
> +   (arguments
> +    ;; Comptability tests fail so they are disabled.
> +    `(#:tests? #f))
> +   (inputs
> +    `(("python-dateutil" ,python-dateutil)))
> +   (synopsis "Module for reading and writing crontab files")
> +   (description "This Python module can read, write crontab files, and
> +access the system cron automatically and simply using a direct API.")
> +   (home-page "https://gitlab.com/doctormo/python-crontab/")
> +   (license license:lgpl3+)))
> -- 
> 2.33.0

For some reason I am still not able to apply the patch; I am getting the
same error as before.  I don’t have commit access though, so it doesn’t
matter that much anyway...  Assuming the package builds fine, LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

[bug#50397] [PATCH] Add python-crontab

[Nicolas Goaziou]

Hello,

Pradana Adrinusa AUMARS via Guix-patches via <guix-patches@gnu.org>
writes:

> Subject: [PATCH] Add python-crontab

Applied. Thank you!

Regards,
-- 
Nicolas Goaziou