unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
blob 895813c1f29cd376f3aa52f6a12d215fad8429ad 1468 bytes (raw)
name: gnu/packages/patches/biber-adapt-perl-5.36.patch 	 # note: path name is non-authoritative(*)

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
 
From d9e961710074d266ad6bdf395c98868d91952088 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 25 May 2022 12:41:59 +0200
Subject: [PATCH] Adapt to Perl 5.36

A developmental release of Perl 5.36.0 fails to run tests with:

    $ perl -Ilib t/basic-misc.t
    1..72
    Can't modify undef operator in scalar assignment at lib/Biber/Section.pm line 433, near "undef;"
    Compilation failed in require at lib/Biber.pm line 24.
    BEGIN failed--compilation aborted at lib/Biber.pm line 24.
    Compilation failed in require at t/basic-misc.t line 11.
    BEGIN failed--compilation aborted at t/basic-misc.t line 11.
    # Looks like your test exited with 255 before it could output anything.

This is because of a missing semicolon between commands in
del_everykeys(). The new perl is more strict and raises a compile-time
error:

    $ perl -e '$a = undef $b = undef;'
    Can't modify undef operator in scalar assignment at -e line 1, near "undef;"
    Execution of -e aborted due to compilation errors.
---
 lib/Biber/Section.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Biber/Section.pm b/lib/Biber/Section.pm
index 03ed69a51..a78942f57 100644
--- a/lib/Biber/Section.pm
+++ b/lib/Biber/Section.pm
@@ -429,7 +429,7 @@ sub add_everykey {
 
 sub del_everykeys {
   my $self = shift;
-  $self->{everykey} = undef
+  $self->{everykey} = undef;
   $self->{everykey_lc} = undef;
   return;
 }

debug log:

solving 895813c1f2 ...
found 895813c1f2 in https://git.savannah.gnu.org/cgit/guix.git

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).