From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GLmcAItkc2B/kwAAgWs5BA (envelope-from ) for ; Sun, 11 Apr 2021 23:05:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wGsHNopkc2A2GAAAbx9fmQ (envelope-from ) for ; Sun, 11 Apr 2021 21:05:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A09C513AB4 for ; Sun, 11 Apr 2021 23:05:14 +0200 (CEST) Received: from localhost ([::1]:59708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVhGb-0004Nk-QS for larch@yhetil.org; Sun, 11 Apr 2021 17:05:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVhGQ-0004NR-Ci for guix-patches@gnu.org; Sun, 11 Apr 2021 17:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVhGP-0000Vc-Vm for guix-patches@gnu.org; Sun, 11 Apr 2021 17:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVhGP-00016v-Po for guix-patches@gnu.org; Sun, 11 Apr 2021 17:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47006] [PATCH] gnu: Add zig. References: <20210308131155.7441-1-leo.prikler@student.tugraz.at> In-Reply-To: <20210308131155.7441-1-leo.prikler@student.tugraz.at> Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Apr 2021 21:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47006 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47006@debbugs.gnu.org Received: via spool by 47006-submit@debbugs.gnu.org id=B47006.16181750634216 (code B ref 47006); Sun, 11 Apr 2021 21:05:01 +0000 Received: (at 47006) by debbugs.gnu.org; 11 Apr 2021 21:04:23 +0000 Received: from localhost ([127.0.0.1]:55942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVhFn-00015w-1Y for submit@debbugs.gnu.org; Sun, 11 Apr 2021 17:04:23 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:33398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVhFl-00015n-8Q for 47006@debbugs.gnu.org; Sun, 11 Apr 2021 17:04:22 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id rZ4K2400A0mfAB406Z4KXT; Sun, 11 Apr 2021 23:04:19 +0200 Message-ID: <8937efa5c022c9791a0402cf561384057b29bc77.camel@telenet.be> From: Maxime Devos Date: Sun, 11 Apr 2021 23:04:15 +0200 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-kmhHoyzuIB5nzwlzP0xq" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1618175059; bh=EltjjgW36T5IbxSLHs3r58GyCyD5cJnGe1chRk2PhLQ=; h=Subject:From:To:Date; b=PyVRgul/p0o14bpEAajxJoA3jQYoHNUbVsx7DX0IYfFhfpMX/DtJvdkkdkbz8c983 YKNUXZpCsVSJhTmhr61Nc2HSk37e1Kg4PYzw1qC/Heh0Ql00JlrZl76tfXl3QfnYk2 i0iDzN7iZXsptL3ubuotC0gsViu2SQZvXC7Y4VZxuq5dtQQhBgm6X5IbktiXkjPrUP 9tzL9oQFzaSUl/s2g6Ha+jCArHJp3uN1DjZBuyeT4+v+dBjJsBrQLj4TAe6pzJqiUJ Z9Q9TADmMCIB99WU/3jtLU2A8O9p6eRy8t6h5K8pjeUzgdikEUt30iphzhVT7rf5u4 bpjOZDH7ixlnw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618175114; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EltjjgW36T5IbxSLHs3r58GyCyD5cJnGe1chRk2PhLQ=; b=eDB4wS/e3aVYupZpobXrK2TBawrt3ExVKD6CJHzItNL3/hFGrLq2IqX0zKYwkPy24zX3gB 8iefrSLBrGRpSYp6h8FLVxGgoMf81lkO/wCNo/br3doRKu/WlEGc1nG2t0cyIV7vFJ2LIf 14Z/EsE3+W/2sTq3+iVCt2G9E6cJ2p9agPScPNZ1x4SCikzyEZ27067s4zboJalCETWqgq xicCn7p4NbAQZ1GB/WsPtjBdMrGLAPY2FPPaoLSh78wVmFCxKiBHJie2MnMqI+epo/0JUZ wotV6oIHMmec5j4SjmSqDdP7cxP7Em2vihoIexMmkihwEEvr4hqcDsA1wyfH4A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618175114; a=rsa-sha256; cv=none; b=LZleY6dbSYo2mWLDuEmqeC04ZjFWZkQLE/FYOch432wKGMCQ72+a5bJpTcCTNeKfgjfm5f c7hMEpqJ43hq7uGDgWFPGQBoLfurqKaKbafIEImmv/5ZjlXVfNBX9fv9VtWfdFtX7TKyX2 dZnLsCL+4jnRMwQv6ak7KepiiRzH0ByHlcdBdb5eYksgbt7HagJhT4iV0UAUdqORLDzukO 79RRO3ChtgrXghDujqzqqVeOFFMqIQC0k0U1W5LuJnBOtH7EPz1/Kq6RR0TNMxzhsbDnPu gmWSwPTWXvcRPjT2EottfqL5lyxBniBIx+j8z9qjkVYkPP0tDmsINqBNdTv5gA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="PyVRgul/"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="PyVRgul/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A09C513AB4 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3tnZlbUCIZQA --=-kmhHoyzuIB5nzwlzP0xq Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable One comment below. > + (native-inputs > + `(("clang" ,clang-11) > + ("lld" ,lld) > + ("llvm" ,llvm-11))) This looks rather suspicious from a cross-compilation perspective. IIUC, lld and llvm are used for two purposes: * for compiling the "zig" compiler --> native-inputs is ok (or is GCC used to compile the zig compiler?) * as a run-time dependency of "zig" --> should be 'inputs' Therefore, shouldn't "lld" and "llvm" be added to "inputs" as well? TODO to self: define a variant of disallowed-references disallowed-references/native that refers to the package in 'native-inputs' instead of 'inputs'. Perhaps explicitely whitelist some inputs (llvm, lld, maybe some implicit libc inputs?). Note: according to me, *all* inputs in native-inputs should be added to disallowed-references *by default* when cross-compiling. Alternatively, I guess =E2=80=98we=E2=80=99 could simply add a comment ;; Cross-compilation is currently unsupported. and leave cross-compilation for later. My comments are mostly about =E2=80=98giving the good example=E2=80=99 on how to use inputs & native-inp= uts and avoid giving =E2=80=98bad examples=E2=80=99 of package definitions without markin= g them as such. Greetings, Maxime. --=-kmhHoyzuIB5nzwlzP0xq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHNkTxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7k8tAQDhufNU+AXFtLQEUOWjgqb/7s8O wb3gzwJ5NbTLpA+n4wEA60aECkxtERa4HaNzl5XDHHRPPXBoL+xG/W2bghBuGw8= =tY8T -----END PGP SIGNATURE----- --=-kmhHoyzuIB5nzwlzP0xq--