From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id MEIpBYQm3GNxPQAAbAwnHQ (envelope-from ) for ; Thu, 02 Feb 2023 22:09:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MD0VBYQm3GNYMAEA9RJhRA (envelope-from ) for ; Thu, 02 Feb 2023 22:09:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB53D3CD16 for ; Thu, 2 Feb 2023 22:09:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNgpL-0007GQ-Ve; Thu, 02 Feb 2023 16:09:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNgpK-0007Fd-9Y for guix-patches@gnu.org; Thu, 02 Feb 2023 16:09:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNgpK-0007Lz-1L for guix-patches@gnu.org; Thu, 02 Feb 2023 16:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNgpJ-0003Co-ND for guix-patches@gnu.org; Thu, 02 Feb 2023 16:09:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59866] [PATCH v6 2/3] services: mpd: Refactor MPD service. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Feb 2023 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , 59866@debbugs.gnu.org Received: via spool by 59866-submit@debbugs.gnu.org id=B59866.167537209312213 (code B ref 59866); Thu, 02 Feb 2023 21:09:01 +0000 Received: (at 59866) by debbugs.gnu.org; 2 Feb 2023 21:08:13 +0000 Received: from localhost ([127.0.0.1]:35978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNgoX-0003Av-50 for submit@debbugs.gnu.org; Thu, 02 Feb 2023 16:08:13 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNgoU-0003Ab-TV for 59866@debbugs.gnu.org; Thu, 02 Feb 2023 16:08:11 -0500 Received: by mail-ed1-f67.google.com with SMTP id x7so3417034edr.0 for <59866@debbugs.gnu.org>; Thu, 02 Feb 2023 13:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=TWE+EN4fhv7jn19p222cn9N2gGC/YnDlAOxisjcqVNw=; b=Dt7IJDzR072krK8IJRexGtWrBS6X751adskhZrsk6B83kaULEYVRXCOlGBbVLtlbID 8J+1k2Q2TM4lcdb+56n0KtW+yKxuNANeC/jYS3YhcSiIg1Umh5V2p3TGUl3iJwcOwrh6 ol1PUVKqN0w2O7j80VS82yY/OVEguU5p7qgg7JzuGU95aI1EbY3T5Sh/q0SC5M9nBb8m X9aYHuc+UVpbd0cwzxDm/xr33T+ACmBxFQw3zrBkX0y4HBfUMpG4sphohDEYRpPtc9wv h2otGpwIPHpMjkNdD8pLKNZGHuskea0rzUJ4MUfwN0qc+tkYiFqblkmCzcz3LT9ftqnW TezA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TWE+EN4fhv7jn19p222cn9N2gGC/YnDlAOxisjcqVNw=; b=DmI10wwV9fROLXbZMVLrwWNnUU7f89YI5pSmcDOKueAUE1/SWplzZOGGjPUEEUxxf2 6l3TeUvP68QOvKlnc+TxG6Ot/rj3N/oCo6fjIU41X9z1F9ek54D1qGVw412ZIyTZTmQA OiG3v8uV1ZE9LxEM+sqV1TVIQbA0kbc9WAU4CnfGbKvHwphC4mLpRosx+u4e90IDLWb2 XDqILAtQ4MMBPXYUei5g92vpiG6uyKNwZW5ZmtcmhIvEauJ1BLpbUy5irNZofm7Tbqp/ RiLJghjz1q5R/7Jen25qDeaOgxF7HfTyrukcvu5mH1eqB7Lh73l+FrM4Oie83NYw6OuC 5LBA== X-Gm-Message-State: AO0yUKVUJNutgZ8v0cns5+Is23BrU4HR898QuXAsJ1e1YIqFo33J3ZiH TS43KaIXgrT1PHkJRJ2ANWc= X-Google-Smtp-Source: AK7set/MYiqqsKJPC4ldKhQLkZa4A3x9bQerOMAG02vNCpMM8NTLshLueDraJY4lzZxFFjQknyvpSw== X-Received: by 2002:a05:6402:3894:b0:4a3:43c1:843b with SMTP id fd20-20020a056402389400b004a343c1843bmr3202943edb.15.1675372084889; Thu, 02 Feb 2023 13:08:04 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id s22-20020aa7cb16000000b004a236384909sm234528edt.10.2023.02.02.13.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 13:08:04 -0800 (PST) Message-ID: <88e71adf846525fbc1a964b24fb45e3e4b5c9208.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 02 Feb 2023 22:08:02 +0100 In-Reply-To: References: <23b0f83d1fd58fce9262d0b281b34e9678e21471.1675367583.git.mirai@makinata.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675372163; a=rsa-sha256; cv=none; b=Ge7TGJ7Ll+hnjD0BehNg1AiArmosOTomGNW3jMxDpOGU6CUUCxGLM/wI6j1wO1t7MmUNuP i8DTavnHLlcWYsXAAX9PcXBi6dO6CYKOjx64xeFi7GSC4B6LP6psW9QH/2IkN8GmymBh3h 8QGUWfRZKyvbz+oofM/9/H+gIXUoc6oHQCwGqrYlY5EmVIuk4uTYfcaG/Uz7PlajisBuZ2 i7iugc+QW3vJ9UirciScy9L0pfErpTKQxKSFkfeTll88q347TM/QeF5O/dLdvAWkOe6uqi K73pyqjpjl7cuStQDcyfqYqOiu5DuoDfpPZTxXKR/qFVgiZtNMtNY3mtgXolZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Dt7IJDzR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675372163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TWE+EN4fhv7jn19p222cn9N2gGC/YnDlAOxisjcqVNw=; b=eW4FKMNv0eaj+e1YxIXd7SutZeaRnRP+2Iu2oi0ZzC7kaU6aSH9OQ1eV6Auo4SgDOR+CJk 3dDHPuKRjl15blXLuH3ZR7jyUmWMjydmmEaYmH5x4Sk73ToCeXmIa3cuE3oNwnwu7nr20h o8dCO3w5BEr9SnSP0rOFppGfVMY+i6LCFGq0KXHHCGS7gd/Gd1GGQaoLv/5epK3nUq/mmb nS1PU0giE8Ix+XyGnyPtF669cOgAbXuE3vUyDKwlpNu3ToDpl7wzzI7K8iuuBD2eX102mF Av53D3F1RbWJkm9vWTl4kZQzEPXMuQRCIi4JMlj958Xzs2cVQa98+YWaul1sTw== X-Migadu-Spam-Score: -0.98 X-Spam-Score: -0.98 X-Migadu-Queue-Id: DB53D3CD16 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Dt7IJDzR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: e2AoW/Qfi+Dn Not a complete review yet, just some quick pointers. Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal: > Refactor mpd-service-type to support additional mpd.conf directives > and move activation-service-extension into service constructor. >=20 > * gnu/services/audio.scm > (mpd-plugin, mpd-partition): New record. No need to break the line before the paren here. > (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers > into a single procedure for alist interop. That's not a good docstring here. I think=C2=A0 (mpd-serialize-boolean): Delete variable. Move logic into... (mpd-serialize-field): ... this. explains what's going on better. > [...] > =C2=A0=C2=A0 #:use-module (srfi srfi-1) > +=C2=A0 #:use-module (srfi srfi-8) > =C2=A0=C2=A0 #:use-module (srfi srfi-26) We generally prefer SRFI 71. Cheers