unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Kei Kebreau <kei@openmailbox.org>
Cc: Vasile Dumitrascu <va511e@yahoo.com>, 26549@debbugs.gnu.org
Subject: bug#26549: [PATCH] gnu: Add emacs-google-maps.
Date: Sat, 22 Apr 2017 21:54:40 +0300	[thread overview]
Message-ID: <87zif89ssv.fsf@gmail.com> (raw)
In-Reply-To: <87fuh3klgo.fsf@openmailbox.org> (Kei Kebreau's message of "Thu, 20 Apr 2017 14:00:55 -0400")

Kei Kebreau (2017-04-20 14:00 -0400) wrote:

> Vasile Dumitrascu <va511e@yahoo.com> writes:
>
>> * gnu/packages/emacs.scm (emacs-google-maps): New variable.
>> ---
>>  gnu/packages/emacs.scm | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 673bbdf89..95298a0fa 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -1229,6 +1229,25 @@ or XEmacs.")
>>  the Emacs buffer.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-google-maps
>> +  (package
>> +    (name "emacs-google-maps")
>> +    (version "1.0.0")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/jd/google-maps.el/"
>> +                                  "archive/" version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "014bxapm4d8vjxbzrfjdpsavxyfx981mlcb10aq5rmigr6il8ybs"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/jd/google-maps.el")
>> +    (synopsis "Access Google Maps from Emacs")
>> +    (description "The @code{google-maps} package allows to display Google
>> +Maps directly inside Emacs.")
>> +    (license license:gpl1+)))
>
> I can't seem to find this license mentioned anywhere, but maybe I'm just
> missing it. Where can I find it mentioned?

I think it should be gpl3+, as GPL3 or later is mentioned in the *.el files.

>> +
>>  (define-public emacs-mmm-mode
>>    (package
>>      (name "emacs-mmm-mode")
>
> Other than finding the license, this patch looks fine.

I agree.  Vasile, could you resend this patch please, I can't apply it
to the current master, not sure what the problem is.

-- 
Alex

  reply	other threads:[~2017-04-22 18:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 23:09 bug#26549: [PATCH] gnu: Add emacs-google-maps Vasile Dumitrascu
2017-04-20 18:00 ` Kei Kebreau
2017-04-22 18:54   ` Alex Kost [this message]
2017-04-23 17:08     ` Vasile Dumitrascu
2017-04-23 23:25       ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zif89ssv.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=26549@debbugs.gnu.org \
    --cc=kei@openmailbox.org \
    --cc=va511e@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).