From: ludo@gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 27049@debbugs.gnu.org
Subject: bug#27049: [PATCH 2/2] gnu: Add js-mathjax.
Date: Sat, 03 Jun 2017 15:53:42 +0200 [thread overview]
Message-ID: <87zidpkwih.fsf@gnu.org> (raw)
In-Reply-To: <846e49f4.AEUAKzpfUbYAAAAAAAAAAAPEb_oAAAACwQwAAAAAAAW9WABZMcuW@mailjet.com> (Arun Isaac's message of "Sat, 3 Jun 2017 02:03:08 +0530")
Arun Isaac <arunisaac@systemreboot.net> skribis:
> * gnu/packages/javascript.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/javascript.scm (js-mathjax): New variable.
[...]
> + (for-each
> + (lambda (file)
> + (let ((install-path (string-append install-directory
> + ;; remove prefix "."
> + (string-drop file 1))))
> + (format #t "~a -> ~a~%" file install-path)
> + (cond
> + ((string-match "\\.js$" file)
> + (mkdir-p (dirname install-path))
> + (system (format #f "uglify-js ~a > ~a" file install-path)))
> + (else
> + (install-file file (dirname install-path))))))
> + (find-files "."))))))
Nitpick: in GNU “path” is used to denote search paths; we use “file
names” for files. So s/install-path/installed-file/ or something like
that.
(I already wrote about ‘system’ in another message.)
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2017-06-03 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170602203308.7606-1-arunisaac@systemreboot.net>
2017-06-02 20:33 ` bug#27049: [PATCH 2/2] gnu: Add js-mathjax Arun Isaac
2017-06-03 13:53 ` Ludovic Courtès [this message]
2017-06-04 18:57 ` Arun Isaac
[not found] ` <5f4eeea0.AEQALLKfIdMAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZNFgw@mailjet.com>
2017-06-05 10:10 ` Ludovic Courtès
2017-06-05 13:48 ` Arun Isaac
[not found] ` <20170602203308.7606-2-arunisaac@systemreboot.net>
2017-06-02 20:37 ` Arun Isaac
[not found] ` <b6247965.AEAAK4p8Z1kAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZMcyv@mailjet.com>
2017-06-03 13:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zidpkwih.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27049@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).