From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27308@debbugs.gnu.org
Subject: bug#27308: [PATCH] gnu: gnutls: Replace with 3.5.13.
Date: Sun, 11 Jun 2017 15:57:57 +0200 [thread overview]
Message-ID: <87zidesk2i.fsf@gnu.org> (raw)
In-Reply-To: <87mv9flry8.fsf@fastmail.com> (Marius Bakke's message of "Sat, 10 Jun 2017 18:37:19 +0200")
Marius Bakke <mbakke@fastmail.com> skribis:
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> I tested this graft on my profile, but apparently the grafting code
>> checks the store item length and refuses since the .13 is one byte
>> longer than .9:
[...]
> index 16df169ec..2b3b99cb1 100644
> --- a/guix/build/graft.scm
> +++ b/guix/build/graft.scm
> @@ -263,9 +263,9 @@ file name pairs."
> (((= hash+rest (origin-hash origin-string))
> .
> (= hash+rest (replacement-hash replacement-string)))
> - (unless (= (string-length origin-string)
> - (string-length replacement-string))
> - (error "replacement length differs from the original length"
> + (unless (<= (string-length origin-string)
> + (string-length replacement-string))
> + (error "replacement length is shorter than the original length"
That won’t work.
The workaround is to use a version string with the right length, say
“3.5.A”. It’s enough to allow users to distinguish it from the affected
version, so that’s okay IMO.
Ludo’.
prev parent reply other threads:[~2017-06-11 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 13:58 bug#27308: [PATCH] gnu: gnutls: Replace with 3.5.13 Marius Bakke
2017-06-10 14:29 ` Ludovic Courtès
2017-06-10 16:16 ` Marius Bakke
2017-06-10 16:37 ` Marius Bakke
2017-06-10 18:07 ` Marius Bakke
2017-06-10 23:05 ` Leo Famulari
2017-06-10 23:25 ` Marius Bakke
2017-06-11 13:57 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zidesk2i.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27308@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).