From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43711)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLmpS-0008SX-BG
	for guix-patches@gnu.org; Fri, 16 Jun 2017 04:42:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLmpO-00083S-Bo
	for guix-patches@gnu.org; Fri, 16 Jun 2017 04:42:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47519)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dLmpO-00083I-80
	for guix-patches@gnu.org; Fri, 16 Jun 2017 04:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dLmpN-0003Qv-VX
	for guix-patches@gnu.org; Fri, 16 Jun 2017 04:42:01 -0400
Subject: [bug#27327] [PATCH] bootloader: Add u-boot.
Resent-Message-ID: <handler.27327.B27327.149760246313123@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170611105838.24708-1-dannym@scratchpost.org>
Date: Fri, 16 Jun 2017 10:40:39 +0200
In-Reply-To: <20170611105838.24708-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Sun, 11 Jun 2017 12:58:38 +0200")
Message-ID: <87zid8gwag.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27327@debbugs.gnu.org

Hello,

(+Cc: Mathieu.)

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/bootloader/u-boot.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi: Document it.

[...]

> +;;;
> +;;; Bootloader definitions.
> +;;;
> +
> +(define u-boot-bootloader
> +  (bootloader
> +   (inherit extlinux-bootloader)
> +   (name 'u-boot)
> +   (package #f)
> +   (installer #f)))

I still find it weird to use #f for these two fields.

I would find it more reasonable to have, say, a =E2=80=98make-u-boot-bootlo=
ader=E2=80=99
that returns a <bootloader> with all the fields appropriately set (not
#f).  Otherwise it sounds like we=E2=80=99re going to have to deal with sup=
port
requests #about =E2=80=9Cwrong type to apply: #f=E2=80=9D, and I=E2=80=99d =
like to avoid that.
:-)

Can=E2=80=99t we just say that =E2=80=98package=E2=80=99 is always a <packa=
ge> and that
=E2=80=98installer=E2=80=99 is always a procedure?  Eventually we=E2=80=99l=
l hopefully arrange
to check that at macro-expansion time and/or via contracts.

WDYT?

Apart from that, pretty happy to see U-Boot finally making it into
GuixSD!

Ludo=E2=80=99.