From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW46M-0008PM-Q4
	for guix-patches@gnu.org; Fri, 14 Jul 2017 13:10:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW46L-0002vE-UV
	for guix-patches@gnu.org; Fri, 14 Jul 2017 13:10:02 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36573)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dW46L-0002v7-Qv
	for guix-patches@gnu.org; Fri, 14 Jul 2017 13:10:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dW46L-00019L-MQ
	for guix-patches@gnu.org; Fri, 14 Jul 2017 13:10:01 -0400
Subject: [bug#27682] [PATCH 2/2] gnu: Add lxc.
Resent-Message-ID: <handler.27682.B27682.15000521984406@debbugs.gnu.org>
From: Marius Bakke <mbakke@fastmail.com>
In-Reply-To: <20170713113157.1565-2-iyzsong@member.fsf.org>
References: <20170713113157.1565-1-iyzsong@member.fsf.org>
	<20170713113157.1565-2-iyzsong@member.fsf.org>
Date: Fri, 14 Jul 2017 19:09:54 +0200
Message-ID: <87zic7hrml.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>, 27682@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> writes:

> * gnu/packages/virtualization.scm (lxc): New package.

Thanks!

[...]

> +    (arguments
> +     '(#:configure-flags
> +       '("--sysconfdir=3D/etc"
> +         "--localstatedir=3D/var")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out         (assoc-ref outputs "out"))
> +                    (bashcompdir (string-append out "/etc/bash_completio=
n.d")))
> +               (zero? (system*
> +                       "make" "install"
> +                       (string-append "bashcompdir=3D" bashcompdir)
> +                       ;; Thoses files will be handled by system service=
s.
> +                       "LXCPATH=3D/tmp/var/lib/lxc"
> +                       "localstatedir=3D/tmp/var"
> +                       "sysconfdir=3D/tmp/etc"
> +                       "sysconfigdir=3D/tmp/etc/default"))))))))

If these are not important, why not set them to $out/etc, $out/var and
so on? /tmp seems like a dangerous default to me, since any unprivileged
user can populate these directories.

LGTM apart from that.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllo+uIACgkQoqBt8qM6
VPpEzgf5AUrW2xes7mPGxotkEflZk+ZavpuFRFnyLHT4UynZ0E/6yiiQ5HRt2dU8
LSo66FmfmMiRG0OxpyLP8r8T9UP7vtw6yQ643uRTkg1E8MwPA4BqGvzF2XzZd6Q6
NXXvXgshMrj8958mM3DxEn93p2pJWqU4MweG018DXnIIsjRHV7BasyZa485sE1tX
I4XQMivF/8EXGlBdH7hyKU3KPp8Ku/lyHsYDLkyMKs250lB4ezRF/9XXzZpmJDFY
PBIcfN2dUJAmfXW/lcd4EZUtWxaS2t4Xp74lY99CxGDtDv7o5jqq3O7fvXggn46j
T0e/N4CzJlJqQhbBzZzaHpROHDjUrg==
=0hWm
-----END PGP SIGNATURE-----
--=-=-=--